[PATCHv2 1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support

[PATCHv2 1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support

[Sebastian Reichel]

Properly describe reset related properties in the binding.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
Changes since PATCHv1:
 * https://lore.kernel.org/all/20221021171654.87071-1-sebastian.reichel@collabora.com/
 * dropped minItems (Krzysztof Kozlowski)
 * reset-names are not copy pasted and intentionally the same as
   the clock-names. DT looks like this:

   clocks = <&cru CCLK_EMMC>, <&cru HCLK_EMMC>,
            <&cru ACLK_EMMC>, <&cru BCLK_EMMC>,
            <&cru TMCLK_EMMC>;
   clock-names = "core", "bus", "axi", "block", "timer";
   resets = <&cru SRST_C_EMMC>, <&cru SRST_H_EMMC>,
            <&cru SRST_A_EMMC>, <&cru SRST_B_EMMC>,
            <&cru SRST_T_EMMC>;
   reset-names = "core", "bus", "axi", "block", "timer";
---
 .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml   | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
index 71f8e726d641..51ba44cad842 100644
--- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
@@ -45,6 +45,17 @@ properties:
       - const: block
       - const: timer
 
+  resets:
+    maxItems: 5
+
+  reset-names:
+    items:
+      - const: core
+      - const: bus
+      - const: axi
+      - const: block
+      - const: timer
+
   rockchip,txclk-tapnum:
     description: Specify the number of delay for tx sampling.
     $ref: /schemas/types.yaml#/definitions/uint8
-- 
2.35.1

Re: [PATCHv2 1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support

[Krzysztof Kozlowski]

On 07/11/2022 18:33, Sebastian Reichel wrote:
> Properly describe reset related properties in the binding.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCHv2 1/1] dt-bindings: mmc: sdhci-of-dwcmhsc: Add reset support

[Ulf Hansson]

On Mon, 7 Nov 2022 at 18:33, Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> Properly describe reset related properties in the binding.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
> Changes since PATCHv1:
>  * https://lore.kernel.org/all/20221021171654.87071-1-sebastian.reichel@collabora.com/
>  * dropped minItems (Krzysztof Kozlowski)
>  * reset-names are not copy pasted and intentionally the same as
>    the clock-names. DT looks like this:
>
>    clocks = <&cru CCLK_EMMC>, <&cru HCLK_EMMC>,
>             <&cru ACLK_EMMC>, <&cru BCLK_EMMC>,
>             <&cru TMCLK_EMMC>;
>    clock-names = "core", "bus", "axi", "block", "timer";
>    resets = <&cru SRST_C_EMMC>, <&cru SRST_H_EMMC>,
>             <&cru SRST_A_EMMC>, <&cru SRST_B_EMMC>,
>             <&cru SRST_T_EMMC>;
>    reset-names = "core", "bus", "axi", "block", "timer";
> ---
>  .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml   | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> index 71f8e726d641..51ba44cad842 100644
> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
> @@ -45,6 +45,17 @@ properties:
>        - const: block
>        - const: timer
>
> +  resets:
> +    maxItems: 5
> +
> +  reset-names:
> +    items:
> +      - const: core
> +      - const: bus
> +      - const: axi
> +      - const: block
> +      - const: timer
> +
>    rockchip,txclk-tapnum:
>      description: Specify the number of delay for tx sampling.
>      $ref: /schemas/types.yaml#/definitions/uint8
> --
> 2.35.1
>