From: 李维豪 <cn.liweihao@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v1 2/4] dt-bindings: clock: rk3368: add CLK_I2S_8CH_PRE and CLK_I2S_8CH_FRAC
Date: Sat, 6 Sep 2025 09:34:51 +0800 [thread overview]
Message-ID: <CAPEOAkRTVtKBsmiGTbKOCar0oNS-C3dRXqdpuowroRPH1bFS7g@mail.gmail.com> (raw)
In-Reply-To: <707aad1d-fcdb-4c66-8d96-41cf1a1b02ce@kernel.org>
Hi,
Krzysztof Kozlowski <krzk@kernel.org> 于2025年9月5日周五 22:13写道:
>
> On 05/09/2025 15:23, WeiHao Li wrote:
> > We need a clock id to assign clock parent when use i2s 8ch as audio
> > device, CLK_I2S_8CH_FRAC should be CLK_I2S_8CH_PRE parent so we can get
> > frequency we want.
> >
> > Signed-off-by: WeiHao Li <cn.liweihao@gmail.com>
> > ---
> > include/dt-bindings/clock/rk3368-cru.h | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/include/dt-bindings/clock/rk3368-cru.h b/include/dt-bindings/clock/rk3368-cru.h
> > index b951e29069..795e721957 100644
> > --- a/include/dt-bindings/clock/rk3368-cru.h
> > +++ b/include/dt-bindings/clock/rk3368-cru.h
> > @@ -183,6 +183,9 @@
> > #define HCLK_BUS 477
> > #define HCLK_PERI 478
> >
> > +#define CLK_I2S_8CH_PRE 500
>
> 479
>
> > +#define CLK_I2S_8CH_FRAC 501
>
> 480, no?
>
Neither of these clocks belong to the previous grouping in terms of
type, so I chose to start with a new integer id here.
Yours,
WeiHao
next prev parent reply other threads:[~2025-09-06 1:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 13:23 [PATCH v1 0/4] clk/rockchip: Fix I2S 8CH mclk output for RK3368 WeiHao Li
2025-09-05 13:23 ` [PATCH v1 1/4] clk: rockchip: rk3368: fix SCLK_I2S_8CH_OUT flags WeiHao Li
2025-09-05 13:23 ` [PATCH v1 2/4] dt-bindings: clock: rk3368: add CLK_I2S_8CH_PRE and CLK_I2S_8CH_FRAC WeiHao Li
2025-09-05 14:13 ` Krzysztof Kozlowski
2025-09-06 1:34 ` 李维豪 [this message]
2025-09-06 7:21 ` Krzysztof Kozlowski
2025-09-06 13:34 ` 李维豪
2025-09-06 13:57 ` Diederik de Haas
2025-09-05 13:23 ` [PATCH v1 3/4] clk: rockchip: rk3368: use clock ids " WeiHao Li
2025-09-05 13:23 ` [PATCH v1 4/4] arm64: dts: rockchip: Assign I2S 8 channel clock for rk3368 WeiHao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPEOAkRTVtKBsmiGTbKOCar0oNS-C3dRXqdpuowroRPH1bFS7g@mail.gmail.com \
--to=cn.liweihao@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).