Re: [PATCH v1 0/7] drm/rockchip: Add MIPI DSI support for RK3368

[李维豪 <cn.liweihao@gmail.com>]

Hi,

Heiko Stübner <heiko@sntech.de> 于2025年8月31日周日 23:10写道：

>
> Hi,
>
> Am Sonntag, 31. August 2025, 12:48:48 Mitteleuropäische Sommerzeit schrieb WeiHao Li:
> > This series adds MIPI DSI support for the Rockchip RK3368 SoC, enabling
> > native display connectivity through the MIPI DSI host controller and
> > PHY. The changes span multiple subsystems, including clock control,
> > DRM/VOP integration, DSI controller binding, and PHY driver updates.
> >
> > Key changes:
> >   - Update the Rockchip MIPI DSI PHY driver to preperly handle RK3368
> >     phy initialization.
>
> which patch is doing this, because I don't see any phy-related change
>

The first patch, changes for dw-mipi-dsi-rockchip.c, some settings for
mipi dphy.

Maybe I should adjust the description, it's a bit unclear.

> >   - Add missing lut_size of vop_data for RK3368.
> >   - Add missing clock ID SCLK_MIPIDSI_24M to the RK3368 CRU driver,
> >     which is required for enabling the 24MHz reference clock.
> >   - Add MIPI DSI node to rk3368.dtsi with correct clocks, resets,
> >     and register mappings.
> >
> > These changes were tested on a RK3368-based board with a MIPI DSI
> > panel [1]. The display boots successfully with console output.
> >
> > [1] https://ieiao.github.io/wiki/embedded-dev/rockchip/rk3368
>
> Do you plan on submitting this board to mainline?
> Because having an actual user of the code you're adding would
> be really really nice.
>

I'd be happy to submit this board support.

However, after searching for a while, I couldn't find the manufacturer
information of this device and mipi dsi panel. I am not sure whether
the devicetree support of unknown manufacturers allows submission to
mainline.


> Thanks
> Heiko
>
> >
> > Tested-by: WeiHao Li <cn.liweihao@gmail.com>
> > Signed-off-by: WeiHao Li <cn.liweihao@gmail.com>
> >
> > WeiHao Li (7):
> >   drm/rockchip: dsi: Add support for RK3368
> >   drm/rockchip: vop: add lut_size for RK3368 vop_data
> >   dt-bindings: clock: rk3368: Add SCLK_MIPIDSI_24M
> >   clk: rockchip: use clock ids for SCLK_MIPIDSI_24M on rk3368
> >   ARM: dts: rockchip: Add display subsystem for RK3368
> >   ARM: dts: rockchip: Add D-PHY for RK3368
> >   ARM: dts: rockchip: Add DSI for RK3368
> >
> >  arch/arm64/boot/dts/rockchip/rk3368.dtsi      | 79 +++++++++++++++++++
> >  drivers/clk/rockchip/clk-rk3368.c             |  2 +-
> >  .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c   | 20 +++++
> >  drivers/gpu/drm/rockchip/rockchip_vop_reg.c   |  1 +
> >  include/dt-bindings/clock/rk3368-cru.h        |  1 +
> >  5 files changed, 102 insertions(+), 1 deletion(-)
> >
> >
>
>
>
>

Best regards,
WeiHao