From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LUyqbVXO" Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19ED410E for ; Thu, 14 Dec 2023 07:55:15 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-28ade227850so2270105a91.2 for ; Thu, 14 Dec 2023 07:55:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702569314; x=1703174114; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=F3dEU5MDIKfW+qCgC0PdqFKd7O+g3bLPZxWTXEaaam8=; b=LUyqbVXObIzpamKp0fyTc+Rjv3sguhqfdpED9TmePWCZv+DQG/dqABjbEk0V9Q+uRg nD0pZis1uUfhbvMV5ZpUNXnIWzvwEmssJkxnzs5vknuwPWCN1CQFOmtEBppmxh4xVxS6 KcrEUnjnK8ll51DompifLrq+hhtrACZorfqCrAFgGokXqwzz/3AkrYjEhKgdJLf8TKHD WNqSuGRt/DTZNcxdV6vGL5bfJKU6P5WWvmwqoz12BOSNydE17EfFC/y6fSisGB7bCKks uDImIVJsm27r8qyePzoYzOkSF4SS9POTHWtJC1EWaCCwdjeQhG+t67dnl1Ft3Bi+gBue fr3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702569314; x=1703174114; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F3dEU5MDIKfW+qCgC0PdqFKd7O+g3bLPZxWTXEaaam8=; b=vnRPfT/u+TOkwOQNxWNBGQc5Ruc9Dr9nfTdGisliXytDOWigmJUhFIeTnOdEsheo0L mRirI4+47QgcUEb5Y68UX1hQ2no8oC1ArtBlc+pEwt6W8YgYFURlNVgAa78szSzqzywk 4ThI3wcE9PgVe01+NfUEM4T3XUJ3P3InyzEV6Lnl6QHbFSPVoVKU9WXKVmIS0ulK8MTH RpZoIgsLr36qTskv3Ne4Ikn/xJKS1KarqfBHrKiGpHJvpvMNrxq83M1Xjl7hqb1naptd tEM4wQmzEn/hZRUP1xyjXYEh+3xdDrJBBDBWuZxrjooA56OWm6UQyfA0mnZd1pn74JEG SAGw== X-Gm-Message-State: AOJu0Yy4XublZvDvdGKLEE8lMDauZMz+zTiForQ6Le7V05pCGdIuSEIV uOw3k9riZD808zcGQx9DCqD9Q3PABOSrHU7+IGghWA== X-Google-Smtp-Source: AGHT+IGkTnLdOtrqyXltKJs1dUID0ysgTZE7BI1PV4SJTjovnObU8OGLzeMvBOaKswBq0xLjC9rksw67hcvGeMcAL24= X-Received: by 2002:a17:90b:948:b0:28a:e356:459b with SMTP id dw8-20020a17090b094800b0028ae356459bmr2009364pjb.34.1702569314569; Thu, 14 Dec 2023 07:55:14 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231214105243.3707730-1-tudor.ambarus@linaro.org> <20231214105243.3707730-12-tudor.ambarus@linaro.org> In-Reply-To: <20231214105243.3707730-12-tudor.ambarus@linaro.org> From: Sam Protsenko Date: Thu, 14 Dec 2023 09:55:03 -0600 Message-ID: Subject: Re: [PATCH 11/13] arm64: dts: exynos: gs101: enable eeprom on gs101-oriole To: Tudor Ambarus , krzysztof.kozlowski+dt@linaro.org Cc: peter.griffin@linaro.org, robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, andi.shyti@kernel.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, catalin.marinas@arm.com, will@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, arnd@arndb.de, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Dec 14, 2023 at 4:53=E2=80=AFAM Tudor Ambarus wrote: > > Enable the eeprom found on the battery connector. > > Signed-off-by: Tudor Ambarus > --- > .../boot/dts/exynos/google/gs101-oriole.dts | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/ar= m64/boot/dts/exynos/google/gs101-oriole.dts > index 4a71f752200d..11b299d21c5d 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts > +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts > @@ -63,6 +63,19 @@ &ext_200m { > clock-frequency =3D <200000000>; > }; > > +&hsi2c_8 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&hsi2c8_bus>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; Not sure if those 4 above properties belong in board's dts or in SoC's dtsi. Krzysztof, what do you think? Other than that: Reviewed-by: Sam Protsenko > + status =3D "okay"; > + > + eeprom: eeprom@50 { > + compatible =3D "atmel,24c08"; > + reg =3D <0x50>; > + }; > +}; > + > &pinctrl_far_alive { > key_voldown: key-voldown-pins { > samsung,pins =3D "gpa7-3"; > @@ -99,6 +112,11 @@ &usi_uart { > status =3D "okay"; > }; > > +&usi8 { > + samsung,mode =3D ; > + status =3D "okay"; > +}; > + > &watchdog_cl0 { > timeout-sec =3D <30>; > status =3D "okay"; > -- > 2.43.0.472.g3155946c3a-goog >