From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B5CC678D5 for ; Tue, 7 Mar 2023 17:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231717AbjCGRlo (ORCPT ); Tue, 7 Mar 2023 12:41:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232043AbjCGRla (ORCPT ); Tue, 7 Mar 2023 12:41:30 -0500 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE592A6BDA for ; Tue, 7 Mar 2023 09:37:28 -0800 (PST) Received: by mail-pl1-x635.google.com with SMTP id h8so14903405plf.10 for ; Tue, 07 Mar 2023 09:37:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678210648; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=o3zPHvN5mm4IalrCf6zpCmyS4kHEJ7HoGLzRUhQSOoA=; b=o2ytZ6qS0PtfXoLYe5TafISzM6/h2NxL3pqfUqiGJeoJyjjcLmWruuJ3X0G/cQZI/Y GA8IYvcfCRsdkKAPInrw3325Sv6gVIjQvQZMQxeDW96heslTnIO2xfDZjDmjHC8W6S8x 8Z/2W26QDYD+sh27LwKdicEwMxzzwNiKSCkfYYiyxDmhqDTlfyv/GgQVFNeN9y63ynUc FJWQqXZIYzZfNoOQhPSUGyELPnY1YZET2qLKlry8+WtVnxDK6ZPqoUCsVZmIiYTHYfmu AdbkopUuQy/vh3LicKLoQLp/1cN+bszEMZwG8pn13IbJ1xhfs2KAVC1bJolPRpetFKGQ 3vcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678210648; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o3zPHvN5mm4IalrCf6zpCmyS4kHEJ7HoGLzRUhQSOoA=; b=EbWdHy+oZyksVWOEumlNVNNJvVvq4VqVHZ10JzK+W7NOY5sAIVZjpt0V5IJKutZUOI b42kPMuOhvz4lvm4pzBA5bKkX0NPp+cjuXZxi5FhMlyCyxYXHlnTknaYcIKxDDnrHLSS KAQ8lMt0Um5Pc459uiAcCqkpX7WwKLLSOfFs3QhS1TNmWktpVmHyJLkEZcCwu+wmeClE srlG7mLbinqTjAOGW9YHYAg4/q7HPdpDT2Eb/gDy6Wa/8+agDO3HRJ/WOzErhUjQgrpb 7eRTKmH2N69sMdvPQaFX1NK9EltoN0UxL31ReqknXl/HKPLR3yh3voGC1M/fP76ObZ3W yKAw== X-Gm-Message-State: AO0yUKU3WUH9K0uOGYM42uZ/BlwzU8qAUVIGm/rVH4uhMKV5cwxhanJw QM8lrq+AOAExG/2iwSQx0sfWYI3Ue4mcr+Cp3bwMqQ== X-Google-Smtp-Source: AK7set+Kh/juOXVGFGBZq6ZQe/2ECYCsr+2HZ6cR5iMeJ5OSD5b0x9Znktqaib7dBWyXbAGUvwFiALZMirOESQVRZNg= X-Received: by 2002:a17:90a:9295:b0:233:fa52:828e with SMTP id n21-20020a17090a929500b00233fa52828emr5658345pjo.1.1678210648212; Tue, 07 Mar 2023 09:37:28 -0800 (PST) MIME-Version: 1.0 References: <20230223042133.26551-1-semen.protsenko@linaro.org> <167811290503.11716.15730246749418548221.b4-ty@linaro.org> <48c8a0cf-08dc-a831-33ef-3b8e32eef2d3@linaro.org> <3a27febc-4d4e-1cfd-45dc-6ade4f25ca13@linaro.org> In-Reply-To: <3a27febc-4d4e-1cfd-45dc-6ade4f25ca13@linaro.org> From: Sam Protsenko Date: Tue, 7 Mar 2023 11:37:17 -0600 Message-ID: Subject: Re: [PATCH v2 0/6] clk: samsung: exynos850: Add missing clocks for PM To: Krzysztof Kozlowski Cc: Chanwoo Choi , Sylwester Nawrocki , Rob Herring , Chanho Park , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Tomasz Figa , linux-arm-kernel@lists.infradead.org, Stephen Boyd , Alim Akhtar , linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Michael Turquette , David Virag , Sumit Semwal Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 7 Mar 2023 at 01:47, Krzysztof Kozlowski wrote: > > On 06/03/2023 19:55, Sam Protsenko wrote: > > On Mon, 6 Mar 2023 at 09:51, Krzysztof Kozlowski > > wrote: > >> > >> On 06/03/2023 15:28, Krzysztof Kozlowski wrote: > >>> On Wed, 22 Feb 2023 22:21:27 -0600, Sam Protsenko wrote: > >>>> As a part of preparation for PM enablement in Exynos850 clock driver, > >>>> this patch series implements CMU_G3D, and also main gate clocks for AUD > >>>> and HSI CMUs. The series brings corresponding changes to bindings, the > >>>> driver and SoC dts file. > >>>> > >>>> Changes in v2: > >>>> - Rebased all patches on top of the most recent soc/for-next tree > >>>> - Added A-b and R-b tags > >>>> - Minor fixes > >>>> > >>>> [...] > >>> > >>> Applied, thanks! > >>> > >>> [1/6] dt-bindings: clock: exynos850: Add Exynos850 CMU_G3D > >>> https://git.kernel.org/krzk/linux/c/067ba1605806e52118bb598afb357718df9f0e19 > >>> [2/6] dt-bindings: clock: exynos850: Add AUD and HSI main gate clocks > >>> https://git.kernel.org/krzk/linux/c/e289665ed0d6df9fca3ebc128f1232d305e4600b > >>> [3/6] clk: samsung: clk-pll: Implement pll0818x PLL type > >>> https://git.kernel.org/krzk/linux/c/a6feedab8ab9a9e4483deb0bcc87919d92c88b7e > >>> [4/6] clk: samsung: exynos850: Implement CMU_G3D domain > >>> https://git.kernel.org/krzk/linux/c/c5704a56893b4e77e434597c7c53d878bb3073b0 > >>> [5/6] clk: samsung: exynos850: Add AUD and HSI main gate clocks > >>> https://git.kernel.org/krzk/linux/c/d8d12e0d079aff4b1d8079a0a55944c0596f1d67 > >>> [6/6] arm64: dts: exynos: Add CMU_G3D node for Exynos850 SoC > >>> https://git.kernel.org/krzk/linux/c/ad8f6ad9a4f219950df65731a8ff91baa022c4b0 > >> > >> And builds are broken. Please mention in cover letter or commit > >> dependencies and ordering... > >> > > > > Just checked all most recent commits on your for-next and next/clk > > branches. Seem to build fine for me. AFAIR I checked all patches in > > that series, and I guess there shouldn't be any issues if you apply > > those in the same order they are numbered inside the series. Or you > > mean you have some clash between different series? Anyways, I'm glad > > to help, but I'd need more details on where exactly the problem is (or > > maybe you already fixed it?). > > The builds were failing after I applied everything to respective > branches (so DTS separate). I did not notice that your DTS and driver > (both) depend on bindings header constant. This requires special > handling. It actually always required, because it was going through > different trees. Now it goes through my tree, but I still need to handle > it. I reworked the branches and force-pushed, thus you did not see the > exact issue. > Thanks for explaining this. Next time I'll provide the dependencies info in my patch #0. > Best regards, > Krzysztof >