From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F4041F4C84 for ; Tue, 7 Oct 2025 14:32:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759847562; cv=none; b=H5AusIWL6C2ZAild291J6IX8Q6Nz1D3oMTjZD8IKrkdIRKCT5NJDHBp6Inu76xPU6bNBWVX9jZFg2uSOVpMPiSvW0X2fZZB60xvyXHg+N2SnGhFvIIhARerskGIAV5OKuNDcQ9aXsJmkCX7hpMt5rfd51PyBNCYr3GeVov/fpZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759847562; c=relaxed/simple; bh=nsPAIctrIJysjDJphYW6JckvkqC/Wzx7w+aZj9zKjOM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=g+udz+WsR98hg5qQpjWGaY9ax7aeIG/Zuc1VKJQa4lL0lGF1IkzUF6arGyWTBNAdUoyNi0yUeDFP1rfWp+cLu7wmDUx8PY3Oc4iezRrHmenNF21ESLRjOj/xEUNNbNd8lIsz7WR6XYNsT+tUwvA7YuMFv+vwbwqYk4aOt09ine0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kme6tXru; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kme6tXru" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-7f7835f4478so43958176d6.1 for ; Tue, 07 Oct 2025 07:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759847559; x=1760452359; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K6Ko9EuByB72AmPY68qaHZeiB7esoLxBKg9O0pS8bew=; b=Kme6tXru5j21Xay7GawF7B3eokvH5plviWSqXyvk04PYtvlrGG04x2cDne8ygSbcNi SkzvK9Z2tx+bxn5o77veoKjxdXmoZ8rADS5YgKUqISjgQDqMxYovJ/83JmaR1GE2tuqv AMR9L9DGE8kqVgQr1tb/x8dFaLKD+zSoFl4VAOrfHRkhgdiYGbG3nSg+m8h2ogaoY7xI vH2dnZkQy+cHQ3cPP4APlVB6js0a56w8zwJYy2dkp3C9RMTolcM6qvfLSrxzLbxhxcO1 +zcZ+Lsrz/fFFvqzZ00Tzqfxt2VQVqCmsqp9tBy/12iA/SyM/XUn5a2Pve9GKAnn9VWH 1e/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759847559; x=1760452359; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K6Ko9EuByB72AmPY68qaHZeiB7esoLxBKg9O0pS8bew=; b=DrAl+D9DXk7y4zbam+7bpsSIfZKgh/v9Xd1bMzyLV/gln5XiL7I5DCcuay+L6/H6hJ qWzvXwQoWTlhQ5RO8a+nhVA5J9cEi/Pw0aUvnpCNE+onzB91krZIpV8VKttpcZ+1Pslf fqnIr4EVRCJJ2l8kX6jPG2ExUU6y6qhd9b5sWMVScWZxx1ZJBKNXue7ntzLNfm2D0X2Y mA1/sYhG+DJcTSHhb8apnyCZpG55Z4+09njeOLzodeu3A+2bsW+e3Y5WEWeB1AMuDWaC OUhcyBwwYXIDgFIvLjGZ9L1tXrRhZvWQmrzRcWczKt+JBW9mIMGtJKQNu9+b2A+50OjF klGg== X-Forwarded-Encrypted: i=1; AJvYcCUmLZy6HS0VB7YRybxFew8qMGr1xRdcfC/00Mq+FnJiwAb23TDV8Mv+0dGJCg62jnqm7zgSs8OaA0GV@vger.kernel.org X-Gm-Message-State: AOJu0YxZ/OSwGbB0ZqvFuGN7qcqwqBdM7UBtOBgQFNh/kjy/jkdQDzDT T2pvrEv3PVioO+POtU5BzSIEdciQfd4qCIlL+6sO26xjD5y6YEWqPbvomVWvkbidzd/8FBFnTAz NSXa8+1RAa6WACPCLqlZyfoJxl4rH/Ag= X-Gm-Gg: ASbGncsKUem5ShR3B9qTqtRckCQv5DbYTyq0pDCZ2hO6vFn04iJ3ohevbzQDzACLCV4 CbAELk8Ve+a+41I+GY8upoW21njRCFil1SaVsN631lNQ2T4qgcKz5U6QMCG1lZRJHJera/E2QA5 dkdLW/7OzxvDcFJvm7U7xMhzVAV6rFzi7XXepM9M/Lz3saQvGaNmqngOcGsrTvBNvRz7m9QmuDm YeTSCfYC8W5e75vcr3EC3Nhok/+FGt+djWHmEoNJQk= X-Google-Smtp-Source: AGHT+IEyCKpYps/3BGc22BxSR5vdUK9H945UNs5mFpXR5FmYYn0yozFBPVoQCqHwhbvW2Mk1hUuA7PjHSd59EhPjCTw= X-Received: by 2002:a05:6214:1c4d:b0:78d:63c4:9d5c with SMTP id 6a1803df08f44-879dc7abcf0mr199677706d6.5.1759847559189; Tue, 07 Oct 2025 07:32:39 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250929065714.27741-1-jjm2473@gmail.com> <20250929065714.27741-4-jjm2473@gmail.com> In-Reply-To: From: jjm2473 Date: Tue, 7 Oct 2025 22:32:26 +0800 X-Gm-Features: AS18NWBCvYOruCThhN8XGst8DvyIOMmZ1iSy5xv_cE-cTej27zRd1fN4u0hMtEY Message-ID: Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: add LinkEase EasePi R1 To: Andrew Lunn Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, quentin.schulz@cherry.de, kever.yang@rock-chips.com, naoki@radxa.com, honyuenkwun@gmail.com, inindev@gmail.com, ivan8215145640@gmail.com, neil.armstrong@linaro.org, mani@kernel.org, dsimic@manjaro.org, pbrobinson@gmail.com, alchark@gmail.com, didi.debian@cknow.org, jbx6244@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Andrew Lunn =E4=BA=8E2025=E5=B9=B410=E6=9C=886=E6=97=A5=E5= =91=A8=E4=B8=80 23:51=E5=86=99=E9=81=93=EF=BC=9A > > > +&gmac0 { > > + phy-mode =3D "rgmii"; > > Did i really miss this patch series in its earlier version, or did you > ignore me? > > https://elixir.bootlin.com/linux/v6.15/source/Documentation/devicetree/bi= ndings/net/ethernet-controller.yaml#L287 > > > + tx_delay =3D <0x3c>; > > + rx_delay =3D <0x2f>; > > Please change it to rgmii-id, and smaller tx/rx_delay values. Or show > us the schematics which clearly show extra long clock lines. > > > +/* Micro SD card slot is not mounted */ > > +&sdmmc0 { > > + max-frequency =3D <150000000>; > > + no-sdio; > > + no-mmc; > > + bus-width =3D <4>; > > + cap-mmc-highspeed; > > + cap-sd-highspeed; > > + disable-wp; > > + pinctrl-names =3D "default"; > > + pinctrl-0 =3D <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>; > > + vmmc-supply =3D <&vcc3v3_sd>; > > + vqmmc-supply =3D <&vccio_sd>; > > + status =3D "disabled"; > > +}; > > + > > +/* Wifi module is not mounted */ > > +&sdmmc2 { > > What do you mean by "not mounted"? > > Often you would say "not populated", to indicate the PCB has all the > tracks in place, but the chip has simply not been soldered in place. > > Or is there a connector here, and nothing plugged into the connector? > > Andrew Andrew: Hello! I ran `./scripts/get_maintainer.pl patches-v4/v4-0003-arm64-dts-rockchip-add-LinkEase-EasePi-R1.patch` to get maintainer list, and got: ``` Rob Herring (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Krzysztof Kozlowski (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,commit_signer:3/41=3D7%) Conor Dooley (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Heiko Stuebner (maintainer:ARM/Rockchip SoC support,commit_signer:43/41=3D100%,authored:4/41=3D10%,added_lines:12/117= =3D10%,commit_signer:5/6=3D83%) Quentin Schulz (commit_signer:10/41=3D24%,authored:8/41=3D20%,added_lines:63/117=3D54%) Dragan Simic (commit_signer:5/41=3D12%,commit_signer:1= /6=3D17%) FUKAUMI Naoki (commit_signer:3/41=3D7%,authored:3/41=3D7%,removed_lines:1/1=3D100%) Peter Robinson (added_lines:9/117=3D8%,commit_signer:1/6=3D17%,authored:1/6=3D17%) Alexey Charkov (added_lines:6/117=3D5%) Diederik de Haas (commit_signer:4/6=3D67%,authored:3/6=3D50%) Liangbin Lian (commit_signer:1/6=3D17%,authored:1/6=3D1= 7%) Johan Jonker (authored:1/6=3D17%) devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC suppo= rt) linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support) linux-kernel@vger.kernel.org (open list) ``` your email address is not listed above. And I did not receive your comment on the previou versions. The latest v4 version is here https://lore.kernel.org/all/20250930055017.67610-1-jjm2473@gmail.com/ . > What do you mean by "not mounted"? > > Often you would say "not populated", to indicate the PCB has all the > tracks in place, but the chip has simply not been soldered in place. > > Or is there a connector here, and nothing plugged into the connector? The chip/slot has not been soldered. So here should be "not populated", forgive my poor English. > Please change it to rgmii-id, and smaller tx/rx_delay values. Or show > us the schematics which clearly show extra long clock lines. In fact, the RTL8211F's RXDLY and TXDLY signals are both pulled low, just like the Banana Pi BPI-R2 Pro, so the configuration is also referenced= : https://elixir.bootlin.com/linux/v6.15/source/arch/arm64/boot/dts/rockchip/= rk3568-bpi-r2-pro.dts#L237 The tx_delay and rx_delay values were obtained using Rockchip's automatic scanning tool: https://github.com/istoreos/istoreos/blob/54746dfdb5bd34d1f281cf41d1d1620d0= c3ee686/target/linux/rockchip/files/drivers/net/ethernet/stmicro/stmmac/dwm= ac-rk-tool.c https://gitlab.com/firefly-linux/docs/-/blob/rk356x/firefly/Common/GMAC/Roc= kchip_Developer_Guide_Linux_GMAC_RGMII_Delayline_EN.pdf https://github.com/axlrose/rkdocs/blob/main/Common/GMAC/Rockchip_Developer_= Guide_Linux_GMAC_RGMII_Delayline_EN.pdf I will try changing phy-mode =3D "rgmii-id" later to see if gmac continues to work properly. Liangbin Lian