From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rahul Sharma Subject: Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver Date: Fri, 16 May 2014 15:12:01 +0530 Message-ID: References: <1400095043-685-1-git-send-email-rahul.sharma@samsung.com> <1400095043-685-2-git-send-email-rahul.sharma@samsung.com> <5373CBAD.2010505@gmail.com> <53753527.3000905@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53753527.3000905@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomasz Figa Cc: Tomasz Stanislawski , "devicetree@vger.kernel.org" , linux-samsung-soc , PANKAJ KUMAR DUBEY , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , sunil joshi , Andrzej Hajda , Kyungmin Park , Rob Herring , Grant Likely , Kukjin Kim , Sylwester Nawrocki , Kishon Vijay Abraham I List-Id: devicetree@vger.kernel.org On 16 May 2014 03:14, Tomasz Figa wrote: > On 15.05.2014 06:01, Rahul Sharma wrote: >> Thanks Tomasz, >> >> On 15 May 2014 01:31, Tomasz Figa wrote: >>> Hi Rahul, Tomasz, >> [snip] >>>> + simplephys: simple-phys@10040000 { >>>> + compatible = "samsung,exynos5250-simple-phy"; >>> >>> Missing reg property or unnecessary @unit-address suffix in node name. >> >> I should have removed "@unit-address". I will change this. >> >>> >>>> + samsung,pmu-syscon = <&pmu_system_controller>; >>>> + #phy-cells = <1>; >>>> + }; >>> >>> In general, the idea is quite good, but I think this should rather bind >>> to the main PMU node, since this is just a part of the PMU, not another >>> device in the system. This also means that the PMU node itself should be >>> the PHY provider. >>> >> >> Please correct me if I got you wrong. You want somthing like this: >> >> pmu_system_controller: system-controller@10040000 { >> ... >> simple_phys: simple-phys { >> compatible = "samsung,exynos5420-simple-phy"; >> ... >> }; >> }; > > Not exactly. > > What I meant is that the PMU node itself should be the PHY provider, e.g. > > pmu_system_controller: system-controller@10040000 { > /* ... */ > #phy-cells = <1>; > }; > > and then the PMU node should instantiate the Exynos simple PHY driver, > as this is a driver for a facility existing entirely inside of the PMU. > Moreover, the driver should be rather called Exynos PMU PHY. > > I know this isn't really possible at the moment, but with device tree we > must design things carefully, so it's better to take a bit more time and > do things properly. > > So my opinion on this is that there should be a central Exynos PMU > driver that claims the IO region and instantiates necessary subdrivers, > such as Exynos PMU PHY driver, Exynos CLKOUT driver, Exynos cpuidle > driver and more, similar to what is being done in drivers/mfd. Hi Tomasz, > > Now, there is already ongoing effort to convert current freestanding PMU > configuration code in mach-exynos into a full-fledged PMU driver, but > not exactly in the same direction as I stated above. I'll try to > cooperate with Pankaj, who is responsible for this work to make this go > into the right track. > > Best regards, > Tomasz > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel