From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rahul Sharma Subject: Re: [PATCH v8 1/3] ARM: EXYNOS: initial board support for exynos5260 SoC Date: Mon, 28 Apr 2014 12:03:21 +0530 Message-ID: References: <1397620738-14431-1-git-send-email-rahul.sharma@samsung.com> <1397620738-14431-2-git-send-email-rahul.sharma@samsung.com> <534E3803.5010404@gmail.com> <534E3AE7.10907@gmail.com> <00eb01cf5e7b$4eb9edf0$ec2dc9d0$@samsung.com> <0b4101cf613e$eb2d87d0$c1889770$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <0b4101cf613e$eb2d87d0$c1889770$@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Kukjin Kim Cc: Tomasz Figa , Sachin Kamat , Rahul Sharma , linux-samsung-soc , "devicetree@vger.kernel.org" , linux-arm-kernel , sunil joshi , Pankaj Dubey , Arnd Bergmann , Olof Johansson List-Id: devicetree@vger.kernel.org Hi Tomasz, Please share your opinion. Regards, Rahul Sharma On 26 April 2014 16:31, Kukjin Kim wrote: > Rahul Sharma wrote: >> >> Hi Kukjin, >> > Hi, > >> Need this macro to enable build for clock driver. >> > I found it in your patch, "clk/exynos5260: add clock file for exynos5260". > For consistency, I'm fine on this, if Tomasz has no objection me to pick > this into samsung tree for the 5260 clock stuff > "drivers/clk/samsung/Makefile". > > Thanks, > Kukjin > >> Regards, >> Rahul Sharma. >> >> >> On 22 April 2014 15:36, Kukjin Kim wrote: >> > Tomasz Figa wrote: >> >> >> >> On 16.04.2014 10:08, Sachin Kamat wrote: >> >> > Hi Tomasz, >> >> > >> >> > On 16 April 2014 13:27, Tomasz Figa wrote: >> >> >> Hi Rahul, >> >> >> >> >> >> >> >> >> On 16.04.2014 05:58, Rahul Sharma wrote: >> >> >>> >> >> >>> From: Pankaj Dubey >> >> >>> >> >> >>> This patch add basic arch side support for exynos5260 SoC. >> >> >>> >> >> >>> Signed-off-by: Pankaj Dubey >> >> >>> Signed-off-by: Rahul Sharma >> >> >>> Reviewed-by: Tomasz Figa >> >> >>> --- >> >> >>> arch/arm/mach-exynos/Kconfig | 5 +++++ >> >> >>> 1 file changed, 5 insertions(+) >> >> >>> >> >> >>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach- >> >> exynos/Kconfig >> >> >>> index fc8bf18..bf4ed87 100644 >> >> >>> --- a/arch/arm/mach-exynos/Kconfig >> >> >>> +++ b/arch/arm/mach-exynos/Kconfig >> >> >>> @@ -84,6 +84,11 @@ config SOC_EXYNOS5250 >> >> >>> help >> >> >>> Enable EXYNOS5250 SoC support >> >> >>> >> >> >>> +config SOC_EXYNOS5260 >> >> >>> + bool "SAMSUNG EXYNOS5260" >> >> >>> + default y >> >> >>> + depends on ARCH_EXYNOS5 >> >> >>> + >> >> >>> config SOC_EXYNOS5420 >> >> >>> bool "SAMSUNG EXYNOS5420" >> >> >>> default y >> >> >>> >> >> >> >> >> >> Is this patch necessary now? After Sachin's consolidation series >> there >> >> are >> >> >> no per SoC entries anymore. >> >> > >> >> > Kukjin still wanted individual SoCs to be selectable. Please refer >> [1]. >> >> > >> >> > [1] http://www.spinics.net/lists/devicetree/msg27040.html >> >> >> >> I don't think any valid reason was presented there. Features in code >> >> should not be selected using #ifdef CONFIG_ anymore, so I don't really >> >> see any reason to not proceed with this consolidation. Olof, Arnd? >> >> >> > Hi, >> > >> > Yeah, in this case, nothing happened with adding SOC_EXYNOS5260. So I >> don't have any idea why this is required. >> > >> > - Kukjin >> > >