Re: [PATCH 2/4] ARM: dts: add support for mixer to exynos4

[Rahul Sharma <r.sh.open@gmail.com>]

On Mon, Jan 28, 2013 at 2:34 AM, Sylwester Nawrocki
<sylvester.nawrocki@gmail.com> wrote:
> On 01/25/2013 11:39 AM, Rahul Sharma wrote:
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi
>> b/arch/arm/boot/dts/exynos4.dtsi
>> index 6c2c79d..07cb7d4 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -296,4 +296,12 @@
>>                 interrupts =<0 95 0>;
>>                 hpd-gpio =<&gpx3 7 0xf 1 3>;
>>         };
>> +
>> +       mixer: mixer {
>> +               compatible = "samsung,exynos4-mixer";
>
>
> I'm afraid this compatible property it too generic. Is the video mixer IP
> really identical an all the Exynos4 series SoCs ?
>

It is same in Exynos4210, 4212 and 4412.

>
>> +               reg =   <0x12c10000 0x10000>,
>> +                       <0x12c00000 0x10000>;
>> +               interrupts =<0 91 0>;
>> +               samsung,power-domain =<&pd_tv>;
>> +       };
>>   };
>
>
> Is there documentation for these new bindings available somewhere ?
>

it is there at Documentation/devicetree/bindings/drm/exynos/mixer.txt.
Probably I
need to add details for power domain node property.

regards,
Rahul Sharma.

> --
>
> Thanks,
> Sylwester