* [PATCH -next] spi/qspi: fix missing unlock on error in ti_qspi_start_transfer_one()
@ 2013-09-01 1:01 Wei Yongjun
2013-09-01 12:48 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-09-01 1:01 UTC (permalink / raw)
To: broonie, grant.likely, rob.herring; +Cc: yongjun_wei, linux-spi, devicetree
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Add the missing unlock before return from function ti_qspi_start_transfer_one()
in the error handling case.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/spi/spi-ti-qspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index 136d71e..e12d962 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -376,6 +376,7 @@ static int ti_qspi_start_transfer_one(struct spi_master *master,
ret = qspi_transfer_msg(qspi, t);
if (ret) {
dev_dbg(qspi->dev, "transfer message failed\n");
+ mutex_unlock(&qspi->list_lock);
return -EINVAL;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] spi/qspi: fix missing unlock on error in ti_qspi_start_transfer_one()
2013-09-01 1:01 [PATCH -next] spi/qspi: fix missing unlock on error in ti_qspi_start_transfer_one() Wei Yongjun
@ 2013-09-01 12:48 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-09-01 12:48 UTC (permalink / raw)
To: Wei Yongjun; +Cc: grant.likely, rob.herring, yongjun_wei, linux-spi, devicetree
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
On Sun, Sep 01, 2013 at 09:01:00AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing unlock before return from function ti_qspi_start_transfer_one()
> in the error handling case.
Applied, thanks. There's no need to send this to the devicetree people,
there is no DT change in this patch.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-01 12:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-01 1:01 [PATCH -next] spi/qspi: fix missing unlock on error in ti_qspi_start_transfer_one() Wei Yongjun
2013-09-01 12:48 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).