Re: [PATCH v2 3/6] Add fdtget utility to read property values from device tree

[Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>]

Hi David,

On Mon, Sep 19, 2011 at 1:05 AM, David Gibson
<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
> On Sun, Sep 18, 2011 at 10:46:04PM -0700, Simon Glass wrote:
>> Hi David,
>>
>> On Sun, Sep 18, 2011 at 7:04 PM, David Gibson
>> <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
>> > On Fri, Sep 16, 2011 at 09:25:10AM -0700, Simon Glass wrote:
>> >> Hi David,
>> > [snip]
>> >> > One useful extension of what you have now might be to add a "raw
>> >> > binary" format.  Not much use for humans, but could be handy for
>> >> > scripts extracting blobs from the device tree.  In fact, using the
>> >> > same interpretation of existing printf() descriptors, that would
>> >> > actually be equivalent to 'c'.
>> >>
>> >> Yes I was thinking about how to do that as it might be useful. I think
>> >> 'c' makes perfect sense. Will add to the todo.
>> >
>> > Actually, on second thoughts using 'c' for this doesn't quite work.
>> > For the other format specifiers, you will presumably have some sort of
>> > separator between each repeat (newline, I'm guessing).  True binary
>> > output, obviously, doesn't want that.
>>
>> There is a space between each repeat and a newline after each property
>> printed. It makes sense to suppress the space for binary output and I
>> think an option to flick this switch either way might be in order, too
>> (even something to select a new separator char?). Something else for
>> the todo once this patch set is in perhaps.
>
> Yeah, fair enough.  I don't think skipping the separators should be
> explicit one way or another, not a magic side-effect of using a 'c'
> type.

OK I think you are saying you want an explicit switch.

>
>> I suppose we need to be a bit careful not to build out the pier too
>> far until we have some pedestrian traffic.
>
> A good point.
>
>> Did you see patch set 3?
>
> Uh, no I don't think so.

OK I will resend to list.

Regards
Simon

>
> --
> David Gibson                    | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
>                                | _way_ _around_!
> http://www.ozlabs.org/~dgibson
>