From: Simon Glass <sjg@chromium.org>
To: Olof Johansson <olof@lixom.net>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Devicetree Discuss <devicetree-discuss@lists.ozlabs.org>,
Stephen Warren <swarren@nvidia.com>,
Jerry Van Baren <vanbaren@cideas.com>,
Tom Warren <twarren@nvidia.com>
Subject: Re: [PATCH v3 22/23] tegra: fdt: Add EMC data for Tegra2 Seaboard
Date: Tue, 3 Apr 2012 17:47:41 -0700 [thread overview]
Message-ID: <CAPnjgZ0xS2rv688y6VTNMX27OctBURn+jC2QN7HaSFqUy1jZ8g@mail.gmail.com> (raw)
In-Reply-To: <CAOesGMh1OaJ9DDj+xxfOf268J93WbOmpZSJutBLB3xQ+6W4C-w@mail.gmail.com>
Hi Olof,
On Mon, Apr 2, 2012 at 10:22 PM, Olof Johansson <olof@lixom.net> wrote:
> On Mon, Apr 2, 2012 at 4:19 PM, Simon Glass <sjg@chromium.org> wrote:
>> This adds timings for T20 and T25 Seaboards, using the bindings found here:
>>
>> http://patchwork.ozlabs.org/patch/132928/
>>
>> We supply both full speed options for normal running, and half speed options
>> for testing / development.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>
> This seems incorrect to me. You provide both T20 and T25 EMC tables in
> the same device tree with no way to determine which one to use.
>
> Unfortunately nvidia didn't use the boot straps to tell if they were
> on a t20 or t25 seaboard, so you'll just have to know. At the kernel
> side we chose to just ditch T20 since most boards still in use are
> T25.
The selection of memory speed is down to the board. There is a later
patch in this series (just cc'd to you) which looks at the SOC ID to
determine whether it is T20 or T25, and selects the speed accordingly.
This speed is used to look up the correct table in the device tree
>
>
>
> -Olof
Regards,
Simon
next prev parent reply other threads:[~2012-04-04 0:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1333408743-28720-1-git-send-email-sjg@chromium.org>
2012-04-02 23:18 ` [PATCH v3 02/23] fdt: Add function to return next compatible subnode Simon Glass
[not found] ` <1333408743-28720-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-04-02 23:18 ` [PATCH v3 01/23] fdt: Add function to locate an array in the device tree Simon Glass
2012-04-02 23:19 ` [PATCH v3 20/23] fdt: tegra: Add EMC node to " Simon Glass
2012-04-02 23:19 ` [PATCH v3 22/23] tegra: fdt: Add EMC data for Tegra2 Seaboard Simon Glass
2012-04-03 5:22 ` Olof Johansson
2012-04-04 0:47 ` Simon Glass [this message]
2012-04-05 21:58 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ0xS2rv688y6VTNMX27OctBURn+jC2QN7HaSFqUy1jZ8g@mail.gmail.com \
--to=sjg@chromium.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
--cc=twarren@nvidia.com \
--cc=u-boot@lists.denx.de \
--cc=vanbaren@cideas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).