From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Subject: Re: [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard Date: Tue, 28 Feb 2012 09:37:57 -0800 Message-ID: References: <1330375973-10681-1-git-send-email-sjg@chromium.org> <1330375973-10681-12-git-send-email-sjg@chromium.org> <4F4C11E9.1050907@nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF17BDDF1D6A@HQMAIL01.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF17BDDF1D6A-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: U-Boot Mailing List , Tom Warren , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jerry Van Baren , Devicetree Discuss List-Id: devicetree@vger.kernel.org Hi Stephen, On Tue, Feb 28, 2012 at 9:32 AM, Stephen Warren wr= ote: > Simon Glass wrote at Tuesday, February 28, 2012 10:21 AM: >> On Mon, Feb 27, 2012 at 3:29 PM, Stephen Warren = wrote: >> > On 02/27/2012 01:52 PM, Simon Glass wrote: >> >> Add the definition of the oscillator clock frequency. >> > >> >> diff --git a/board/nvidia/dts/tegra2-seaboard.dts b/board/nvidia/= dts/tegra2-seaboard.dts >> > >> >> + =A0 =A0 clock@60006000 { >> >> + =A0 =A0 =A0 =A0 =A0 =A0 clocks =3D <&osc>; >> >> + =A0 =A0 }; >> > >> > The CAR takes two clock inputs; one 32KHz clock (typically from th= e >> > PMU/PMIC) and one from the oscillator. The 32KHz one is missing he= re. I >> > guess this won't make any difference to U-Boot since it isn't usin= g the >> > clock inputs in the CAR driver, but it'd be best if the .dts file >> > contained the correct content so it didn't act as an incorrect exa= mple. >> > See the example in the binding documentation for what should be th= ere. >> >> Yes I saw that - but it adds an i2c binding which I don't yet have. = I >> add i2c in the next series. >> >> I will add that one i2c node here. > > The clock doesn't /have/ to be represented by its full I2C source; yo= u > could represent it as another global fixed-clock source until the I2C > node is available to act as a clock source. > > Note that in order to actually use the tps6586x node to provide the > clock source, you'll need to write or modify the tps6586x's bindings = to > document which clock sources it provides. I haven't actually looked a= t > the tps6586x's bindings at all; it's possible that part of the exampl= e > is entirely incorrect. In my original email I quoted above, the part > of the example I was caring about was that the CAR itself needs two > entries in its clocks property; I don't really care where they come f= rom > at present. I don't have tps6586x bindings and don't have support for them in U-Boot at present. U-Boot also doesn't look at the clocks property so I think your request is entirely about keeping things in sync with what we expect will go into the kernel in the future. I am going to add your binding, less the #clock-cells which U-Boot currently can't support because it conflicts with the C preprocessor (at some point I may look at a patch to use sed or some other means of avoiding this). Regards, Simon > > -- > nvpublic >