devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ujfalusi, Peter" <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
To: Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	Mark Brown
	<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
	Liam Girdwood <lrg-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH] Input: twl6040-vibra: Update for device tree support
Date: Mon, 21 May 2012 12:45:07 +0300	[thread overview]
Message-ID: <CAPo=G1ypT3T+yhFZF9W4Go1v+nPZM05QQwND-OVgCddccvb4KA@mail.gmail.com> (raw)
In-Reply-To: <20120521053159.GA30285-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1031 bytes --]

Hi Dmitry,

On Monday, May 21, 2012, Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hmm, I am getting:
>
>  CC      drivers/input/misc/twl6040-vibra.o
> drivers/input/misc/twl6040-vibra.c: In function ‘twl6040_vibra_probe’:
> drivers/input/misc/twl6040-vibra.c:263:9: error: implicit declaration of
> function ‘of_find_node_by_name’ [-Werror=implicit-function-declaration]
> drivers/input/misc/twl6040-vibra.c:263:42: warning: initialization makes
> pointer from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
> make[1]: *** [drivers/input/misc/twl6040-vibra.o] Error 1
> make: *** [drivers/input/misc/twl6040-vibra.o] Error 2
>
>
> it looks like there is no stub for of_find_node_by_name().

I'm on holiday at the moment without a way to check this.
I think it is better to skip this patch for now until I got back.

It might be that we need to include the of_device.h as well?

Sorry about it.

Regards,
Péter

-- 
Péter

[-- Attachment #1.2: Type: text/html, Size: 1230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

      parent reply	other threads:[~2012-05-21  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16 11:19 [PATCH] Input: twl6040-vibra: Update for device tree support Peter Ujfalusi
2012-05-16 19:35 ` Dmitry Torokhov
2012-05-16 19:55   ` Ujfalusi, Peter
2012-05-17  0:59     ` Dmitry Torokhov
     [not found]     ` <CAPo=G1zf1XJcoKgCxMn3X09T0LOUG-9aw3iopqC7OPqcuc5hcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-21  5:32       ` Dmitry Torokhov
     [not found]         ` <20120521053159.GA30285-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2012-05-21  9:45           ` Ujfalusi, Peter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPo=G1ypT3T+yhFZF9W4Go1v+nPZM05QQwND-OVgCddccvb4KA@mail.gmail.com' \
    --to=peter.ujfalusi-l0cymroini0@public.gmane.org \
    --cc=broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org \
    --cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lrg-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).