From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ujfalusi, Peter" Subject: Re: [PATCH] Input: twl6040-vibra: Update for device tree support Date: Mon, 21 May 2012 12:45:07 +0300 Message-ID: References: <1337167186-8535-1-git-send-email-peter.ujfalusi@ti.com> <20120516193546.GA15920@core.coreip.homeip.net> <20120521053159.GA30285@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4973496787165681211==" Return-path: In-Reply-To: <20120521053159.GA30285-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Dmitry Torokhov Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , Mark Brown , Liam Girdwood List-Id: devicetree@vger.kernel.org --===============4973496787165681211== Content-Type: multipart/alternative; boundary=e89a8f234341d877a904c088c141 --e89a8f234341d877a904c088c141 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Dmitry, On Monday, May 21, 2012, Dmitry Torokhov wrote: > Hmm, I am getting: > > CC drivers/input/misc/twl6040-vibra.o > drivers/input/misc/twl6040-vibra.c: In function =91twl6040_vibra_probe=92= : > drivers/input/misc/twl6040-vibra.c:263:9: error: implicit declaration of > function =91of_find_node_by_name=92 [-Werror=3Dimplicit-function-declarat= ion] > drivers/input/misc/twl6040-vibra.c:263:42: warning: initialization makes > pointer from integer without a cast [enabled by default] > cc1: some warnings being treated as errors > make[1]: *** [drivers/input/misc/twl6040-vibra.o] Error 1 > make: *** [drivers/input/misc/twl6040-vibra.o] Error 2 > > > it looks like there is no stub for of_find_node_by_name(). I'm on holiday at the moment without a way to check this. I think it is better to skip this patch for now until I got back. It might be that we need to include the of_device.h as well? Sorry about it. Regards, P=E9ter --=20 P=E9ter --e89a8f234341d877a904c088c141 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi Dmitry,

On Monday, May 21, 2012, Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> Hmm, I am getting:
>
> =A0CC =A0 =A0 =A0drivers/input/mi= sc/twl6040-vibra.o
> drivers/input/misc/twl6040-vibra.c: In function =91twl6040_vibra_probe= =92:
> drivers/input/misc/twl6040-vibra.c:263:9: error: implicit decl= aration of
> function =91of_find_node_by_name=92 [-Werror=3Dimplicit-= function-declaration]
> drivers/input/misc/twl6040-vibra.c:263:42: warning: initialization mak= es
> pointer from integer without a cast [enabled by default]
>= cc1: some warnings being treated as errors
> make[1]: *** [drivers/i= nput/misc/twl6040-vibra.o] Error 1
> make: *** [drivers/input/misc/twl6040-vibra.o] Error 2
>
>=
> it looks like there is no stub for of_find_node_by_name().

= I'm on holiday at the moment without a way to check this.
I think it= is better to skip this patch for now until I got back.

It might be that we need to include the of_device.h as well?

Sor= ry about it.

Regards,
P=E9ter

--
P=E9ter
--e89a8f234341d877a904c088c141-- --===============4973496787165681211== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============4973496787165681211==--