Re: [PATCH] arm64: dts: marvell: mcbin: add sdhci

From: Marcin Wojtas <mw@semihalf.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: marvell: mcbin: add sdhci
Date: Tue, 16 May 2017 17:40:57 +0200	[thread overview]
Message-ID: <CAPv3WKf4GcOc7g-2yMCjGN4HrftDL0Ro6jHErQL8-zSH-tC10w@mail.gmail.com> (raw)
In-Reply-To: <E1dAcn4-0004z2-Fl@rmk-PC.armlinux.org.uk>

[-- Attachment #1: Type: text/plain, Size: 2245 bytes --]

Russel,

2017-05-16 15:45 GMT+02:00 Russell King <rmk+kernel@armlinux.org.uk>:

> Add sdhci support for MACCHIATOBin boards.  This uses the AP806 SDHCI
> for eMMC and CP110 master for the SD card slot.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>
> This version labels up the uSD connector, adds the vqmmc regulator for
> the uSD (the regulator itself already present in the DT), and supports
> the card detect signal.
>
> For eMMC, this version adds the vqmmc regulator, which again is already
> present in the DT, marks it as not supporting SD or SDIO, and also
> includes "slow mode" since testing with previous versions of the driver
> have shown that selecting faster speeds results in errors.
>
>  arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts |   23
> ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> index cc167e05941a..60111ed3234a 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> @@ -95,6 +95,21 @@
>         status = "okay";
>  };
>
> +&ap_sdhci0 {
> +       bus-width = <8>;
> +       /*
> +        * Not stable in HS modes - phy needs "more calibration", so add
> +        * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
> +        */
> +       marvell,xenon-phy-slow-mode;
>

FYI, this property is by default present in armada-ap806.dtsi.

Marcin

> +       no-1-8-v;
> +       no-sd;
> +       no-sdio;
> +       non-removable;
> +       status = "okay";
> +       vqmmc-supply = <&v_vddo_h>;
> +};
> +
>  &cpm_i2c0 {
>         clock-frequency = <100000>;
>         status = "okay";
> @@ -105,6 +120,14 @@
>         status = "okay";
>  };
>
> +&cpm_sdhci0 {
> +       /* U6 */
> +       broken-cd;
> +       bus-width = <4>;
> +       status = "okay";
> +       vqmmc-supply = <&v_3_3>;
> +};
> +
>  &cpm_usb3_0 {
>         /* J38? - USB2.0 only */
>         status = "okay";
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

[-- Attachment #2: Type: text/html, Size: 3536 bytes --]