From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F59C433ED for ; Thu, 13 May 2021 08:38:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EADE1613F6 for ; Thu, 13 May 2021 08:38:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231939AbhEMIjs (ORCPT ); Thu, 13 May 2021 04:39:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231981AbhEMIjs (ORCPT ); Thu, 13 May 2021 04:39:48 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A385BC061574 for ; Thu, 13 May 2021 01:38:37 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id h4so26109898wrt.12 for ; Thu, 13 May 2021 01:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:content-transfer-encoding:date:message-id:to:cc :subject:from:references:in-reply-to; bh=YPyHABehcPKN0gbmBVN79yfxXtPiGFE8c/l3J3/fASM=; b=bhwgaS7JCh4fHnxhGgDKBZdEul7kPMnJeM2/4+hsqBeTHtgNMlqmsPzFNgy8dsQFDf kS4Sg9TYXtMFgR0sDg5sdbnztvNC0ofRJob/5iwOgtCB7Qs3msSA+ph99J3L7Cxs1Rg0 69a4urNcs7o6kEUVy2GuW868t6iBQjgEmJ1iDdDjASFRQVyUR5oDtWXrpMT0E5z0T4Ct oJ7Drp+KxH6PoK7YxRENWlLzLR509dxFMwf/41hwzjo5vI88iVXGq2IOk64PXsHVuEVj l5bR3KJlXokJJWPOaYXjF31JE5TDGBkO1WS4EkzJYnvMzWVEu4dZmA3Bqtdwt9uM0T1P AmGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:date :message-id:to:cc:subject:from:references:in-reply-to; bh=YPyHABehcPKN0gbmBVN79yfxXtPiGFE8c/l3J3/fASM=; b=Qj41HN3SAWWXilw3vpNVbLxfYlnJCT5JKOYZyg6oi2VqWi30BYN79UxL+XTlPbdv+M NxEfNY/8HiLQZBKIWU69XVThmrMv62+GMeQSYIlhA2dg4U+N6khUuIcnXNmZ/gn55UQW t/Zdl4dLKhcFJx7z/7d6BwutajYt2kEbZlOM7XMekfpkzMOmZqWpl8Nkwx8Xxf1/1Kia 04UEx8PAP1/UxW0nsQAhiWVpn5Zp6epmgiK7NVrlx78fvre0aHoecZ0tHEBdZN6XFqPI Cvq2tIuDbRRG0fOfWf3ljfULZUxz1ttCs4IGc+yzDkuOG40fGWq+4XkUgLlv+8q2Z+PQ M3Hg== X-Gm-Message-State: AOAM532s4A5COF2enpOAQNQT/fhRTuybJyi3uiJCfyVTfqE3Rs8uVr3i 0d3op8hjnMQJpUQ/t6yoU6f0FcHVnrfiaw== X-Google-Smtp-Source: ABdhPJzDJYwmbvF06LrEStYKzwizktBy/fQeBfAcsB5As9gYXBp2Ycjf6GDCV+n/EjQalmb0Q8Bs0Q== X-Received: by 2002:adf:d1e1:: with SMTP id g1mr51033253wrd.401.1620895116329; Thu, 13 May 2021 01:38:36 -0700 (PDT) Received: from localhost (a109-49-46-234.cpe.netcabo.pt. [109.49.46.234]) by smtp.gmail.com with ESMTPSA id c15sm2138294wrr.3.2021.05.13.01.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 01:38:36 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 13 May 2021 09:38:35 +0100 Message-Id: To: "Rob Herring" Cc: "Greg Kroah-Hartman" , "Sebastian Siewior" , "Laurent Pinchart" , , Subject: Re: [PATCH v2 8/9] dt-bindings: usb: nxp,isp1760: add bindings From: "Rui Miguel Silva" References: <20210511085101.2081399-1-rui.silva@linaro.org> <20210511085101.2081399-9-rui.silva@linaro.org> <20210511192213.GA2451465@robh.at.kernel.org> In-Reply-To: <20210511192213.GA2451465@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, Thanks for the review. On Tue May 11, 2021 at 8:22 PM WEST, Rob Herring wrote: > On Tue, May 11, 2021 at 09:51:00AM +0100, Rui Miguel Silva wrote: > > The nxp,isp1760 driver is old in the tree, but did not had a bindings > > entry, since I am extend it to support isp1763 in the same family, use > > this to add a proper yaml bindings file. > >=20 > > Signed-off-by: Rui Miguel Silva > > --- > > .../devicetree/bindings/usb/nxp,isp1760.yaml | 59 +++++++++++++++++++ > > 1 file changed, 59 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/nxp,isp1760.y= aml > >=20 > > diff --git a/Documentation/devicetree/bindings/usb/nxp,isp1760.yaml b/D= ocumentation/devicetree/bindings/usb/nxp,isp1760.yaml > > new file mode 100644 > > index 000000000000..0d76529e9662 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/nxp,isp1760.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/usb/nxp,isp1760.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NXP ISP1760 family controller bindings > > + > > +maintainers: > > + - Sebastian Siewior > > + - Laurent Pinchart > > + > > +description: | > > + NXP ISP1760 family, which includes ISP1760/1761/1763 devicetree cont= roller > > + bindings > > + > > +properties: > > + compatible: > > + enum: > > + - nxp,usb-isp1760 > > + - nxp,usb-isp1761 > > + - nxp,usb-isp1763 > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > In the 1761 datasheet, looks like there's a separate host and device=20 > irq. Good catch, I miss that in the ISP1761 case. > > > + > > + bus-width: > > + description: > > + Number of data lines. > > + enum: [8, 16, 32] > > + default: 32 > > + > > + dr_mode: > > + enum: > > + - host > > + - peripheral > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +additionalProperties: true > > Like what? 'true' is only correct for common collections of properties. You are right, will fix in v4, thanks. ------ Cheers, Rui > > > + > > +examples: > > + - | > > + #include > > + usb@40200000 { > > + compatible =3D "nxp,usb-isp1763"; > > + reg =3D <0x40200000 0x100000>; > > + interrupts-parent =3D <&gic>; > > + interrupts =3D ; > > + bus-width =3D <16>; > > + dr_mode =3D "host"; > > + }; > > + > > +... > > --=20 > > 2.31.1 > >=20