Re: [RFC PATCH 1/2] dt-bindings: input: add ST-Microelectronics FTS2BA61Y touchscreen binding

["Eric Gonçalves" <ghatto404@gmail.com>]

On September 14, 2025 11:48:49 AM GMT-03:00, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>On 11/09/2025 23:19, Eric Gonçalves wrote:
>> Add the bindings for ST-Microelectronics FTS2BA61Y capacitive touchscreen.
>
>Please wrap commit message according to Linux coding style / submission
>process (neither too early nor over the limit):
>https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
The commit description is 74 characters
long, and the name is 73?
>
>A nit, subject: drop second/last, redundant "bindings". The
>"dt-bindings" prefix is already stating that these are bindings.
>See also:
>https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Thanks, will do!
>> 
>> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
>
>
>
>> +
>> +properties:
>> +  compatible:
>> +    const: st,fts2ba61y
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  avdd-supply: true
>> +  vdd-supply: true
>> +
>> +unevaluatedProperties: false
>
>This goes after required: field.
>
>Other than that - why isn't this finished (non RFC)? Code looks ok, but
>I also did not look that thorough.
>
>Best regards,
>Krzysztof