From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFA71C433EF for ; Fri, 20 May 2022 11:42:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245364AbiETLmO (ORCPT ); Fri, 20 May 2022 07:42:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236511AbiETLmN (ORCPT ); Fri, 20 May 2022 07:42:13 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE6BAD029D for ; Fri, 20 May 2022 04:42:10 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id m20so15070297ejj.10 for ; Fri, 20 May 2022 04:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=mime-version:content-transfer-encoding:date:message-id:cc:subject :from:to:references:in-reply-to; bh=wS/ZZ/XGdYJivGUIc7glIv8A/QnED+cfdPx1Mf0OR3o=; b=GB72r8xYURZ6bzQkm22Tu7tonI4ZKXJGQRhTtyxiRTudpMondZELrlYY1Xhwk/RTh7 5Zeda7d68kYmu4UCNIN7fS1lTpbwBNmqbf4icxZKokgVZAw3IURsvL0hYvjRsQQt94SW 8g3F5Vr/0cKVHhCmBXZcWzC0wiq7c3V0JSaC3VnVhKiPnqLTbIVVrxOldU6Csho//iAb i+1fml2hr9pQ0FUoqm5dGGC4coiMNgTvLt6e50kn9jusRG5SCBeCbTcL00riYCnnhFaf YFkN3NQQ4g90z5x59jFrDWx4eRldBx1pjejiDJWfm3XVu8iRY29x1FFUUaukXe6wZQ0h /hHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:content-transfer-encoding:date :message-id:cc:subject:from:to:references:in-reply-to; bh=wS/ZZ/XGdYJivGUIc7glIv8A/QnED+cfdPx1Mf0OR3o=; b=dNQts9cGLMyekhCGdHH3QRoTc5J8WJnRCSDBr/lOJVTSrd8fBafYcchpbA+V0BurfE gMu4RXkb+M97fpMPVodiy4HPZSwRS85iq5mID51JSseB1UV1Hvg9MizNR8rNi9eo5XnQ 4lhw9J2l6LhndiihteqdYsMbuR+K/xQzsLF3ypVKvQRuSjpgWAokRSBX24Maq1Og9IVz 68QhbW0nhnQRRNbUidQV+L8UnvI+nf64Ov4+dQXmxxBw6Fog3tAnCJwWu07j3SltK6Ow 0rlhFsl9rAml90mlRGb1bFldJlcA53JefvsyvNj/dfxuG645B+Qn41afkiCUNybLDYY5 DH0w== X-Gm-Message-State: AOAM530GIZT+lMFY44gwMoXgKzGdxOSWLF1WDfPSm/BjYw+oOfn8HVDG pV8VXwA4pRZ3fiLGkVrKQbFtQg== X-Google-Smtp-Source: ABdhPJy7fnm73XK7inxXakUomDMt4LomtggIToBNbNojpFIo5Eg5Y2uqDhzYDPx7fPeRzTTy50Yt/g== X-Received: by 2002:a17:906:7b82:b0:6f3:ee8d:b959 with SMTP id s2-20020a1709067b8200b006f3ee8db959mr8591524ejo.458.1653046929316; Fri, 20 May 2022 04:42:09 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id w6-20020a170907270600b006f3ef214dedsm3036390ejk.83.2022.05.20.04.42.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 04:42:08 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 May 2022 13:42:08 +0200 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, , "Andy Gross" , "Bjorn Andersson" , "Georgi Djakov" , "Rob Herring" , "Krzysztof Kozlowski" , "Odelu Kukatla" , , , Subject: Re: [PATCH v2 3/5] dt-bindings: interconnect: qcom: Reuse new rpmh-common bindings From: "Luca Weiss" To: "Krzysztof Kozlowski" , X-Mailer: aerc 0.9.0 References: <20220520070318.48521-1-luca.weiss@fairphone.com> <20220520070318.48521-4-luca.weiss@fairphone.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On Fri May 20, 2022 at 12:33 PM CEST, Krzysztof Kozlowski wrote: > On 20/05/2022 09:03, Luca Weiss wrote: > > Stop defining the properties twice and use the ones provided in the new > > qcom,rpmh-common.yaml. > >=20 > > Signed-off-by: Luca Weiss > > --- > > Changes since v1: > > * New patch > >=20 > > .../bindings/interconnect/qcom,rpmh.yaml | 22 +++++-------------- > > 1 file changed, 5 insertions(+), 17 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.y= aml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > index fae3363fed02..e822dc099339 100644 > > --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml > > @@ -18,6 +18,9 @@ description: | > > least one RPMh device child node pertaining to their RSC and each p= rovider > > can map to multiple RPMh resources. > > =20 > > +allOf: > > + - $ref: qcom,rpmh-common.yaml# > > + > > properties: > > reg: > > maxItems: 1 > > @@ -131,28 +134,13 @@ properties: > > - qcom,sm8450-pcie-anoc > > - qcom,sm8450-system-noc > > =20 > > - '#interconnect-cells': > > - enum: [ 1, 2 ] > > - > > - qcom,bcm-voters: > > - $ref: /schemas/types.yaml#/definitions/phandle-array > > - items: > > - maxItems: 1 > > - description: | > > - List of phandles to qcom,bcm-voter nodes that are required by > > - this interconnect to send RPMh commands. > > - > > - qcom,bcm-voter-names: > > - description: | > > - Names for each of the qcom,bcm-voters specified. > > + '#interconnect-cells': true > > =20 > > So this explains why your previous patch had such values... The order is > messed up - first you move common parts to common file, then you add > SM6350 support. Right, that makes much more sense. Will split out qcom,rpmh-common first and use in rpmh.yaml and then afterwards introduce sm6350. Regards Luca > > > Best regards, > Krzysztof