From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD8E8C38A02 for ; Mon, 31 Oct 2022 08:56:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230040AbiJaI4Z (ORCPT ); Mon, 31 Oct 2022 04:56:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230002AbiJaI4Y (ORCPT ); Mon, 31 Oct 2022 04:56:24 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02F0B7665 for ; Mon, 31 Oct 2022 01:56:23 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id a67so16401130edf.12 for ; Mon, 31 Oct 2022 01:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dtvgExSXmepQtdrqHIZul+dYO79vk5qNCOM8KdJOFIQ=; b=KHI6SRPVSMWfZtRUmnZPqGypwl0WZULHv29q2PexONdIeAha8cux/h9jMOoORSNRvI W/QUB2Hf8t3p3C65GXJ6Znt79eC2jWfMcRAH6fkDr/CwR56rKoTEsvmZDnWYeCIjW7gU pP+h+kcIArJ0/1nQrrLU8XDhF4SojMVawO+bDNTnPKhelNpXPqPuWNsExguaP5NgQZm8 zRuSnVuMrN1M2hipiRUtja3MU5mM9D/eHY5qQMOObgoIWrOGjYnuze+fhzr14CEg2bP3 xy13hiZ1HeefGjiqSuDfpFGZckDDDnGNs/z4SaA77K7UHvFU2iWMExwbA7M2e0vOCYas OwMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dtvgExSXmepQtdrqHIZul+dYO79vk5qNCOM8KdJOFIQ=; b=1j3Jvu8kkTOV5DhfmJKZuUDqLoiYfkQoDVsHJTc+/FNCKKtpXNkEliNyvcNt+9YdSS R5kudQ6X7C3BGIbB/0GYqgaGK1Ct7iCzNyKZLohRW4B4arW7FkaReFk9smhWbgZ0qfwZ 4/8w7kRQ503DaPLW/kTob4VBZLFRHASuk2yrAhCmJ0yYp8bI6PH3/GOMXp+jL2b0Cmrw 8d/PbegDX96lzAQ2iGTIcWujyWmCnliHT2PthpZl0DnvuGQ7YrAQE1TyPcsVYEL+bhf0 P/PnANN4mM2YMLNzFZ3lcLsWvHgD+5SyoGUAZqFm9jyNnGCNkW4ShQS2Ae11pqUNJART PReg== X-Gm-Message-State: ACrzQf3HGOr6NC92UI8hDc2jd2wqGeX6joROAMSlLg2sgsB6pk4h5kuq sfQN0inl+lMUlJhXtaZb5XvDBg== X-Google-Smtp-Source: AMsMyM5By2pxB2aLOtKu+C8JgxF+coDN320xPl7ypCiZtXuV+DDTuqhB/n+dZwqullsn+JXr6QkxqA== X-Received: by 2002:aa7:cd12:0:b0:463:69ac:a5d3 with SMTP id b18-20020aa7cd12000000b0046369aca5d3mr2915187edw.269.1667206581548; Mon, 31 Oct 2022 01:56:21 -0700 (PDT) Received: from localhost (31-151-115-246.dynamic.upc.nl. [31.151.115.246]) by smtp.gmail.com with ESMTPSA id bm6-20020a0564020b0600b00461a6997c5dsm2966444edb.83.2022.10.31.01.56.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 01:56:21 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 31 Oct 2022 09:56:20 +0100 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, "AngeloGioacchino Del Regno" , "Konrad Dybcio" , "Martin Botka" , "Jami Kettunen" , "Andy Gross" , "Bjorn Andersson" , "Rob Herring" , "Krzysztof Kozlowski" , "Luca Weiss" , , , Subject: Re: [PATCH 02/10] arm64: dts: qcom: sm6350: Add pinctrl for SDHCI 2 From: "Luca Weiss" To: "Marijn Suijten" , X-Mailer: aerc 0.12.0 References: <20221030073232.22726-1-marijn.suijten@somainline.org> <20221030073232.22726-3-marijn.suijten@somainline.org> In-Reply-To: <20221030073232.22726-3-marijn.suijten@somainline.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun Oct 30, 2022 at 8:32 AM CET, Marijn Suijten wrote: > Use the generic pin functions specifically for sdc2. > > Signed-off-by: Marijn Suijten Reviewed-by: Luca Weiss Tested-by: Luca Weiss # sm7225-fairphone-fp4 Regards Luca > --- > arch/arm64/boot/dts/qcom/sm6350.dtsi | 44 ++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/q= com/sm6350.dtsi > index a3ae765d9781..b98b881ebe7e 100644 > --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi > @@ -1074,6 +1074,10 @@ sdhc_2: mmc@8804000 { > <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_SDCC_2 0>; > interconnect-names =3D "sdhc-ddr", "cpu-sdhc"; > =20 > + pinctrl-0 =3D <&sdc2_on_state>; > + pinctrl-1 =3D <&sdc2_off_state>; > + pinctrl-names =3D "default", "sleep"; > + > qcom,dll-config =3D <0x0007642c>; > qcom,ddr-config =3D <0x80040868>; > power-domains =3D <&rpmhpd SM6350_CX>; > @@ -1316,6 +1320,46 @@ tlmm: pinctrl@f100000 { > #interrupt-cells =3D <2>; > gpio-ranges =3D <&tlmm 0 0 157>; > =20 > + sdc2_off_state: sdc2-off-state { > + clk-pins { > + pins =3D "sdc2_clk"; > + drive-strength =3D <2>; > + bias-disable; > + }; > + > + cmd-pins { > + pins =3D "sdc2_cmd"; > + drive-strength =3D <2>; > + bias-pull-up; > + }; > + > + data-pins { > + pins =3D "sdc2_data"; > + drive-strength =3D <2>; > + bias-pull-up; > + }; > + }; > + > + sdc2_on_state: sdc2-on-state { > + clk-pins { > + pins =3D "sdc2_clk"; > + drive-strength =3D <16>; > + bias-disable; > + }; > + > + cmd-pins { > + pins =3D "sdc2_cmd"; > + drive-strength =3D <10>; > + bias-pull-up; > + }; > + > + data-pins { > + pins =3D "sdc2_data"; > + drive-strength =3D <10>; > + bias-pull-up; > + }; > + }; > + > qup_uart9_default: qup-uart9-default-state { > pins =3D "gpio25", "gpio26"; > function =3D "qup13_f2"; > --=20 > 2.38.1