From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D46C4167B for ; Fri, 25 Nov 2022 09:57:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbiKYJ5o (ORCPT ); Fri, 25 Nov 2022 04:57:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230043AbiKYJ5X (ORCPT ); Fri, 25 Nov 2022 04:57:23 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9AF84876D for ; Fri, 25 Nov 2022 01:55:34 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id z18so5655604edb.9 for ; Fri, 25 Nov 2022 01:55:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5gBtKZ9zx2Pm/QswfVM6U5FT5WCTySCzVA2lRu0vZYg=; b=3JXZ9i2lxLnQM0cikC8NLREGele7lN/5iPmgqRvmomvdJVd3s1P/7UI9EQqxvvYwBE oBJSlQNCRIXmr5I5hxZQR64jdXkpc9MGz811/HU+zsLeqMMJakrZozPCtn5rQnwIA1aV nt0ml934Gk+/97Q0m10njwYQcAI4aJDu37TymEtxLGCuFYDUN2pCG70SELy7KD4fMDve lfXddNnCv7FxahMPjdYDESyYgOS9udT4V/EeNHAuiYdmKOawyu4l+i/BLGFjS6x/XKF3 dWLU0zuE6Z7/yVTjH5sfMuP/y0ODr0gSXWKD9LffW3FHscv/Vs7QqCG+z8EOm6h56Tuu L+Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5gBtKZ9zx2Pm/QswfVM6U5FT5WCTySCzVA2lRu0vZYg=; b=1wG5TnbsIjl/4GP0YnE0vO45dce//24ePm0Bp9w9afZ5FW41ZZwU6fJLZ7TZnICpVX rTAxC+Fo8lyWLXKfme2I42ueiTIPjYin98xoM4kecRm+BqzKbxKRRnj8uYgP2PBrk+LD zv7KF87/7L9+lzasi5nvnakvd6TnY1qOdfnGW40HYAbEL/kdHd4jixUHZKVlgScE8xiO U+9gew4XsOvyfpTlgX0GHIKR3v85d3IsULl96paKlvMem15DogVjnwRGCFXVfaT0tZRb 6JpsRyaJKlUDynlABdtKbNmeyBeoEV8k22pTRJ150aJWAbZcgKElMbtASAEfJ5WiYyo5 bI/g== X-Gm-Message-State: ANoB5pmcnYxYo9uWy3o3IZfmMaUSMfWzYWc89LG5UqOEgHF9xK1la9+B WFmjfgK6SKVJTrmUXKo2yCUm2g== X-Google-Smtp-Source: AA0mqf6hz+jLPZkAJZJ35vx8mMN7LAoU9iZsAgiOtesJBekuIWWL3NO2uwsFi3tIZRuuLGXsc09FIw== X-Received: by 2002:aa7:cc8a:0:b0:464:1296:d5d4 with SMTP id p10-20020aa7cc8a000000b004641296d5d4mr33388969edt.83.1669370133372; Fri, 25 Nov 2022 01:55:33 -0800 (PST) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id c17-20020aa7c991000000b004619f024864sm1568627edt.81.2022.11.25.01.55.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 01:55:32 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 25 Nov 2022 10:55:31 +0100 Message-Id: To: "Johan Hovold" Cc: , <~postmarketos/upstreaming@lists.sr.ht>, , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Vinod Koul" , "Kishon Vijay Abraham I" , "Rob Herring" , "Krzysztof Kozlowski" , , , Subject: Re: [RFC PATCH v2 1/3] dt-bindings: phy: qcom,qmp-usb3-dp: Add sm6350 compatible From: "Luca Weiss" X-Mailer: aerc 0.13.0 References: <20221125092749.46073-1-luca.weiss@fairphone.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Johan, On Fri Nov 25, 2022 at 10:50 AM CET, Johan Hovold wrote: > On Fri, Nov 25, 2022 at 10:27:47AM +0100, Luca Weiss wrote: > > Add the compatible describing the combo phy found on SM6350. > >=20 > > Signed-off-by: Luca Weiss > > --- > > @Johan Hovold, I've sent this v2 as RFC because there are several thing= s > > where I have questions on how it should be done. > >=20 > > In this patch, you can see there's cfg_ahb (&xo_board) and power-domain= s > > is not set. In msm-4.19 &gcc_usb30_prim_gdsc is only used in the > > ssusb@a600000 node, or should I also add it to qmpphy? > > Yeah, you may need to add a platform specific section of the clocks, > which appear to be different, even if I'm not sure they are currently > described correctly (xo_board as cfg_ahb and "QLINK" as ref). How are > they named in the vendor's dts? This is the msm-4.19 dts: https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/a= ndroid-msm-bramble-4.19-android11-qpr1/qcom/lagoon-usb.dtsi#354 > > It should be OK to include the power-domain also for the PHY node. Ack. > > > .../bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-us= b43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-us= b43dp-phy.yaml > > index 6f31693d9868..3e39e3e0504d 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-p= hy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-p= hy.yaml > > @@ -17,16 +17,18 @@ properties: > > compatible: > > enum: > > - qcom,sc8280xp-qmp-usb43dp-phy > > + - qcom,sm6350-qmp-usb3-dp-phy > > =20 > > reg: > > maxItems: 1 > > =20 > > clocks: > > - maxItems: 4 > > + maxItems: 5 > > =20 > > clock-names: > > items: > > - const: aux > > + - const: cfg_ahb > > - const: ref > > - const: com_aux > > - const: usb3_pipe > > So this would need to be moved to an allOf: construct at the end with > one section each for sc8280xp and sm6350. Ack. Thanks for the quick response! Regards, Luca > > > @@ -61,7 +63,6 @@ required: > > - reg > > - clocks > > - clock-names > > - - power-domains > > - resets > > - reset-names > > - vdda-phy-supply > > Johan