From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2DF7C6FD1C for ; Fri, 24 Mar 2023 07:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231513AbjCXH1H (ORCPT ); Fri, 24 Mar 2023 03:27:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231539AbjCXH1C (ORCPT ); Fri, 24 Mar 2023 03:27:02 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE84112BC9 for ; Fri, 24 Mar 2023 00:26:53 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id i5so4463610eda.0 for ; Fri, 24 Mar 2023 00:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1679642812; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=A3r8qlLMfX6olWr5cQiZdjWVdMvEbSYULtWmP0Of5zA=; b=CcWYvg60LPU9OML+C8lhqoRJ4NBCgAsEvPWM1xMIQZrQN0utGwNelBSOWBaYcmTMAP 76O7michXJLPaunJSpjtVfnKkeSF7yEi5oNkMagIISVJOUmQrru3HAiLJ6FuK4uVQHsy Fa7K8lWLDB0csf5yMyjjqbMhCGtNiFc9p1ztVkpiSB2EZEjN1tm7uzaxiVJiG5SfFbMF DYheCDnX4J1FZjZTt8/3VB8vrnisztPXnmDtydR96Zatwyb/V90DIkYKmEDOXzhUMDCh 1u90e88idhl9C+4V/9I12DiWEWe2tHsb68SnP2BGjSPV1uJ1sgngHLtCgDzW5pKsLQYn RvQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679642812; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=A3r8qlLMfX6olWr5cQiZdjWVdMvEbSYULtWmP0Of5zA=; b=tyGNPj4oOnyi/zOJCFyg6ydK2mRv2oMuZ3mzwok1WJ+EYBIgOIzXhiBlwcddt9Li8s AEVnsClCKPsh9Ui7XzKcSQHn0+ONDTbERkeCoaE4D1AWq7+MMz9sEHU2GxMiMnK9YtLY hIsmZDSpkiO3H2YEIbQaUJYl0xk80NuYNO4DZZSv3D0Qdi7YAItQI+T3LHICeSASvpcx Cpjt3CW4IEHptCt8vNJQtl8E/+5JNEZPbUo27KtbdkB+NQ51MFDeKv7bpWojv/+XovDZ jFlbYSTiGR+9uXSms+7oVMKlgcKsBpgz44cHshWzTsbf/IXquGB8q6w6V5m+fabibflU Kdqw== X-Gm-Message-State: AAQBX9fWqyvdEcwAtmcBcVleKCgNLUeuPjumgP0w6l02I0fvE/1gz31g RnnbJ3T+XSjZ009wi66kzsGGbQ== X-Google-Smtp-Source: AKy350Z3iXwVl48Ri6gzNt6zqCcLfdbS5qlgam/8hRq+uoEeXsbjnn/z6Ldk4pJgWmfxDCpq3IpEGA== X-Received: by 2002:aa7:c7d5:0:b0:4fe:cbce:5fcb with SMTP id o21-20020aa7c7d5000000b004fecbce5fcbmr1765296eds.9.1679642812253; Fri, 24 Mar 2023 00:26:52 -0700 (PDT) Received: from localhost (84-115-214-73.cable.dynamic.surfer.at. [84.115.214.73]) by smtp.gmail.com with ESMTPSA id v4-20020a509544000000b004fb402a2a37sm10333082eda.33.2023.03.24.00.26.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 00:26:52 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 24 Mar 2023 08:26:50 +0100 Message-Id: Cc: "Krzysztof Kozlowski" , "Rob Clark" , "Abhinav Kumar" , "Dmitry Baryshkov" , "Sean Paul" , "David Airlie" , "Daniel Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Lee Jones" , "Stephen Boyd" , "Manivannan Sadhasivam" , "Alim Akhtar" , "Avri Altman" , "Bart Van Assche" , , , , , , "Rob Herring" , "Krzysztof Kozlowski" , Subject: Re: [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node From: "Luca Weiss" To: "Eric Biggers" , "Neil Armstrong" X-Mailer: aerc 0.14.0 References: <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-0-3ead1e418fe4@linaro.org> <20230323-topic-sm8450-upstream-dt-bindings-fixes-v1-7-3ead1e418fe4@linaro.org> <9614782e-0d78-e8f2-a438-452cfa86f80b@linaro.org> <316d7d7d-b370-36e1-648a-400447d2dd47@linaro.org> <20230324065247.GA9598@sol.localdomain> In-Reply-To: <20230324065247.GA9598@sol.localdomain> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Eric, On Fri Mar 24, 2023 at 7:52 AM CET, Eric Biggers wrote: > Hi Neil, > > On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote: > > Hi, > >=20 > > On 23/03/2023 11:49, Krzysztof Kozlowski wrote: > > > On 23/03/2023 11:25, Neil Armstrong wrote: > > > > Fixes the following DT bindings check error: > > > > ufshc@1d84000: Unevaluated properties are not allowed ('reg-names' = was unexpected) > > > >=20 > > > > Signed-off-by: Neil Armstrong > > > > --- > > > > arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 - > > > > 1 file changed, 1 deletion(-) > > > >=20 > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot= /dts/qcom/sm8450.dtsi > > > > index ef9bae2e6acc..8ecc48c7c5ef 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > > > > @@ -3996,7 +3996,6 @@ ufs_mem_hc: ufshc@1d84000 { > > > > "jedec,ufs-2.0"; > > > > reg =3D <0 0x01d84000 0 0x3000>, > > > > <0 0x01d88000 0 0x8000>; > > > > - reg-names =3D "std", "ice"; > > >=20 > > > This is also part of: > > > https://lore.kernel.org/linux-arm-msm/20230308155838.1094920-8-abel.v= esa@linaro.org/#Z31arch:arm64:boot:dts:qcom:sm8450.dtsi > > > but I actually wonder whether you just missed some binding patch? > >=20 > > I'm aware of Abel's RFC patchset to support shared ICE, but this is a c= leanup of the current DT, > > and the current bindings schema doesn't document reg-names. > >=20 > > The ufs-qcom driver accesses the "ice" registers by name, so the reg-name= s can't > be removed from the device tree. A few months ago there was a patch to f= ix the > device tree schema for qcom,ufs to include the reg-names. It looks like = that > patch got missed, though: > https://lore.kernel.org/r/20221209-dt-binding-ufs-v2-2-dc7a04699579@fairp= hone.com Are you implying that I should resend the patch or something? Not sure who to bug about applying this patch. Regards Luca > > - Eric