From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45AC0C76196 for ; Fri, 7 Apr 2023 08:30:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240118AbjDGIaE (ORCPT ); Fri, 7 Apr 2023 04:30:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240224AbjDGI34 (ORCPT ); Fri, 7 Apr 2023 04:29:56 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7368CAD1F for ; Fri, 7 Apr 2023 01:29:54 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-4fa3c1a7a5aso1594817a12.3 for ; Fri, 07 Apr 2023 01:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1680856192; x=1683448192; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PvSp8cyUMKF1qGGbTf6r73kHmwUDhMZeDkSVRdnk+rE=; b=VrucHk7wS6BiVDQa+WFMoMuYB1xPFCpQGkLCRD8CwMigTZGjXRCWnumnH9kup9Dyt3 lHBW+C2gPIbTq7cP8xw7igW+8VPR76Raswd6ju2wgLYoz+eB75cJTY0ZpKifMq5JnAOW 4nUMJKUePLD6G07ymo6M98U9Ka9yNe/Qtg0Qj84CnG02npwWbIpS4IUGsdlWf7HDMQL4 anVpCbg2HEUXWuNb0tInBFf8Q1fV9izkrZQCvdzv0VEzQTNjc6oiMzCH85QsuMf0IssI lz+RZAv4fHYACu109xSXkGREq2wuvTGwdd+FeFpowpzKZUynjxAwup4Z/6vJe3BedBdK YOzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680856192; x=1683448192; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PvSp8cyUMKF1qGGbTf6r73kHmwUDhMZeDkSVRdnk+rE=; b=MPw8cZpXxOPzqjJ0vql7iB/5pzs86Y3xHv9IWCvORiBLk417EMHjJpMcjmMuBmZV5Z 0FS4exjBODl2Oxrwv7aPfWukYEYIo/FpPnj944e7AgRMvDcG2an2tT975SbnoPDYErOG pvlQPyX0oV4CP2oLB89YAGmuenjFO3sKBr2EQSS0OlMcupwPaLsPPF8Vhp1ePEHJzJDA hMEJSZaC77EqsNRKN5TfUrk+TKgXsTFk4aveyOnJ1MV2eivoHu5XNy4GNQwPaJ8LPlwB zagjq4pvPuqNdqo/Ds4upyy1d3nHXKEJWNByZKlq8rF6soV1lWbjX95evsKC1Od+Tiu5 RSnA== X-Gm-Message-State: AAQBX9cXnfHurnPf3B8oBZkb9WFh2tyfETgUufaKug7uMfUx9pgzC5ag VehlAwsZn25P2wwMjYwuteTBqA== X-Google-Smtp-Source: AKy350YbzKn/NC11aBG+Xn9E0morVBRWLIhxGyn63lK7zWZ+2D41nf5O5n31b+alJOBfm+dqxm6DzA== X-Received: by 2002:aa7:d358:0:b0:4f9:f07d:a978 with SMTP id m24-20020aa7d358000000b004f9f07da978mr1931174edr.5.1680856192590; Fri, 07 Apr 2023 01:29:52 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a24-20020aa7cf18000000b005023aaf52desm1587496edy.95.2023.04.07.01.29.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Apr 2023 01:29:52 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 07 Apr 2023 10:29:52 +0200 Message-Id: Cc: <~postmarketos/upstreaming@lists.sr.ht>, , , , Subject: Re: [PATCH 2/2] arm64: dts: qcom: pm7250b: make SID configurable From: "Luca Weiss" To: "Krzysztof Kozlowski" , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Konrad Dybcio" X-Mailer: aerc 0.14.0 References: <20230407-pm7250b-sid-v1-0-fc648478cc25@fairphone.com> <20230407-pm7250b-sid-v1-2-fc648478cc25@fairphone.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri Apr 7, 2023 at 10:27 AM CEST, Krzysztof Kozlowski wrote: > On 07/04/2023 09:45, Luca Weiss wrote: > > Like other Qualcomm PMICs the PM7250B can be used on different addresse= s > > on the SPMI bus. Use similar defines like the PMK8350 to make this > > possible. > >=20 > > Signed-off-by: Luca Weiss > > --- > > arch/arm64/boot/dts/qcom/pm7250b.dtsi | 23 ++++++++++++++++------- > > 1 file changed, 16 insertions(+), 7 deletions(-) > >=20 > > diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dt= s/qcom/pm7250b.dtsi > > index daa6f1d30efa..eeb476edc79a 100644 > > --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi > > +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi > > @@ -7,6 +7,15 @@ > > #include > > #include > > =20 > > +/* This PMIC can be configured to be at different SIDs */ > > +#ifndef PM7250B_SID > > + #define PM7250B_SID 2 > > Drop indentation, although anyway I am against this. Please don't bring > new patterns of this at least till we settle previous discussion. > > https://lore.kernel.org/linux-arm-msm/46658cbb-fff5-e98b-fdad-88fa683a9c7= 5@linaro.org/ Ok I'll wait for that to conclude then. Let's only consider patch 1/2 from this series then for now. Regards Luca > > > Best regards, > Krzysztof