From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF3DC77B73 for ; Fri, 14 Apr 2023 06:51:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229457AbjDNGvQ (ORCPT ); Fri, 14 Apr 2023 02:51:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjDNGvP (ORCPT ); Fri, 14 Apr 2023 02:51:15 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68BDC110 for ; Thu, 13 Apr 2023 23:51:06 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id z9so16167722ejx.11 for ; Thu, 13 Apr 2023 23:51:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1681455065; x=1684047065; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K+WN6T+Knm9we3h7NoryAk78kn2YJjd6ujXcjaUDzw0=; b=jsUU0UDsPlabryanLeKGvQftkQ6FvmoVprW1ZfF7bTrH0iq44Z0Nd3vmNlBuSZ3w7r orRE96ryBrOl1ezXihnOva23zCSYV7F9j0gKhB/zBJlxoHbH4D1rD4B6oUiZ6dqHOtA0 030uk+9atlZ7Kti1uSzfJE+vxI5VwSmXxjm/wGMy/YRfKzD90G/pKAqXMynVxG+KHk3G MePXADzCjt3UdtdITQGgNzc+uP0gw+r4zqu/EKQNgMhlJLXTK+4gLwgCASNqgfn6r2Hu pOaZfMGtuMP7dSisH0mlAvFiqNJsCvrN6WMBib1ITKxd3cqaNB0nqBaoyrfhE+sJegY/ QGxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681455065; x=1684047065; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=K+WN6T+Knm9we3h7NoryAk78kn2YJjd6ujXcjaUDzw0=; b=TsJBz+wufm9zIhnjsqQYQS/Wgm3Rims7k3qN8luHM4+K6p2Y6/CegUDEFAPV2ypbFN r4G3DlUZG/KN3CoHBHfBgyYnlKZVdsWTPCtSBY5BNrWkPblSiaLWBMeP41UU6i9xfU0Y IuhuNcO6p7ZWpH/FmXn7SzlDFH+hrRP1xdeYKqDbn34sF4Su9IEv+1ZgZZeXhcKltToi FwOXm4o6lu+iu3Eq45xLku3i1iKqLW3mkKfxr6uCGNG78DmyQHLBLdrGSlHD4K+EbbxA YQ0PL+trXcFsj4oH0l7gezU3tL/55MrEo0qii2co9vKJh0aI1ERSZjoZido4q3mggvpF zCmQ== X-Gm-Message-State: AAQBX9daSpXQRozTYI1tdbTFSyU4iz+7qG0EdHJMHzBiu3RybpoGGlSl Chpq0yTI0rxLTPgOBZhECGluBw== X-Google-Smtp-Source: AKy350agxzMApL1j52BabZywTTq67yJeqEy9cBCgbsi9iCU+RuSdiaPSo6d4BN//1w6aAifK8lRY5Q== X-Received: by 2002:a17:906:1b01:b0:94e:edf3:dccd with SMTP id o1-20020a1709061b0100b0094eedf3dccdmr434902ejg.0.1681455064867; Thu, 13 Apr 2023 23:51:04 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id s5-20020a170906168500b0094d69608f5fsm1991552ejd.97.2023.04.13.23.51.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 23:51:04 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 14 Apr 2023 08:51:04 +0200 Message-Id: From: "Luca Weiss" To: "Bryan O'Donoghue" , , , , , , , , , Cc: , , , , Subject: Re: [PATCH v5 00/14] Add Qualcomm PMIC TPCM support X-Mailer: aerc 0.14.0 References: <20230413113438.1577658-1-bryan.odonoghue@linaro.org> <10551f5e-4516-c0cc-0b04-73aa38f80a2c@linaro.org> In-Reply-To: <10551f5e-4516-c0cc-0b04-73aa38f80a2c@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu Apr 13, 2023 at 5:08 PM CEST, Bryan O'Donoghue wrote: > On 13/04/2023 15:19, Luca Weiss wrote: > > Hi Bryan, > >=20 > > On Thu Apr 13, 2023 at 1:34 PM CEST, Bryan O'Donoghue wrote: > >> V5: > >> - Amagamates into once device, Heikki, Rob > >> > >> - Takes feedback on usage form Luka and Jianhua on VSafeV state transi= tion detection > >> dev_err() -> dev_warn() > >> > >> - Orientation graph example and general expected bindings > >> I discussed offline with Bjorn the conclusions of the glink/sbu mod= el. > >> The expected orientation-switch path is > >> connector/port@0 <-> phy/port@X <-> dp/port@0 > >> This can then be expanded to > >> connector/port@0 <-> redriver/port@0 <-> phy/port@X <-> dp/port@= 0 > >> > >> - Rob, Bjorn, Krzysztof > >> > >> - Data role > >> The data-role path is > >> connector/port@0 <-> dwc3/port@Y > >=20 > > I believe I have adjusted my dts correctly for v5 compared to v4 but no= w > > the usb doesn't seem to work anymore in most cases. > >=20 > > Only when having the phone already plugged in during boot in one > > orientation does USB come up, but also disappears once you replug the > > cable. I still see the same (or at least visually similar) messages whe= n > > plugging in the USB cable or the USB stick but nothing more than that > > happens. > >=20 > > Not that v4 worked perfectly on pm7250b+sm7225(/sm6350) but at least it > > worked in most cases as described in the emails there. Since the driver > > structure changed quite a bit, git diff isn't helpful here > > unfortunately. > >=20 > > Don't think it matters but worth mentioning that sm6350 uses the new > > qmpphy bindings as described in qcom,sc8280xp-qmp-usb43dp-phy.yaml (thi= s > > was also the case when testing v4 of this). > >=20 > > Any idea? > > Can you confirm the output of /sys/class/typec/port0/orientation in host= =20 > mode with the USB key / peripheral in both orientations ? I see "reverse" and "normal" depending on the direction the USB stick is plugged in. When unplugged but also when plugged into my PC it stays at "unknown". > > If that's still OK, then perhaps we can figure out the gap in the PHY=20 > code for v3 > > @caleb is working on this code for sdm845 which is a v3 PHY Regards Luca > > --- > bod