From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4194C77B7C for ; Wed, 10 May 2023 11:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236703AbjEJL1v (ORCPT ); Wed, 10 May 2023 07:27:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236451AbjEJL1u (ORCPT ); Wed, 10 May 2023 07:27:50 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0B081B7 for ; Wed, 10 May 2023 04:27:26 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-50bd2d7ba74so67852712a12.1 for ; Wed, 10 May 2023 04:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1683718045; x=1686310045; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pNpH9churWtVNXY067utTn5iZTHhfSH7PNSyN7PmDpo=; b=5F5GRep5g811KAguGtS93rVSUgRHqVtSaY9ywuzMtfzQAQFzM9O2V1CdiwqK5/APC8 X5erFFpavgIcTEc8AYANnTCtLQCx+RngQ8uRvC1pIOAfb4cxK79NgyN8eT9tiyhRtkQv GTDz+CKk86o3oGNNgNAoO7vsVMS45C7TPYG/KMcTKNSDewe5SW6DOLXWDvUSaYFkAmYg N4Kp5nVhEfMYz3svQsnxGNAK4k/0PXLqiG1tHhKig7elBHB63DkRzPxP0xY+d8pX5bM3 QtvvrAZx8VjUTVo5CgJIQUuf+6gqBwFMOVILvfJLUK7ZwwxE/VW9KMTCssntb4HeWeMv Ehdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683718045; x=1686310045; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pNpH9churWtVNXY067utTn5iZTHhfSH7PNSyN7PmDpo=; b=fwgJGfh66g/6WlkJpID1e1ioZrGR2XoLsXO8wbBDuFyqcWg87Cj4bcrYDyuMUy24/8 XtZ2BXeQxrchg5FWbqjpx/T3vyzFvr+H0U5RsiTICClDJ/WmgDU8yayetLaKUZYj6xGM VwJwbyDO0czT4M5/duw9nZInTQ5Di+5GB3EjTYnybEl4BzQnbE8uQSO0CEqdxSUvdcbq o5BRLjwcmOP0FWLwWkLzyCQRSc+GmzIb1OrQt/PuPtv7PFPLTDbCilKkVgePeRq/IdPz 9T89J2+jJmeeuyTw8yVB7qgsssbdfnxYReTFlauf0cZmSk8ibImTGvZvi+V7YBHfV4Vf l/yA== X-Gm-Message-State: AC+VfDxffHmq/mJHpRaOUmIYs8NrZ1H9Pzzy+CxqZ8d+m9EZq/ViQrzk HFuVIkGCjtRdo1co5JXdz+UMGw== X-Google-Smtp-Source: ACHHUZ7tjOsW38XJxLzNaQXTcPGIml/eKQLTk5/qbm/AqQLokna1fWit8n+3+Gk2VUDLtghCyBe2Sg== X-Received: by 2002:a05:6402:27d2:b0:506:71bd:3931 with SMTP id c18-20020a05640227d200b0050671bd3931mr16236880ede.2.1683718045201; Wed, 10 May 2023 04:27:25 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id bc15-20020a056402204f00b0050b2f588db6sm1742156edb.16.2023.05.10.04.27.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 04:27:24 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 10 May 2023 13:27:23 +0200 Message-Id: Subject: Re: [PATCH 2/2] arm64: dts: qcom: pm7250b: make SID configurable From: "Luca Weiss" To: "Krzysztof Kozlowski" , "Dmitry Baryshkov" Cc: "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Konrad Dybcio" , <~postmarketos/upstreaming@lists.sr.ht>, , , , X-Mailer: aerc 0.15.1 References: <20230407-pm7250b-sid-v1-0-fc648478cc25@fairphone.com> <20230407-pm7250b-sid-v1-2-fc648478cc25@fairphone.com> <9040e9bb-a16c-0186-edba-da986350340c@linaro.org> In-Reply-To: <9040e9bb-a16c-0186-edba-da986350340c@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed May 10, 2023 at 12:05 PM CEST, Krzysztof Kozlowski wrote: > On 10/05/2023 10:34, Luca Weiss wrote: > > On Wed May 10, 2023 at 10:07 AM CEST, Dmitry Baryshkov wrote: > >> On Wed, 10 May 2023 at 09:55, Krzysztof Kozlowski > >> wrote: > >>> > >>> On 10/05/2023 08:47, Luca Weiss wrote: > >>>> Hi Krzysztof, > >>>> > >>>> On Fri Apr 7, 2023 at 10:27 AM CEST, Krzysztof Kozlowski wrote: > >>>>> On 07/04/2023 09:45, Luca Weiss wrote: > >>>>>> Like other Qualcomm PMICs the PM7250B can be used on different add= resses > >>>>>> on the SPMI bus. Use similar defines like the PMK8350 to make this > >>>>>> possible. > >>>>>> > >>>>>> Signed-off-by: Luca Weiss > >>>>>> --- > >>>>>> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 23 ++++++++++++++++------= - > >>>>>> 1 file changed, 16 insertions(+), 7 deletions(-) > >>>>>> > >>>>>> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/bo= ot/dts/qcom/pm7250b.dtsi > >>>>>> index daa6f1d30efa..eeb476edc79a 100644 > >>>>>> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi > >>>>>> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi > >>>>>> @@ -7,6 +7,15 @@ > >>>>>> #include > >>>>>> #include > >>>>>> > >>>>>> +/* This PMIC can be configured to be at different SIDs */ > >>>>>> +#ifndef PM7250B_SID > >>>>>> + #define PM7250B_SID 2 > >>>>> > >>>>> Drop indentation, although anyway I am against this. Please don't b= ring > >>>>> new patterns of this at least till we settle previous discussion. > >>>>> > >>>>> https://lore.kernel.org/linux-arm-msm/46658cbb-fff5-e98b-fdad-88fa6= 83a9c75@linaro.org/ > >>>> > >>>> What's the outcome of the discussion? For this PMIC it's totally eno= ugh > >>>> to have the SID configurable like in this patch, I don't think this = PMIC > >>>> will be included twice in a board - at least I'm not aware of such a > >>>> configuration. > >>> > >>> We did not reach consensus and I still disagree with complex macros o= r > >>> macros depending on order of inclusion. > >> > >> I still think we should find a way to parametrise PMIC dtsi, however I > >> agree with Krzysztof that complex CPP is not a way to go. > >=20 > > What about the macro already used in-tree and proposed with this patch? > > I wouldn't say this is a "complex macro" since it's just a single numbe= r > > being replaced in a few places. > > Are you talking about the macro to which I responded: "or macros > depending on order of inclusion." or something else? I thought you mean with .. > >>> We did not reach consensus and I still disagree with complex macros o= r > >>> macros depending on order of inclusion. .. the macros proprosed in the patch you linked (that version that also adjusts the labels based on the SID). I was asking if the patch I sent (with #define PM7250B_SID) would be okay to take in at least until the bigger discussion has come to a conclusion, since we already have upstream occurances of such a macro so it's not a new concept. Otherwise I'll just carry this patch in my local tree until this situation has cleared up. Regards Luca > > Best regards, > Krzysztof