From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98672C2FC1A for ; Thu, 17 Aug 2023 07:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348566AbjHQHlW (ORCPT ); Thu, 17 Aug 2023 03:41:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348607AbjHQHlH (ORCPT ); Thu, 17 Aug 2023 03:41:07 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 993FE2D76 for ; Thu, 17 Aug 2023 00:40:59 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-523476e868dso9544791a12.3 for ; Thu, 17 Aug 2023 00:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1692258058; x=1692862858; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GQ/pzkMGOFMvffvVhYx2x+xo33IWshzsEC8qLYrj/uQ=; b=d1cQ/BjPg1yi2uUWuTc22jq1iHRqEP/NNmdkiQe2gkvtRNhiKrbQjjtDTix+BAo/Nf 0q8pfiyLBmoiJvUYU+yDZl4hHLzE9AjCXUjw9wQlFA7UNsM32fgyC5fD5sfCzfRBYBU1 jbxT0YecM2HmMSveJ0g6VJHbFTlQk7hTDSqSSWmzdkFVq3UwWwMn9F2SfYFV8lCd3AXo 2RjJhJhbAN2Cy1yWt3BaFa8R/sKPCTW88uwB0OjWwy0S06ThftBaSACRBa2AoOxFjxFe doH2pYc2XmqjF54ebQobUTlD8ikmFYKEQddtpcfYpqOWexqx31958FzUL3A6W5zLXpdT kpdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692258058; x=1692862858; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GQ/pzkMGOFMvffvVhYx2x+xo33IWshzsEC8qLYrj/uQ=; b=Ljzyy1Q7lRHwcvKq1ol3FkQ19tVwbKO2Zd47/qVHUMl8KpYFWt5K2y88kLOzr6LftV oiUZ7SNaOdX9YYPY5fjs00Ce1l9h2CCv+sH5z3CdbvSNqY3qIUdoAc4jKE2kWP53nx/6 rfE3FDSIYJmoEScEKlfsmAbY7OrbKqUt/sPFZYRwvbGglFOmoIRZq89Mk5X80yV0lkUA 241RhPGPGiQwKq5gqtGeJsKF2tYTpjdsa1sU07peZma6zHJ16i5iUSZ8u4W2JJWjF35v P+AKYxcNyQxCDu224nM64qgjh3xZarq349eUCz6nbt7okyJ1rd/rKdiHjrdZijIutczo s8Jw== X-Gm-Message-State: AOJu0YwaXB8XgjfR94W65Rk84znLfViNFdDHFom+i2Dy32QLkQE9wIyu ZoSWLLWPSDhMrnPKX4eqbRgrZQ== X-Google-Smtp-Source: AGHT+IGf9rWZ9VohbsbOL72pJ0kHw3/hOLYWbEHXA0pN2GPS58vPMofCBOyp5A4Rss2bcsZNA/p6YQ== X-Received: by 2002:aa7:d6d8:0:b0:526:9cfb:c12 with SMTP id x24-20020aa7d6d8000000b005269cfb0c12mr978979edr.38.1692258057999; Thu, 17 Aug 2023 00:40:57 -0700 (PDT) Received: from localhost (212095005038.public.telering.at. [212.95.5.38]) by smtp.gmail.com with ESMTPSA id d13-20020a05640208cd00b005259dd903e5sm1235721edz.67.2023.08.17.00.40.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Aug 2023 00:40:57 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 17 Aug 2023 09:40:56 +0200 Message-Id: Cc: "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Rob Herring" , "Krzysztof Kozlowski" , "Konrad Dybcio" , <~postmarketos/upstreaming@lists.sr.ht>, , , , Subject: Re: [PATCH 2/2] arm64: dts: qcom: pm7250b: make SID configurable From: "Luca Weiss" To: "Luca Weiss" , "Krzysztof Kozlowski" , "Dmitry Baryshkov" X-Mailer: aerc 0.15.2 References: <20230407-pm7250b-sid-v1-0-fc648478cc25@fairphone.com> <20230407-pm7250b-sid-v1-2-fc648478cc25@fairphone.com> <9040e9bb-a16c-0186-edba-da986350340c@linaro.org> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On Wed May 10, 2023 at 1:27 PM CEST, Luca Weiss wrote: > On Wed May 10, 2023 at 12:05 PM CEST, Krzysztof Kozlowski wrote: > > On 10/05/2023 10:34, Luca Weiss wrote: > > > On Wed May 10, 2023 at 10:07 AM CEST, Dmitry Baryshkov wrote: > > >> On Wed, 10 May 2023 at 09:55, Krzysztof Kozlowski > > >> wrote: > > >>> > > >>> On 10/05/2023 08:47, Luca Weiss wrote: > > >>>> Hi Krzysztof, > > >>>> > > >>>> On Fri Apr 7, 2023 at 10:27 AM CEST, Krzysztof Kozlowski wrote: > > >>>>> On 07/04/2023 09:45, Luca Weiss wrote: > > >>>>>> Like other Qualcomm PMICs the PM7250B can be used on different a= ddresses > > >>>>>> on the SPMI bus. Use similar defines like the PMK8350 to make th= is > > >>>>>> possible. > > >>>>>> > > >>>>>> Signed-off-by: Luca Weiss > > >>>>>> --- > > >>>>>> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 23 ++++++++++++++++----= --- > > >>>>>> 1 file changed, 16 insertions(+), 7 deletions(-) > > >>>>>> > > >>>>>> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/= boot/dts/qcom/pm7250b.dtsi > > >>>>>> index daa6f1d30efa..eeb476edc79a 100644 > > >>>>>> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi > > >>>>>> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi > > >>>>>> @@ -7,6 +7,15 @@ > > >>>>>> #include > > >>>>>> #include > > >>>>>> > > >>>>>> +/* This PMIC can be configured to be at different SIDs */ > > >>>>>> +#ifndef PM7250B_SID > > >>>>>> + #define PM7250B_SID 2 > > >>>>> > > >>>>> Drop indentation, although anyway I am against this. Please don't= bring > > >>>>> new patterns of this at least till we settle previous discussion. > > >>>>> > > >>>>> https://lore.kernel.org/linux-arm-msm/46658cbb-fff5-e98b-fdad-88f= a683a9c75@linaro.org/ > > >>>> > > >>>> What's the outcome of the discussion? For this PMIC it's totally e= nough > > >>>> to have the SID configurable like in this patch, I don't think thi= s PMIC > > >>>> will be included twice in a board - at least I'm not aware of such= a > > >>>> configuration. > > >>> > > >>> We did not reach consensus and I still disagree with complex macros= or > > >>> macros depending on order of inclusion. > > >> > > >> I still think we should find a way to parametrise PMIC dtsi, however= I > > >> agree with Krzysztof that complex CPP is not a way to go. > > >=20 > > > What about the macro already used in-tree and proposed with this patc= h? > > > I wouldn't say this is a "complex macro" since it's just a single num= ber > > > being replaced in a few places. > > > > Are you talking about the macro to which I responded: "or macros > > depending on order of inclusion." or something else? > > I thought you mean with .. > > > >>> We did not reach consensus and I still disagree with complex macros= or > > >>> macros depending on order of inclusion. > > .. the macros proprosed in the patch you linked (that version that also > adjusts the labels based on the SID). > > I was asking if the patch I sent (with #define PM7250B_SID) would be > okay to take in at least until the bigger discussion has come to a > conclusion, since we already have upstream occurances of such a macro so > it's not a new concept. > > Otherwise I'll just carry this patch in my local tree until this > situation has cleared up. Has any decision been made in the meantime whether we can get this patch in (at least until we have a better solution)? Imo since this patch isn't introducing any new concept that isn't already present upstream so shouldn't be a big problem.. Regards Luca > > Regards > Luca > > > > > Best regards, > > Krzysztof