From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B7B228E26; Thu, 4 Jan 2024 19:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QfrASDE/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 299E1C433C8; Thu, 4 Jan 2024 19:11:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704395480; bh=hmyXJGBa6CJ3l6+tT+VXs6Dzw1dvtFM58ZFtQxmIAtw=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=QfrASDE/1z+tIyQGWIt9ixsfbObEKAiesCHjiygZW3T1YaccVr01Wvw2WlrNI3ryj LOFFvrVN6siyw8StdW2qzbLPIqnsrPRQbmF67mvcfwiRdTF7dcDWdH8mI5I9FWqVcy 296N7tusnyXVDaCxOLMGfCUuzf1vDSeMdhFP1wu8+ySCANDoOMbMfVLjO7R/uCeJ6e jA+zwhzAt6lx9ys1YXm2G3+pKECsj+H59DoJf0km4cZuPfOIOggQGdEB6iuMOnXBdZ /W3IgfL5MwyaaaTgL4EeI+if3ESW/yl54JEuI8i6HKtXM2KEhVlJ49y+OS/haNUcQN 9huJ9KvqW2A7g== Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 04 Jan 2024 21:11:16 +0200 Message-Id: Cc: , Subject: Re: [PATCH] dt-bindings: tpm: Add compatible string atmel,attpm20p From: "Jarkko Sakkinen" To: "Jarkko Sakkinen" , "Lukas Wunner" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Peter Huewe" , "Jason Gunthorpe" , "Tim Harvey" X-Mailer: aerc 0.15.2 References: In-Reply-To: On Thu Jan 4, 2024 at 8:46 PM EET, Jarkko Sakkinen wrote: > On Thu Jan 4, 2024 at 6:50 PM EET, Jarkko Sakkinen wrote: > > On Tue Jan 3, 2023 at 5:51 PM EET, Lukas Wunner wrote: > > > Commit 4f2a348aa365 ("arm64: dts: imx8mm-venice-gw73xx: add TPM devic= e") > > > added a devicetree node for the Trusted Platform Module on certain > > > Gateworks boards. > > > > > > The commit only used the generic "tcg,tpm_tis-spi" compatible string, > > > but public documentation shows that the chip is an ATTPM20P from Atme= l > > > (nowadays Microchip): > > > https://trac.gateworks.com/wiki/tpm > > > > > > Add the chip to the supported compatible strings of the TPM TIS SPI > > > schema. > > > > > > For reference, a datasheet is available at: > > > https://ww1.microchip.com/downloads/en/DeviceDoc/ATTPM20P-Trusted-Pla= tform-Module-TPM-2.0-SPI-Interface-Summary-Data-Sheet-DS40002082A.pdf > > > > > > Signed-off-by: Lukas Wunner > > > Cc: Tim Harvey > > > --- > > > This patch depends on the following series to consolidate TCG TIS bin= dings: > > > https://lore.kernel.org/all/cover.1702806810.git.lukas@wunner.de/ > > > > > > Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.ya= ml b/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml > > > index c3413b4..6cb2de7 100644 > > > --- a/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml > > > +++ b/Documentation/devicetree/bindings/tpm/tcg,tpm_tis-spi.yaml > > > @@ -20,6 +20,7 @@ properties: > > > compatible: > > > items: > > > - enum: > > > + - atmel,attpm20p > > > - infineon,slb9670 > > > - st,st33htpm-spi > > > - st,st33zp24-spi > > > > Acked-by: Jarkko Sakkinen > > meant: > > Reviewed-by: Jarkko Sakkinen > > I can pick this if no objections. I have issues with ancestor commits. The most convenient for me would be probably, if you could send a v2 patch set with both patches and my tags, and then I can take that to my tree and include it to the next PR. BR, Jarkko