devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Lukas Wunner" <lukas@wunner.de>
Cc: <devicetree@vger.kernel.org>, <linux-integrity@vger.kernel.org>,
	"Peter Huewe" <peterhuewe@gmx.de>,
	"Jason Gunthorpe" <jgg@ziepe.ca>
Subject: Re: [PATCH v2 3/4] tpm_tis: Add compatible string atmel,at97sc3204
Date: Sat, 13 Jan 2024 23:54:57 +0200	[thread overview]
Message-ID: <CYDWW0Z5CLLS.1XM7MBDWPLR39@kernel.org> (raw)
In-Reply-To: <805eb0868e047bde452144a51e48ce1bc2cac45b.1705140898.git.lukas@wunner.de>

On Sat Jan 13, 2024 at 7:10 PM EET, Lukas Wunner wrote:
> Commit 420d439849ca ("tpm_tis: Allow tpm_tis to be bound using DT")
> added the fallback compatible "tcg,tpm-tis-mmio" to the TPM TIS driver,
> but not the chip-specific "atmel,at97sc3204".  However it did document
> it as a valid compatible string.
>
> Add it to tis_of_platform_match[] for consistency.
>
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> ---
>  drivers/char/tpm/tpm_tis.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 2c52b79..14652aa 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -347,6 +347,7 @@ static void tpm_tis_plat_remove(struct platform_device *pdev)
>  
>  #ifdef CONFIG_OF
>  static const struct of_device_id tis_of_platform_match[] = {
> +	{.compatible = "atmel,at97sc3204"},
>  	{.compatible = "tcg,tpm-tis-mmio"},
>  	{},
>  };

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko

  reply	other threads:[~2024-01-13 21:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-13 17:10 [PATCH v2 0/4] Add missing TPM compatible strings Lukas Wunner
2024-01-13 17:10 ` [PATCH v2 1/4] dt-bindings: tpm: Add compatible string atmel,attpm20p Lukas Wunner
2024-01-13 21:17   ` Jarkko Sakkinen
2024-01-16 18:37     ` Rob Herring
2024-01-16 18:37   ` Rob Herring
2024-01-13 17:10 ` [PATCH v2 2/4] tpm_tis_spi: " Lukas Wunner
2024-01-13 17:10 ` [PATCH v2 3/4] tpm_tis: Add compatible string atmel,at97sc3204 Lukas Wunner
2024-01-13 21:54   ` Jarkko Sakkinen [this message]
2024-01-13 17:10 ` [PATCH v2 4/4] tpm: tis_i2c: Add compatible string nuvoton,npct75x Lukas Wunner
2024-01-13 21:55   ` Jarkko Sakkinen
2024-02-20 10:55 ` [PATCH v2 0/4] Add missing TPM compatible strings Lukas Wunner
2024-02-20 18:06   ` Jarkko Sakkinen
2024-02-20 18:09     ` Jarkko Sakkinen
2024-02-20 18:12       ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CYDWW0Z5CLLS.1XM7MBDWPLR39@kernel.org \
    --to=jarkko@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).