* [PATCH v3 04/24] dt-bindings: power: Clarify wording for wakeup-source property
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 05/24] ARM: dts: tegra: Enable cros-ec-spi as wake source Mark Hasemeyer
` (18 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Conor Dooley, Krzysztof Kozlowski,
Rob Herring, devicetree
The wording in the current documentation is a little strong. The
intention was not to fix any particular interrupt as wakeup capable but
leave those details to the device. It wasn't intended to enforce any
rules as what can be or can't be a wakeup interrupt.
Soften the wording to not mandate that the 'wakeup-source' property be
used, and clarify what it means when an interrupt is marked (or not
marked) for wakeup.
Link: https://lore.kernel.org/all/ZYAjxxHcCOgDVMTQ@bogus/
Link: https://lore.kernel.org/all/CAL_Jsq+MYwOG40X26cYmO9EkZ9xqWrXDi03MaRfxnV-+VGkXWQ@mail.gmail.com/
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
Changes in v3:
-Update commit title prefixes
Changes in v2:
-New patch
.../bindings/power/wakeup-source.txt | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/wakeup-source.txt b/Documentation/devicetree/bindings/power/wakeup-source.txt
index 697333a56d5e2..75bc20b95688f 100644
--- a/Documentation/devicetree/bindings/power/wakeup-source.txt
+++ b/Documentation/devicetree/bindings/power/wakeup-source.txt
@@ -3,16 +3,20 @@ Specifying wakeup capability for devices
Any device nodes
----------------
-Nodes that describe devices which has wakeup capability must contain an
+Nodes that describe devices which have wakeup capability may contain a
"wakeup-source" boolean property.
-Also, if device is marked as a wakeup source, then all the primary
-interrupt(s) can be used as wakeup interrupt(s).
+If the device is marked as a wakeup-source, interrupt wake capability depends
+on the device specific "interrupt-names" property. If no interrupts are labeled
+as wake capable, then it is up to the device to determine which interrupts can
+wake the system.
-However if the devices have dedicated interrupt as the wakeup source
-then they need to specify/identify the same using device specific
-interrupt name. In such cases only that interrupt can be used as wakeup
-interrupt.
+However if a device has a dedicated interrupt as the wakeup source, then it
+needs to specify/identify it using a device specific interrupt name. In such
+cases only that interrupt can be used as a wakeup interrupt.
+
+While various legacy interrupt names exist, new devices should use "wakeup" as
+the canonical interrupt name.
List of legacy properties and respective binding document
---------------------------------------------------------
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 05/24] ARM: dts: tegra: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 04/24] dt-bindings: power: Clarify wording for wakeup-source property Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 06/24] ARM: dts: rockchip: rk3288: " Mark Hasemeyer
` (17 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Alexandre TORGUE, Andre Przywara,
Conor Dooley, Enric Balletbo i Serra, Jonathan Hunter,
Krzysztof Kozlowski, Manivannan Sadhasivam, Michal Simek,
Nick Hawkins, Rob Herring, Thierry Reding, Tony Lindgren,
devicetree, linux-tegra
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm/boot/dts/nvidia/tegra124-nyan.dtsi | 1 +
arch/arm/boot/dts/nvidia/tegra124-venice2.dts | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/nvidia/tegra124-nyan.dtsi b/arch/arm/boot/dts/nvidia/tegra124-nyan.dtsi
index a2ee371802004..8125c1b3e8d79 100644
--- a/arch/arm/boot/dts/nvidia/tegra124-nyan.dtsi
+++ b/arch/arm/boot/dts/nvidia/tegra124-nyan.dtsi
@@ -338,6 +338,7 @@ cros_ec: cros-ec@0 {
interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(C, 7) IRQ_TYPE_LEVEL_LOW>;
reg = <0>;
+ wakeup-source;
google,cros-ec-spi-msg-delay = <2000>;
diff --git a/arch/arm/boot/dts/nvidia/tegra124-venice2.dts b/arch/arm/boot/dts/nvidia/tegra124-venice2.dts
index 3924ee385dee0..df98dc2a67b85 100644
--- a/arch/arm/boot/dts/nvidia/tegra124-venice2.dts
+++ b/arch/arm/boot/dts/nvidia/tegra124-venice2.dts
@@ -857,6 +857,7 @@ cros_ec: cros-ec@0 {
interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(C, 7) IRQ_TYPE_LEVEL_LOW>;
reg = <0>;
+ wakeup-source;
google,cros-ec-spi-msg-delay = <2000>;
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 06/24] ARM: dts: rockchip: rk3288: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 04/24] dt-bindings: power: Clarify wording for wakeup-source property Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 05/24] ARM: dts: tegra: Enable cros-ec-spi as wake source Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 07/24] ARM: dts: samsung: exynos5420: " Mark Hasemeyer
` (16 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Conor Dooley, Heiko Stuebner,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel,
linux-rockchip
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm/boot/dts/rockchip/rk3288-veyron-chromebook.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/rockchip/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rockchip/rk3288-veyron-chromebook.dtsi
index 092316be67f74..1554fe36e60fe 100644
--- a/arch/arm/boot/dts/rockchip/rk3288-veyron-chromebook.dtsi
+++ b/arch/arm/boot/dts/rockchip/rk3288-veyron-chromebook.dtsi
@@ -112,6 +112,7 @@ cros_ec: ec@0 {
pinctrl-names = "default";
pinctrl-0 = <&ec_int>;
spi-max-frequency = <3000000>;
+ wakeup-source;
i2c_tunnel: i2c-tunnel {
compatible = "google,cros-ec-i2c-tunnel";
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 07/24] ARM: dts: samsung: exynos5420: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (2 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 06/24] ARM: dts: rockchip: rk3288: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-27 11:54 ` Krzysztof Kozlowski
2023-12-26 19:21 ` [PATCH v3 08/24] ARM: dts: samsung: exynos5800: " Mark Hasemeyer
` (15 subsequent siblings)
19 siblings, 1 reply; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Alim Akhtar, Conor Dooley,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel,
linux-samsung-soc
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts b/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts
index 4e757b6e28e1c..3759742d38cac 100644
--- a/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/samsung/exynos5420-peach-pit.dts
@@ -967,6 +967,7 @@ cros_ec: cros-ec@0 {
reg = <0>;
spi-max-frequency = <3125000>;
google,has-vbc-nvram;
+ wakeup-source;
controller-data {
samsung,spi-feedback-delay = <1>;
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 07/24] ARM: dts: samsung: exynos5420: Enable cros-ec-spi as wake source
2023-12-26 19:21 ` [PATCH v3 07/24] ARM: dts: samsung: exynos5420: " Mark Hasemeyer
@ 2023-12-27 11:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-27 11:54 UTC (permalink / raw)
To: Mark Hasemeyer, LKML
Cc: AngeloGioacchino Del Regno, Rob Herring, Konrad Dybcio,
Sudeep Holla, Andy Shevchenko, Raul Rangel, Tzung-Bi Shih,
Alim Akhtar, Conor Dooley, Krzysztof Kozlowski, Rob Herring,
devicetree, linux-arm-kernel, linux-samsung-soc
On 26/12/2023 20:21, Mark Hasemeyer wrote:
> The cros_ec driver currently assumes that cros-ec-spi compatible device
> nodes are a wakeup-source even though the wakeup-source property is not
> defined.
>
> Some Chromebooks use a separate wake pin, while others overload the
> interrupt for wake and IO. With the current assumption, spurious wakes
> can occur on systems that use a separate wake pin. It is planned to
> update the driver to no longer assume that the EC interrupt pin should
> be enabled for wake.
>
> Add the wakeup-source property to all cros-ec-spi compatible device
> nodes to signify to the driver that they should still be a valid wakeup
> source.
>
> -Commit-changes: 3
This looks like changelog, although a bit confusing. If it is changelog,
then please keep it under ---.
I can fix it while applying, but this will be after the merge window.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v3 08/24] ARM: dts: samsung: exynos5800: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (3 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 07/24] ARM: dts: samsung: exynos5420: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 09/24] arm64: dts: mediatek: mt8173: " Mark Hasemeyer
` (14 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Alim Akhtar, Conor Dooley,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel,
linux-samsung-soc
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts b/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts
index f91bc4ae008e4..9bbbdce9103a6 100644
--- a/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/samsung/exynos5800-peach-pi.dts
@@ -949,6 +949,7 @@ cros_ec: cros-ec@0 {
reg = <0>;
spi-max-frequency = <3125000>;
google,has-vbc-nvram;
+ wakeup-source;
controller-data {
samsung,spi-feedback-delay = <1>;
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 09/24] arm64: dts: mediatek: mt8173: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (4 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 08/24] ARM: dts: samsung: exynos5800: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 10/24] arm64: dts: mediatek: mt8183: " Mark Hasemeyer
` (13 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Conor Dooley, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, devicetree, linux-arm-kernel,
linux-mediatek
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index 8d614ac2c58ed..335aed42dc9e3 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -1155,6 +1155,7 @@ cros_ec: ec@0 {
spi-max-frequency = <12000000>;
interrupts-extended = <&pio 0 IRQ_TYPE_LEVEL_LOW>;
google,cros-ec-spi-msg-delay = <500>;
+ wakeup-source;
i2c_tunnel: i2c-tunnel0 {
compatible = "google,cros-ec-i2c-tunnel";
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 10/24] arm64: dts: mediatek: mt8183: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (5 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 09/24] arm64: dts: mediatek: mt8173: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 11/24] arm64: dts: mediatek: mt8192: " Mark Hasemeyer
` (12 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Conor Dooley, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, devicetree, linux-arm-kernel,
linux-mediatek
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index 5506de83f61d4..08261164ab18d 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -924,6 +924,7 @@ cros_ec: cros-ec@0 {
interrupts-extended = <&pio 151 IRQ_TYPE_LEVEL_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&ec_ap_int_odl>;
+ wakeup-source;
i2c_tunnel: i2c-tunnel {
compatible = "google,cros-ec-i2c-tunnel";
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 11/24] arm64: dts: mediatek: mt8192: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (6 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 10/24] arm64: dts: mediatek: mt8183: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 12/24] arm64: dts: mediatek: mt8195: " Mark Hasemeyer
` (11 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Conor Dooley, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, devicetree, linux-arm-kernel,
linux-mediatek
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
index f2281250ac35d..ab44d382f757e 100644
--- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
@@ -1332,6 +1332,7 @@ cros_ec: ec@0 {
spi-max-frequency = <3000000>;
pinctrl-names = "default";
pinctrl-0 = <&cros_ec_int>;
+ wakeup-source;
#address-cells = <1>;
#size-cells = <0>;
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 12/24] arm64: dts: mediatek: mt8195: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (7 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 11/24] arm64: dts: mediatek: mt8192: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 13/24] arm64: dts: tegra: " Mark Hasemeyer
` (10 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Conor Dooley, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, devicetree, linux-arm-kernel,
linux-mediatek
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
index bbdcd441c049d..2edb270d0bc2f 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
@@ -1149,6 +1149,7 @@ cros_ec: ec@0 {
pinctrl-names = "default";
pinctrl-0 = <&cros_ec_int>;
spi-max-frequency = <3000000>;
+ wakeup-source;
keyboard-backlight {
compatible = "google,cros-kbd-led-backlight";
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 13/24] arm64: dts: tegra: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (8 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 12/24] arm64: dts: mediatek: mt8195: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 14/24] arm64: dts: qcom: sc7180: " Mark Hasemeyer
` (9 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Conor Dooley, Jonathan Hunter,
Krzysztof Kozlowski, Rob Herring, Thierry Reding, devicetree,
linux-tegra
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
index bbc2e9bef08da..14d58859bb55c 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
@@ -762,6 +762,7 @@ ec: cros-ec@0 {
interrupt-parent = <&gpio>;
interrupts = <TEGRA_GPIO(C, 7) IRQ_TYPE_LEVEL_LOW>;
reg = <0>;
+ wakeup-source;
google,cros-ec-spi-msg-delay = <2000>;
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 14/24] arm64: dts: qcom: sc7180: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (9 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 13/24] arm64: dts: tegra: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 15/24] arm64: dts: qcom: sc7280: " Mark Hasemeyer
` (8 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Bjorn Andersson, Conor Dooley,
Krzysztof Kozlowski, Rob Herring, cros-qcom-dts-watchers,
devicetree, linux-arm-msm
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 46aaeba286047..f3a6da8b28901 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -649,6 +649,7 @@ cros_ec: ec@0 {
pinctrl-names = "default";
pinctrl-0 = <&ap_ec_int_l>;
spi-max-frequency = <3000000>;
+ wakeup-source;
cros_ec_pwm: pwm {
compatible = "google,cros-ec-pwm";
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 15/24] arm64: dts: qcom: sc7280: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (10 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 14/24] arm64: dts: qcom: sc7180: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 16/24] arm64: dts: qcom: sdm845: " Mark Hasemeyer
` (7 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Bjorn Andersson, Conor Dooley,
Krzysztof Kozlowski, Rob Herring, cros-qcom-dts-watchers,
devicetree, linux-arm-msm
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1 +
arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index 9ea6636125ad9..2ba4ea60cb147 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -548,6 +548,7 @@ cros_ec: ec@0 {
pinctrl-names = "default";
pinctrl-0 = <&ap_ec_int_l>;
spi-max-frequency = <3000000>;
+ wakeup-source;
cros_ec_pwm: pwm {
compatible = "google,cros-ec-pwm";
diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi
index ebae545c587c4..fbfac7534d3c6 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi
@@ -19,6 +19,7 @@ cros_ec: ec@0 {
pinctrl-names = "default";
pinctrl-0 = <&ap_ec_int_l>;
spi-max-frequency = <3000000>;
+ wakeup-source;
cros_ec_pwm: pwm {
compatible = "google,cros-ec-pwm";
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 16/24] arm64: dts: qcom: sdm845: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (11 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 15/24] arm64: dts: qcom: sc7280: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 17/24] arm64: dts: rockchip: rk3399: " Mark Hasemeyer
` (6 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Bjorn Andersson, Conor Dooley,
Krzysztof Kozlowski, Rob Herring, cros-qcom-dts-watchers,
devicetree, linux-arm-msm
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index 0ab5e8f53ac9f..e8276db9eabb2 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -852,6 +852,7 @@ cros_ec: ec@0 {
pinctrl-names = "default";
pinctrl-0 = <&ec_ap_int_l>;
spi-max-frequency = <3000000>;
+ wakeup-source;
cros_ec_pwm: pwm {
compatible = "google,cros-ec-pwm";
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 17/24] arm64: dts: rockchip: rk3399: Enable cros-ec-spi as wake source
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (12 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 16/24] arm64: dts: qcom: sdm845: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-26 19:21 ` [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource() Mark Hasemeyer
` (5 subsequent siblings)
19 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Conor Dooley, Heiko Stuebner,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-arm-kernel,
linux-rockchip
The cros_ec driver currently assumes that cros-ec-spi compatible device
nodes are a wakeup-source even though the wakeup-source property is not
defined.
Some Chromebooks use a separate wake pin, while others overload the
interrupt for wake and IO. With the current assumption, spurious wakes
can occur on systems that use a separate wake pin. It is planned to
update the driver to no longer assume that the EC interrupt pin should
be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device
nodes to signify to the driver that they should still be a valid wakeup
source.
-Commit-changes: 3
-Update commit message to provide details of the motivation behind the
change
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-Split by arch/soc
arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
index 789fd0dcc88ba..b5734e056aef1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
@@ -603,6 +603,7 @@ cros_ec: ec@0 {
pinctrl-names = "default";
pinctrl-0 = <&ec_ap_int_l>;
spi-max-frequency = <3000000>;
+ wakeup-source;
i2c_tunnel: i2c-tunnel {
compatible = "google,cros-ec-i2c-tunnel";
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource()
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (13 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 17/24] arm64: dts: rockchip: rk3399: " Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-27 17:19 ` Andy Shevchenko
2024-01-02 16:01 ` Rob Herring
2023-12-26 19:21 ` [PATCH v3 19/24] of: irq: Add default implementation for of_irq_to_resource() Mark Hasemeyer
` (4 subsequent siblings)
19 siblings, 2 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Frank Rowand, Rob Herring,
devicetree
Add wake capability information to the IRQ resource. Wake capability is
assumed based on conventions provided in the devicetree wakeup-source
binding documentation. An interrupt is considered wake capable if the
following are true:
1. A wakeup-source property exits in the same device node as the
interrupt.
2. The IRQ is marked as dedicated by setting its interrupt-name to
"wakeup".
The wakeup-source documentation states that dedicated interrupts can use
device specific interrupt names and device drivers are still welcome to
use their own naming schemes. This API is provided as a helper if one is
willing to conform to the above conventions.
The ACPI subsystems already provides similar APIs that allow one to
query the wake capability of an IRQ. This brings closer feature parity
to the devicetree.
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
Changes in v3:
-Use DEFINE_RES_IRQ_NAMED_FLAGS macro
Changes in v2:
-Update logic to return true only if wakeup-source property and
"wakeup" interrupt-name are defined
-irq->IRQ, api->API
drivers/of/irq.c | 39 +++++++++++++++++++++++++++++++++++----
1 file changed, 35 insertions(+), 4 deletions(-)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 174900072c18c..cdecdc3515f88 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -383,11 +383,39 @@ int of_irq_parse_one(struct device_node *device, int index, struct of_phandle_ar
}
EXPORT_SYMBOL_GPL(of_irq_parse_one);
+/**
+ * __of_irq_wake_capable - Determine whether a given IRQ index is wake capable
+ *
+ * The IRQ is considered wake capable if the following are true:
+ * 1. wakeup-source property exists
+ * 2. provided IRQ index is labelled as a dedicated wakeirq
+ *
+ * This logic assumes the provided IRQ index is valid.
+ *
+ * @dev: pointer to device tree node
+ * @index: zero-based index of the IRQ
+ * Return: True if provided IRQ index for #dev is wake capable. False otherwise.
+ */
+static bool __of_irq_wake_capable(const struct device_node *dev, int index)
+{
+ int wakeindex;
+
+ if (!of_property_read_bool(dev, "wakeup-source"))
+ return false;
+
+ wakeindex = of_property_match_string(dev, "interrupt-names", "wakeup");
+ return wakeindex >= 0 && wakeindex == index;
+}
+
/**
* of_irq_to_resource - Decode a node's IRQ and return it as a resource
* @dev: pointer to device tree node
- * @index: zero-based index of the irq
+ * @index: zero-based index of the IRQ
* @r: pointer to resource structure to return result into.
+ *
+ * Return: Linux IRQ number on success, or 0 on the IRQ mapping failure, or
+ * -EPROBE_DEFER if the IRQ domain is not yet created, or error code in case
+ * of any other failure.
*/
int of_irq_to_resource(struct device_node *dev, int index, struct resource *r)
{
@@ -399,6 +427,7 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r)
/* Only dereference the resource if both the
* resource and the irq are valid. */
if (r && irq) {
+ u32 irq_flags;
const char *name = NULL;
memset(r, 0, sizeof(*r));
@@ -409,9 +438,11 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r)
of_property_read_string_index(dev, "interrupt-names", index,
&name);
- r->start = r->end = irq;
- r->flags = IORESOURCE_IRQ | irqd_get_trigger_type(irq_get_irq_data(irq));
- r->name = name ? name : of_node_full_name(dev);
+ irq_flags = irqd_get_trigger_type(irq_get_irq_data(irq));
+ if (__of_irq_wake_capable(dev, index))
+ irq_flags |= IORESOURCE_IRQ_WAKECAPABLE;
+
+ *r = DEFINE_RES_IRQ_NAMED_FLAGS(irq, name ?: of_node_full_name(dev), irq_flags);
}
return irq;
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource()
2023-12-26 19:21 ` [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource() Mark Hasemeyer
@ 2023-12-27 17:19 ` Andy Shevchenko
2023-12-27 18:21 ` Mark Hasemeyer
2024-01-02 16:01 ` Rob Herring
1 sibling, 1 reply; 32+ messages in thread
From: Andy Shevchenko @ 2023-12-27 17:19 UTC (permalink / raw)
To: Mark Hasemeyer
Cc: LKML, AngeloGioacchino Del Regno, Krzysztof Kozlowski,
Rob Herring, Konrad Dybcio, Sudeep Holla, Raul Rangel,
Tzung-Bi Shih, Frank Rowand, Rob Herring, devicetree
On Tue, Dec 26, 2023 at 12:21:22PM -0700, Mark Hasemeyer wrote:
> Add wake capability information to the IRQ resource. Wake capability is
> assumed based on conventions provided in the devicetree wakeup-source
> binding documentation. An interrupt is considered wake capable if the
> following are true:
> 1. A wakeup-source property exits in the same device node as the
> interrupt.
> 2. The IRQ is marked as dedicated by setting its interrupt-name to
> "wakeup".
>
> The wakeup-source documentation states that dedicated interrupts can use
> device specific interrupt names and device drivers are still welcome to
> use their own naming schemes. This API is provided as a helper if one is
> willing to conform to the above conventions.
>
> The ACPI subsystems already provides similar APIs that allow one to
> query the wake capability of an IRQ. This brings closer feature parity
> to the devicetree.
...
> + u32 irq_flags;
> const char *name = NULL;
Don't know if OF style requires reversed xmas tree order. If so, this should be
const char *name = NULL;
u32 irq_flags;
Otherwise looks good to me, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource()
2023-12-27 17:19 ` Andy Shevchenko
@ 2023-12-27 18:21 ` Mark Hasemeyer
2024-01-02 16:01 ` Rob Herring
0 siblings, 1 reply; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-27 18:21 UTC (permalink / raw)
To: Andy Shevchenko
Cc: LKML, AngeloGioacchino Del Regno, Krzysztof Kozlowski,
Rob Herring, Konrad Dybcio, Sudeep Holla, Raul Rangel,
Tzung-Bi Shih, Frank Rowand, Rob Herring, devicetree
>
> > + u32 irq_flags;
> > const char *name = NULL;
>
> Don't know if OF style requires reversed xmas tree order. If so, this should be
>
> const char *name = NULL;
> u32 irq_flags;
>
I see both methods used. For example, of_irq_init() uses normal xmas
tree order. I'll leave it unless Rob says otherwise.
It is Christmas time, so I do want to honor the Christmas trees appropriately!
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource()
2023-12-27 18:21 ` Mark Hasemeyer
@ 2024-01-02 16:01 ` Rob Herring
0 siblings, 0 replies; 32+ messages in thread
From: Rob Herring @ 2024-01-02 16:01 UTC (permalink / raw)
To: Mark Hasemeyer
Cc: Andy Shevchenko, LKML, AngeloGioacchino Del Regno,
Krzysztof Kozlowski, Konrad Dybcio, Sudeep Holla, Raul Rangel,
Tzung-Bi Shih, Frank Rowand, devicetree
On Wed, Dec 27, 2023 at 11:21:14AM -0700, Mark Hasemeyer wrote:
> >
> > > + u32 irq_flags;
> > > const char *name = NULL;
> >
> > Don't know if OF style requires reversed xmas tree order. If so, this should be
> >
> > const char *name = NULL;
> > u32 irq_flags;
> >
>
> I see both methods used. For example, of_irq_init() uses normal xmas
> tree order. I'll leave it unless Rob says otherwise.
> It is Christmas time, so I do want to honor the Christmas trees appropriately!
DT requires sideways Christmas tree because we're special. You'll have
to add a 3rd variable. ;)
Rob
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource()
2023-12-26 19:21 ` [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource() Mark Hasemeyer
2023-12-27 17:19 ` Andy Shevchenko
@ 2024-01-02 16:01 ` Rob Herring
1 sibling, 0 replies; 32+ messages in thread
From: Rob Herring @ 2024-01-02 16:01 UTC (permalink / raw)
To: Mark Hasemeyer
Cc: Krzysztof Kozlowski, AngeloGioacchino Del Regno, Raul Rangel,
Konrad Dybcio, Sudeep Holla, Frank Rowand, Andy Shevchenko,
devicetree, Rob Herring, LKML, Tzung-Bi Shih
On Tue, 26 Dec 2023 12:21:22 -0700, Mark Hasemeyer wrote:
> Add wake capability information to the IRQ resource. Wake capability is
> assumed based on conventions provided in the devicetree wakeup-source
> binding documentation. An interrupt is considered wake capable if the
> following are true:
> 1. A wakeup-source property exits in the same device node as the
> interrupt.
> 2. The IRQ is marked as dedicated by setting its interrupt-name to
> "wakeup".
>
> The wakeup-source documentation states that dedicated interrupts can use
> device specific interrupt names and device drivers are still welcome to
> use their own naming schemes. This API is provided as a helper if one is
> willing to conform to the above conventions.
>
> The ACPI subsystems already provides similar APIs that allow one to
> query the wake capability of an IRQ. This brings closer feature parity
> to the devicetree.
>
> Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
> ---
>
> Changes in v3:
> -Use DEFINE_RES_IRQ_NAMED_FLAGS macro
>
> Changes in v2:
> -Update logic to return true only if wakeup-source property and
> "wakeup" interrupt-name are defined
> -irq->IRQ, api->API
>
> drivers/of/irq.c | 39 +++++++++++++++++++++++++++++++++++----
> 1 file changed, 35 insertions(+), 4 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v3 19/24] of: irq: Add default implementation for of_irq_to_resource()
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (14 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 18/24] of: irq: add wake capable bit to of_irq_resource() Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2024-01-02 16:02 ` Rob Herring
2023-12-26 19:21 ` [PATCH v3 20/24] of: irq: Remove extern from function declarations Mark Hasemeyer
` (3 subsequent siblings)
19 siblings, 1 reply; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Frank Rowand, Rob Herring,
devicetree
Similar to of_irq_to_resource_table(), add a default implementation of
of_irq_to_resource() for systems that don't have CONFIG_OF_IRQ defined.
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-None
include/linux/of_irq.h | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h
index d6d3eae2f1452..0d73b2ca92d31 100644
--- a/include/linux/of_irq.h
+++ b/include/linux/of_irq.h
@@ -34,8 +34,6 @@ static inline int of_irq_parse_oldworld(const struct device_node *device, int in
extern int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq);
extern unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data);
-extern int of_irq_to_resource(struct device_node *dev, int index,
- struct resource *r);
#ifdef CONFIG_OF_IRQ
extern void of_irq_init(const struct of_device_id *matches);
@@ -44,6 +42,7 @@ extern int of_irq_parse_one(struct device_node *device, int index,
extern int of_irq_count(struct device_node *dev);
extern int of_irq_get(struct device_node *dev, int index);
extern int of_irq_get_byname(struct device_node *dev, const char *name);
+extern int of_irq_to_resource(struct device_node *dev, int index, struct resource *r);
extern int of_irq_to_resource_table(struct device_node *dev,
struct resource *res, int nr_irqs);
extern struct device_node *of_irq_find_parent(struct device_node *child);
@@ -76,6 +75,11 @@ static inline int of_irq_get_byname(struct device_node *dev, const char *name)
{
return 0;
}
+static inline int of_irq_to_resource(struct device_node *dev, int index,
+ struct resource *r)
+{
+ return 0;
+}
static inline int of_irq_to_resource_table(struct device_node *dev,
struct resource *res, int nr_irqs)
{
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 19/24] of: irq: Add default implementation for of_irq_to_resource()
2023-12-26 19:21 ` [PATCH v3 19/24] of: irq: Add default implementation for of_irq_to_resource() Mark Hasemeyer
@ 2024-01-02 16:02 ` Rob Herring
2024-01-02 16:53 ` Mark Hasemeyer
0 siblings, 1 reply; 32+ messages in thread
From: Rob Herring @ 2024-01-02 16:02 UTC (permalink / raw)
To: Mark Hasemeyer
Cc: Rob Herring, Sudeep Holla, Andy Shevchenko, Konrad Dybcio,
Tzung-Bi Shih, Raul Rangel, Frank Rowand,
AngeloGioacchino Del Regno, LKML, Krzysztof Kozlowski, devicetree
On Tue, 26 Dec 2023 12:21:23 -0700, Mark Hasemeyer wrote:
> Similar to of_irq_to_resource_table(), add a default implementation of
> of_irq_to_resource() for systems that don't have CONFIG_OF_IRQ defined.
>
> Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> -None
>
> include/linux/of_irq.h | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
Missing tags:
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v3 19/24] of: irq: Add default implementation for of_irq_to_resource()
2024-01-02 16:02 ` Rob Herring
@ 2024-01-02 16:53 ` Mark Hasemeyer
0 siblings, 0 replies; 32+ messages in thread
From: Mark Hasemeyer @ 2024-01-02 16:53 UTC (permalink / raw)
To: Rob Herring
Cc: Rob Herring, Sudeep Holla, Andy Shevchenko, Konrad Dybcio,
Tzung-Bi Shih, Raul Rangel, Frank Rowand,
AngeloGioacchino Del Regno, LKML, Krzysztof Kozlowski, devicetree
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
>
> Missing tags:
>
> Acked-by: Rob Herring <robh@kernel.org>
Thanks Rob. They were not excluded on purpose. I just forgot to add
them on a few patches. I have a new version coming, and will make sure
to include them.
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v3 20/24] of: irq: Remove extern from function declarations
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (15 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 19/24] of: irq: Add default implementation for of_irq_to_resource() Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2024-01-02 16:02 ` Rob Herring
2023-12-26 19:21 ` [PATCH v3 21/24] device property: Modify fwnode irq_get() to use resource Mark Hasemeyer
` (2 subsequent siblings)
19 siblings, 1 reply; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Frank Rowand, Rob Herring,
devicetree
The extern keyword is implicit for function declarations.
Remove it where possible and adjust the line wrapping accordingly.
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
(no changes since v2)
Changes in v2:
-New patch
include/linux/of_irq.h | 35 +++++++++++++++++------------------
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h
index 0d73b2ca92d31..a130dcbc4bb45 100644
--- a/include/linux/of_irq.h
+++ b/include/linux/of_irq.h
@@ -32,27 +32,26 @@ static inline int of_irq_parse_oldworld(const struct device_node *device, int in
}
#endif /* CONFIG_PPC32 && CONFIG_PPC_PMAC */
-extern int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq);
-extern unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data);
+int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq);
+unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data);
#ifdef CONFIG_OF_IRQ
-extern void of_irq_init(const struct of_device_id *matches);
-extern int of_irq_parse_one(struct device_node *device, int index,
- struct of_phandle_args *out_irq);
-extern int of_irq_count(struct device_node *dev);
-extern int of_irq_get(struct device_node *dev, int index);
-extern int of_irq_get_byname(struct device_node *dev, const char *name);
-extern int of_irq_to_resource(struct device_node *dev, int index, struct resource *r);
-extern int of_irq_to_resource_table(struct device_node *dev,
- struct resource *res, int nr_irqs);
-extern struct device_node *of_irq_find_parent(struct device_node *child);
-extern struct irq_domain *of_msi_get_domain(struct device *dev,
+void of_irq_init(const struct of_device_id *matches);
+int of_irq_parse_one(struct device_node *device, int index,
+ struct of_phandle_args *out_irq);
+int of_irq_count(struct device_node *dev);
+int of_irq_get(struct device_node *dev, int index);
+int of_irq_get_byname(struct device_node *dev, const char *name);
+int of_irq_to_resource(struct device_node *dev, int index, struct resource *r);
+int of_irq_to_resource_table(struct device_node *dev, struct resource *res,
+ int nr_irqs);
+struct device_node *of_irq_find_parent(struct device_node *child);
+struct irq_domain *of_msi_get_domain(struct device *dev,
struct device_node *np,
enum irq_domain_bus_token token);
-extern struct irq_domain *of_msi_map_get_device_domain(struct device *dev,
- u32 id,
- u32 bus_token);
-extern void of_msi_configure(struct device *dev, struct device_node *np);
+struct irq_domain *of_msi_map_get_device_domain(struct device *dev, u32 id,
+ u32 bus_token);
+void of_msi_configure(struct device *dev, struct device_node *np);
u32 of_msi_map_id(struct device *dev, struct device_node *msi_np, u32 id_in);
#else
static inline void of_irq_init(const struct of_device_id *matches)
@@ -117,7 +116,7 @@ static inline u32 of_msi_map_id(struct device *dev,
* implements it differently. However, the prototype is the same for all,
* so declare it here regardless of the CONFIG_OF_IRQ setting.
*/
-extern unsigned int irq_of_parse_and_map(struct device_node *node, int index);
+unsigned int irq_of_parse_and_map(struct device_node *node, int index);
#else /* !CONFIG_OF && !CONFIG_SPARC */
static inline unsigned int irq_of_parse_and_map(struct device_node *dev,
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 20/24] of: irq: Remove extern from function declarations
2023-12-26 19:21 ` [PATCH v3 20/24] of: irq: Remove extern from function declarations Mark Hasemeyer
@ 2024-01-02 16:02 ` Rob Herring
0 siblings, 0 replies; 32+ messages in thread
From: Rob Herring @ 2024-01-02 16:02 UTC (permalink / raw)
To: Mark Hasemeyer
Cc: Rob Herring, Konrad Dybcio, Sudeep Holla, Raul Rangel,
Tzung-Bi Shih, Frank Rowand, Andy Shevchenko,
AngeloGioacchino Del Regno, LKML, devicetree, Krzysztof Kozlowski
On Tue, 26 Dec 2023 12:21:24 -0700, Mark Hasemeyer wrote:
> The extern keyword is implicit for function declarations.
> Remove it where possible and adjust the line wrapping accordingly.
>
> Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
> ---
>
> (no changes since v2)
>
> Changes in v2:
> -New patch
>
> include/linux/of_irq.h | 35 +++++++++++++++++------------------
> 1 file changed, 17 insertions(+), 18 deletions(-)
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
Missing tags:
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v3 21/24] device property: Modify fwnode irq_get() to use resource
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (16 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 20/24] of: irq: Remove extern from function declarations Mark Hasemeyer
@ 2023-12-26 19:21 ` Mark Hasemeyer
2023-12-27 17:24 ` Andy Shevchenko
2024-02-14 17:57 ` (subset) [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Bjorn Andersson
2024-02-16 11:31 ` Thierry Reding
19 siblings, 1 reply; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-26 19:21 UTC (permalink / raw)
To: LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, Mark Hasemeyer, Andy Shevchenko, Daniel Scally,
Frank Rowand, Greg Kroah-Hartman, Heikki Krogerus, Len Brown,
Rafael J. Wysocki, Rob Herring, Sakari Ailus, devicetree,
linux-acpi
The underlying ACPI and OF subsystems provide their own APIs which
provide IRQ information as a struct resource. This allows callers to get
more information about the IRQ by looking at the resource flags. For
example, whether or not an IRQ is wake capable.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
Changes in v3:
-Add Suggested-by tag
-Initialize struct resource to 0 on stack
-EXPORT_SYMBOL()->EXPORT_SYMBOL_GPL()
-Remove extra space in commit message
-Reformat fwnode_irq_get_resource() declaration
Changes in v2:
-New patch
drivers/acpi/property.c | 11 +++++------
drivers/base/property.c | 24 +++++++++++++++++++++---
drivers/of/property.c | 8 ++++----
include/linux/fwnode.h | 8 +++++---
include/linux/property.h | 2 ++
5 files changed, 37 insertions(+), 16 deletions(-)
diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index a6ead5204046b..891fff5a16797 100644
--- a/drivers/acpi/property.c
+++ b/drivers/acpi/property.c
@@ -1627,17 +1627,16 @@ static int acpi_fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode,
return 0;
}
-static int acpi_fwnode_irq_get(const struct fwnode_handle *fwnode,
- unsigned int index)
+static int acpi_fwnode_irq_get_resource(const struct fwnode_handle *fwnode, unsigned int index,
+ struct resource *r)
{
- struct resource res;
int ret;
- ret = acpi_irq_get(ACPI_HANDLE_FWNODE(fwnode), index, &res);
+ ret = acpi_irq_get(ACPI_HANDLE_FWNODE(fwnode), index, r);
if (ret)
return ret;
- return res.start;
+ return r->start;
}
#define DECLARE_ACPI_FWNODE_OPS(ops) \
@@ -1664,7 +1663,7 @@ static int acpi_fwnode_irq_get(const struct fwnode_handle *fwnode,
acpi_graph_get_remote_endpoint, \
.graph_get_port_parent = acpi_fwnode_get_parent, \
.graph_parse_endpoint = acpi_fwnode_graph_parse_endpoint, \
- .irq_get = acpi_fwnode_irq_get, \
+ .irq_get_resource = acpi_fwnode_irq_get_resource, \
}; \
EXPORT_SYMBOL_GPL(ops)
diff --git a/drivers/base/property.c b/drivers/base/property.c
index a1b01ab420528..441899171d19d 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -1047,23 +1047,41 @@ void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int index)
EXPORT_SYMBOL(fwnode_iomap);
/**
- * fwnode_irq_get - Get IRQ directly from a fwnode
+ * fwnode_irq_get_resource - Get IRQ directly from a fwnode and populate
+ * the resource struct
* @fwnode: Pointer to the firmware node
* @index: Zero-based index of the IRQ
+ * @r: Pointer to resource to populate with IRQ information.
*
* Return: Linux IRQ number on success. Negative errno on failure.
*/
-int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index)
+int fwnode_irq_get_resource(const struct fwnode_handle *fwnode, unsigned int index,
+ struct resource *r)
{
int ret;
- ret = fwnode_call_int_op(fwnode, irq_get, index);
+ ret = fwnode_call_int_op(fwnode, irq_get_resource, index, r);
/* We treat mapping errors as invalid case */
if (ret == 0)
return -EINVAL;
return ret;
}
+EXPORT_SYMBOL_GPL(fwnode_irq_get_resource);
+
+/**
+ * fwnode_irq_get - Get IRQ directly from a fwnode
+ * @fwnode: Pointer to the firmware node
+ * @index: Zero-based index of the IRQ
+ *
+ * Return: Linux IRQ number on success. Negative errno on failure.
+ */
+int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index)
+{
+ struct resource r = {};
+
+ return fwnode_irq_get_resource(fwnode, index, &r);
+}
EXPORT_SYMBOL(fwnode_irq_get);
/**
diff --git a/drivers/of/property.c b/drivers/of/property.c
index afdaefbd03f61..864ea5fa5702b 100644
--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -1425,10 +1425,10 @@ static void __iomem *of_fwnode_iomap(struct fwnode_handle *fwnode, int index)
#endif
}
-static int of_fwnode_irq_get(const struct fwnode_handle *fwnode,
- unsigned int index)
+static int of_fwnode_irq_get_resource(const struct fwnode_handle *fwnode,
+ unsigned int index, struct resource *r)
{
- return of_irq_get(to_of_node(fwnode), index);
+ return of_irq_to_resource(to_of_node(fwnode), index, r);
}
static int of_fwnode_add_links(struct fwnode_handle *fwnode)
@@ -1469,7 +1469,7 @@ const struct fwnode_operations of_fwnode_ops = {
.graph_get_port_parent = of_fwnode_graph_get_port_parent,
.graph_parse_endpoint = of_fwnode_graph_parse_endpoint,
.iomap = of_fwnode_iomap,
- .irq_get = of_fwnode_irq_get,
+ .irq_get_resource = of_fwnode_irq_get_resource,
.add_links = of_fwnode_add_links,
};
EXPORT_SYMBOL_GPL(of_fwnode_ops);
diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
index 2a72f55d26eb8..716ed863acde0 100644
--- a/include/linux/fwnode.h
+++ b/include/linux/fwnode.h
@@ -9,10 +9,11 @@
#ifndef _LINUX_FWNODE_H_
#define _LINUX_FWNODE_H_
-#include <linux/types.h>
-#include <linux/list.h>
#include <linux/bits.h>
#include <linux/err.h>
+#include <linux/ioport.h>
+#include <linux/list.h>
+#include <linux/types.h>
struct fwnode_operations;
struct device;
@@ -164,7 +165,8 @@ struct fwnode_operations {
int (*graph_parse_endpoint)(const struct fwnode_handle *fwnode,
struct fwnode_endpoint *endpoint);
void __iomem *(*iomap)(struct fwnode_handle *fwnode, int index);
- int (*irq_get)(const struct fwnode_handle *fwnode, unsigned int index);
+ int (*irq_get_resource)(const struct fwnode_handle *fwnode,
+ unsigned int index, struct resource *r);
int (*add_links)(struct fwnode_handle *fwnode);
};
diff --git a/include/linux/property.h b/include/linux/property.h
index e6516d0b7d52a..685ba72a8ce9e 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -190,6 +190,8 @@ struct fwnode_handle *fwnode_handle_get(struct fwnode_handle *fwnode);
void fwnode_handle_put(struct fwnode_handle *fwnode);
int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index);
+int fwnode_irq_get_resource(const struct fwnode_handle *fwnode,
+ unsigned int index, struct resource *r);
int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const char *name);
unsigned int device_get_child_node_count(const struct device *dev);
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH v3 21/24] device property: Modify fwnode irq_get() to use resource
2023-12-26 19:21 ` [PATCH v3 21/24] device property: Modify fwnode irq_get() to use resource Mark Hasemeyer
@ 2023-12-27 17:24 ` Andy Shevchenko
2023-12-27 19:09 ` Mark Hasemeyer
0 siblings, 1 reply; 32+ messages in thread
From: Andy Shevchenko @ 2023-12-27 17:24 UTC (permalink / raw)
To: Mark Hasemeyer
Cc: LKML, AngeloGioacchino Del Regno, Krzysztof Kozlowski,
Rob Herring, Konrad Dybcio, Sudeep Holla, Raul Rangel,
Tzung-Bi Shih, Daniel Scally, Frank Rowand, Greg Kroah-Hartman,
Heikki Krogerus, Len Brown, Rafael J. Wysocki, Rob Herring,
Sakari Ailus, devicetree, linux-acpi
On Tue, Dec 26, 2023 at 12:21:25PM -0700, Mark Hasemeyer wrote:
> The underlying ACPI and OF subsystems provide their own APIs which
> provide IRQ information as a struct resource. This allows callers to get
> more information about the IRQ by looking at the resource flags. For
> example, whether or not an IRQ is wake capable.
...
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
> Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
No blank line.
...
A side note: in all files where you use ioport.h check if you actually included it.
...
> -#include <linux/types.h>
> -#include <linux/list.h>
> #include <linux/bits.h>
> #include <linux/err.h>
> +#include <linux/ioport.h>
> +#include <linux/list.h>
> +#include <linux/types.h>
Fine, but no. This file is still not using the iopoll.h.
See the forward declarations below? It should be there.
> struct fwnode_operations;
> struct device;
...
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
Same comment(s) here.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v3 21/24] device property: Modify fwnode irq_get() to use resource
2023-12-27 17:24 ` Andy Shevchenko
@ 2023-12-27 19:09 ` Mark Hasemeyer
2024-01-06 14:05 ` Andy Shevchenko
0 siblings, 1 reply; 32+ messages in thread
From: Mark Hasemeyer @ 2023-12-27 19:09 UTC (permalink / raw)
To: Andy Shevchenko
Cc: LKML, AngeloGioacchino Del Regno, Krzysztof Kozlowski,
Rob Herring, Konrad Dybcio, Sudeep Holla, Raul Rangel,
Tzung-Bi Shih, Daniel Scally, Frank Rowand, Greg Kroah-Hartman,
Heikki Krogerus, Len Brown, Rafael J. Wysocki, Rob Herring,
Sakari Ailus, devicetree, linux-acpi
> A side note: in all files where you use ioport.h check if you actually included it.
>
> ...
>
> > -#include <linux/types.h>
> > -#include <linux/list.h>
> > #include <linux/bits.h>
> > #include <linux/err.h>
> > +#include <linux/ioport.h>
> > +#include <linux/list.h>
> > +#include <linux/types.h>
>
> Fine, but no. This file is still not using the iopoll.h.
> See the forward declarations below? It should be there.
>
> > struct fwnode_operations;
> > struct device;
>
> ...
>
> > --- a/include/linux/property.h
> > +++ b/include/linux/property.h
>
> Same comment(s) here.
I don't fully follow. Are you suggesting adding an explicit 'struct
resource' declaration as opposed to including ioport.h? If so, why? To
reduce scope?
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v3 21/24] device property: Modify fwnode irq_get() to use resource
2023-12-27 19:09 ` Mark Hasemeyer
@ 2024-01-06 14:05 ` Andy Shevchenko
0 siblings, 0 replies; 32+ messages in thread
From: Andy Shevchenko @ 2024-01-06 14:05 UTC (permalink / raw)
To: Mark Hasemeyer
Cc: LKML, AngeloGioacchino Del Regno, Krzysztof Kozlowski,
Rob Herring, Konrad Dybcio, Sudeep Holla, Raul Rangel,
Tzung-Bi Shih, Daniel Scally, Frank Rowand, Greg Kroah-Hartman,
Heikki Krogerus, Len Brown, Rafael J. Wysocki, Rob Herring,
Sakari Ailus, devicetree, linux-acpi
On Wed, Dec 27, 2023 at 12:09:19PM -0700, Mark Hasemeyer wrote:
> > A side note: in all files where you use ioport.h check if you actually included it.
...
> > > -#include <linux/types.h>
> > > -#include <linux/list.h>
> > > #include <linux/bits.h>
> > > #include <linux/err.h>
> > > +#include <linux/ioport.h>
> > > +#include <linux/list.h>
> > > +#include <linux/types.h>
> >
> > Fine, but no. This file is still not using the iopoll.h.
> > See the forward declarations below? It should be there.
> >
> > > struct fwnode_operations;
> > > struct device;
...
> > > --- a/include/linux/property.h
> > > +++ b/include/linux/property.h
> >
> > Same comment(s) here.
>
> I don't fully follow. Are you suggesting adding an explicit 'struct
> resource' declaration as opposed to including ioport.h?
Yes.
> If so, why? To reduce scope?
Build time, better granularity, less include hellness.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: (subset) [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (17 preceding siblings ...)
2023-12-26 19:21 ` [PATCH v3 21/24] device property: Modify fwnode irq_get() to use resource Mark Hasemeyer
@ 2024-02-14 17:57 ` Bjorn Andersson
2024-02-16 11:31 ` Thierry Reding
19 siblings, 0 replies; 32+ messages in thread
From: Bjorn Andersson @ 2024-02-14 17:57 UTC (permalink / raw)
To: LKML, Mark Hasemeyer
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, AKASHI Takahiro, Alexandre TORGUE, Alim Akhtar,
Andre Przywara, Andrew Morton, Andy Shevchenko, Baoquan He,
Bartosz Golaszewski, Benson Leung, Bhanu Prakash Maiya,
Chen-Yu Tsai, Conor Dooley, Daniel Scally, David Gow,
Enric Balletbo i Serra, Frank Rowand, Greg Kroah-Hartman,
Guenter Roeck, Heikki Krogerus, Heiko Stuebner, Jonathan Hunter,
Krzysztof Kozlowski, Lee Jones, Len Brown, Linus Walleij,
Manivannan Sadhasivam, Mark Brown, Matthias Brugger, Michal Simek,
Mika Westerberg, Nick Hawkins, Prashant Malani, Rafael J. Wysocki,
Rob Barnes, Rob Herring, Sakari Ailus, Stephen Boyd, Takashi Iwai,
Thierry Reding, Tony Lindgren, Uwe Kleine-König,
Wolfram Sang, chrome-platform, cros-qcom-dts-watchers, devicetree,
linux-acpi, linux-arm-kernel, linux-arm-msm, linux-gpio,
linux-i2c, linux-mediatek, linux-rockchip, linux-samsung-soc,
linux-tegra
On Tue, 26 Dec 2023 12:21:04 -0700, Mark Hasemeyer wrote:
> Currently the cros_ec driver assumes that its associated interrupt is
> wake capable. This is an incorrect assumption as some Chromebooks use a
> separate wake pin, while others overload the interrupt for wake and IO.
> This patch train updates the driver to query the underlying ACPI/DT data
> to determine whether or not the IRQ should be enabled for wake.
>
> Both the device tree and ACPI systems have methods for reporting IRQ
> wake capability. In device tree based systems, a node can advertise
> itself as a 'wakeup-source'. In ACPI based systems, GpioInt and
> Interrupt resource descriptors can use the 'SharedAndWake' or
> 'ExclusiveAndWake' share types.
>
> [...]
Applied, thanks!
[14/24] arm64: dts: qcom: sc7180: Enable cros-ec-spi as wake source
commit: f172a341ec1f66bac2866720931594e81f02ad4d
[15/24] arm64: dts: qcom: sc7280: Enable cros-ec-spi as wake source
commit: a4b28b9ecc99673da875e214b1a06f1e0f0a24fa
[16/24] arm64: dts: qcom: sdm845: Enable cros-ec-spi as wake source
commit: a7baa25bfbfdcd4e76414f29ab43317ded8d3e6e
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it
2023-12-26 19:21 [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Mark Hasemeyer
` (18 preceding siblings ...)
2024-02-14 17:57 ` (subset) [PATCH v3 00/24] Improve IRQ wake capability reporting and update the cros_ec driver to use it Bjorn Andersson
@ 2024-02-16 11:31 ` Thierry Reding
19 siblings, 0 replies; 32+ messages in thread
From: Thierry Reding @ 2024-02-16 11:31 UTC (permalink / raw)
To: Mark Hasemeyer, LKML
Cc: AngeloGioacchino Del Regno, Krzysztof Kozlowski, Rob Herring,
Konrad Dybcio, Sudeep Holla, Andy Shevchenko, Raul Rangel,
Tzung-Bi Shih, AKASHI Takahiro, Alexandre TORGUE, Alim Akhtar,
Andre Przywara, Andrew Morton, Andy Shevchenko, Baoquan He,
Bartosz Golaszewski, Benson Leung, Bhanu Prakash Maiya,
Bjorn Andersson, Chen-Yu Tsai, Conor Dooley, Daniel Scally,
David Gow, Enric Balletbo i Serra, Frank Rowand,
Greg Kroah-Hartman, Guenter Roeck, Heikki Krogerus,
Heiko Stuebner, Jonathan Hunter, Krzysztof Kozlowski, Lee Jones,
Len Brown, Linus Walleij, Manivannan Sadhasivam, Mark Brown,
Matthias Brugger, Michal Simek, Mika Westerberg, Nick Hawkins,
Prashant Malani, Rafael J. Wysocki, Rob Barnes, Rob Herring,
Sakari Ailus, Stephen Boyd, Takashi Iwai, Tony Lindgren,
Uwe Kleine-König, Wolfram Sang, chrome-platform,
cros-qcom-dts-watchers, devicetree, linux-acpi, linux-arm-kernel,
linux-arm-msm, linux-gpio, linux-i2c, linux-mediatek,
linux-rockchip, linux-samsung-soc, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]
On Tue Dec 26, 2023 at 8:21 PM CET, Mark Hasemeyer wrote:
> Currently the cros_ec driver assumes that its associated interrupt is
> wake capable. This is an incorrect assumption as some Chromebooks use a
> separate wake pin, while others overload the interrupt for wake and IO.
> This patch train updates the driver to query the underlying ACPI/DT data
> to determine whether or not the IRQ should be enabled for wake.
>
> Both the device tree and ACPI systems have methods for reporting IRQ
> wake capability. In device tree based systems, a node can advertise
> itself as a 'wakeup-source'. In ACPI based systems, GpioInt and
> Interrupt resource descriptors can use the 'SharedAndWake' or
> 'ExclusiveAndWake' share types.
>
> Some logic is added to the platform, ACPI, and DT subsystems to more
> easily pipe wakeirq information up to the driver.
>
> Changes in v3:
> -Rebase on linux-next
> -See each patch for patch specific changes
>
> Changes in v2:
> -Rebase on linux-next
> -Add cover letter
> -See each patch for patch specific changes
>
> Mark Hasemeyer (24):
[...]
> ARM: dts: tegra: Enable cros-ec-spi as wake source
[...]
> arm64: dts: tegra: Enable cros-ec-spi as wake source
[...]
Both patches applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread