From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [RFC PATCH 1/9] ACPI: Add support for device specific properties Date: Mon, 18 Aug 2014 07:37:18 -0500 Message-ID: References: <1408255459-17625-1-git-send-email-mika.westerberg@linux.intel.com> <1408255459-17625-2-git-send-email-mika.westerberg@linux.intel.com> <53F1B5A9.8060307@linaro.org> <20140818082656.GR2462@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140818082656.GR2462@lahna.fi.intel.com> Sender: linux-acpi-owner@vger.kernel.org To: Mika Westerberg , Hanjun Guo Cc: "Rafael J. Wysocki" , Aaron Lu , Max Eliaser , linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On 8/18/14, 3:27, "Mika Westerberg" wrote: >On Mon, Aug 18, 2014 at 04:13:29PM +0800, Hanjun Guo wrote: Hi Hanjun, Thanks for reviewing! >> >> > +/* ACPI _DSD device properties UUID: >>daffd814-6eba-4d8c-8a91-bc9bbf4aa301 */ >> > +static const u8 prp_uuid[16] = { >> >> s/prp_uuid/dsd_uuid ? > >Well, it is actually the _DSD UUID that implements ACPI device >properties (hence the prp_) but I have no problems in changing that to >dsd_uuid instead. The distinction is important. DSD does not define a format, the UUID does, and there can be many - although we are adding support specifically for one. The PRP name here also pairs with the PRP0000 HID. -- Darren Hart Open Source Technology Center darren.hart@intel.com Intel Corporation