From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Mark Brown" <broonie@kernel.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Vaishnav Achath" <vaishnav.a@ti.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Rob Herring" <robh@kernel.org>, <linux-spi@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-mips@vger.kernel.org>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH v2 08/11] spi: cadence-qspi: add early busywait to cqspi_wait_for_bit()
Date: Mon, 08 Apr 2024 16:42:43 +0200 [thread overview]
Message-ID: <D0ETJXNHOUKQ.C368FEZVM9DD@bootlin.com> (raw)
In-Reply-To: <1f7087ad-824e-47fe-9953-ed5152c8f18f@sirena.org.uk>
Hello,
On Mon Apr 8, 2024 at 4:16 PM CEST, Mark Brown wrote:
> On Fri, Apr 05, 2024 at 05:02:18PM +0200, Théo Lebrun wrote:
>
> > If the CQSPI_BUSYWAIT_EARLY quirk flag is on, call
> > readl_relaxed_poll_timeout() with no sleep at the start of
> > cqspi_wait_for_bit(). If its short timeout expires, a sleeping
> > readl_relaxed_poll_timeout() call takes the relay.
> >
> > Behavior is hidden behind a quirk flag to keep the previous behavior the
> > same on all platforms.
> >
> > The reason is to avoid hrtimer interrupts on the system. All read
> > operations take less than 100µs.
>
> Why would this be platform specific, this seems like a very standard
> optimisation technique?
It does not make sense if you know that all read operations take more
than 100µs. I preferred being conservative. If you confirm it makes
sense I'll remove the quirk.
Regards,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-04-08 14:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 15:02 [PATCH v2 00/11] spi: cadence-qspi: add Mobileye EyeQ5 support Théo Lebrun
2024-04-05 15:02 ` [PATCH v2 01/11] spi: dt-bindings: cdns,qspi-nor: add mobileye,eyeq5-ospi compatible Théo Lebrun
2024-04-08 14:13 ` Mark Brown
2024-04-05 15:02 ` [PATCH v2 02/11] spi: dt-bindings: cdns,qspi-nor: sort compatibles alphabetically Théo Lebrun
2024-04-06 11:38 ` Krzysztof Kozlowski
2024-04-08 14:14 ` Mark Brown
2024-04-08 14:41 ` Théo Lebrun
2024-04-05 15:02 ` [PATCH v2 03/11] spi: cadence-qspi: allow building for MIPS Théo Lebrun
2024-04-05 15:02 ` [PATCH v2 04/11] spi: cadence-qspi: store device data pointer in private struct Théo Lebrun
2024-04-05 15:02 ` [PATCH v2 05/11] spi: cadence-qspi: add FIFO depth detection quirk Théo Lebrun
2024-04-08 14:10 ` Mark Brown
2024-04-08 14:38 ` Théo Lebrun
2024-04-08 14:45 ` Théo Lebrun
2024-04-08 14:51 ` Mark Brown
2024-04-09 10:07 ` Théo Lebrun
2024-04-09 15:51 ` Mark Brown
2024-04-05 15:02 ` [PATCH v2 06/11] spi: cadence-qspi: minimise register accesses on each op if !DTR Théo Lebrun
2024-04-05 15:02 ` [PATCH v2 07/11] spi: cadence-qspi: add no-IRQ mode to indirect reads Théo Lebrun
2024-04-05 15:02 ` [PATCH v2 08/11] spi: cadence-qspi: add early busywait to cqspi_wait_for_bit() Théo Lebrun
2024-04-08 14:16 ` Mark Brown
2024-04-08 14:42 ` Théo Lebrun [this message]
2024-04-08 16:40 ` Mark Brown
2024-04-09 10:09 ` Théo Lebrun
2024-04-05 15:02 ` [PATCH v2 09/11] spi: cadence-qspi: add mobileye,eyeq5-ospi compatible Théo Lebrun
2024-04-05 15:02 ` [PATCH v2 10/11] MIPS: mobileye: eyeq5: Add SPI-NOR controller node Théo Lebrun
2024-04-05 15:02 ` [PATCH v2 11/11] MIPS: mobileye: eyeq5: add octal flash node to eval board DTS Théo Lebrun
2024-04-05 15:30 ` [PATCH v2 00/11] spi: cadence-qspi: add Mobileye EyeQ5 support Théo Lebrun
2024-04-08 17:57 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0ETJXNHOUKQ.C368FEZVM9DD@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vaishnav.a@ti.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).