From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Cuissard Subject: Re: [linux-nfc] [PATCH v3 9/9] NFC: nfcmrvl: update device tree bindings for Marvell NFC Date: Sat, 24 Oct 2015 00:23:57 +0000 Message-ID: References: <1445602986-3254-1-git-send-email-cuissard@marvell.com> <1445602986-3254-10-git-send-email-cuissard@marvell.com> <20151023230034.GA23609@zurbaran.home> <3CAE2505-C17A-4A4F-A222-0F0D814B8491@marvell.com>,<20151024002202.GC23609@zurbaran.home> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20151024002202.GC23609-nKCvNrh56OoJmsy6czSMtA@public.gmane.org> Content-Language: fr-FR Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Samuel Ortiz Cc: Rob Herring , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-nfc-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org" List-Id: devicetree@vger.kernel.org Hi Samuel, > Le 24 oct. 2015 =E0 02:22, Samuel Ortiz a =E9= crit : >=20 > Hi Vincent, >=20 > On Sat, Oct 24, 2015 at 12:15:28AM +0000, Vincent Cuissard wrote: >>>>>> diff --git a/Documentation/devicetree/bindings/net/nfc/nfcmrvl.t= xt b/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt >>>>>> index 41058fc..0f95924 100644 >>>>>> --- a/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt >>>>>> +++ b/Documentation/devicetree/bindings/net/nfc/nfcmrvl.txt >>>>>> @@ -2,9 +2,9 @@ >>>>>>=20 >>>>>> Required properties: >>>>>> - compatible: Should be: >>>>>> - - "mrvl,nfc-uart" for UART devices >>>>>> - - "mrvl,nfc-i2c" for I2C devices >>>>>> - - "mrvl,nfc-spi" for SPI devices >>>>>> + - "marvell,nfc-uart" for UART devices >>>>>> + - "marvell,nfc-i2c" for I2C devices >>>>>> + - "marvell,nfc-spi" for SPI devices >>>>>=20 >>>>> There is no point in changing these and doing so breaks backwards= compatibility. >>>>=20 >>>> There is no break since these 2 drivers are new. In the same patch= set I first set mrvl and replace it to marvell since I figured out that= this is the name for all other Marvell drivers. >>> I agree the i2c and spi drivers are new, but not the uart one. >>> That one should be supported in a backward compatible way. >>=20 >> Since our chips are not sold through distributors yet I know that no= one is using this UART driver yet. >>=20 >> That's why I changed this compatible string without any trouble. >>=20 >> If you really want I can keep the compatibility here but it will jus= t add code that will never be used. >>=20 >> As you wish. > I consider a device tree binding as an ABI and I don't think there > should be any exception for breaking a kernel ABI backward > compatibility. Please keep this code in. Ok, I will update this on Monday. Br, --=20 Vincent-- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html