From: "Michael Walle" <mwalle@kernel.org>
To: "Erez" <erezgeva2@gmail.com>
Cc: "Conor Dooley" <conor@kernel.org>,
"Erez Geva" <erezgeva@nwtime.org>,
<linux-mtd@lists.infradead.org>,
"Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Pratyush Yadav" <pratyush@kernel.org>,
<linux-kernel@vger.kernel.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
<devicetree@vger.kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Subject: Re: [PATCH 3/4] dt-bindings: mtd: macronix,mx25l12833f: add SPI-NOR chip
Date: Fri, 28 Jun 2024 18:51:08 +0200 [thread overview]
Message-ID: <D2BT0DT9UQ66.2L497FSY7GMAL@kernel.org> (raw)
In-Reply-To: <CANeKEMMrXK=mw=n=9DuTnprkTs3ct446oaC2QTJyst8Nd+D6rw@mail.gmail.com>
On Fri Jun 28, 2024 at 6:30 PM CEST, Erez wrote:
> I do not know why they decided to use the same JEDEC ID for two chips.
> Your guess is as good as mine.
That's a common pattern and we try hard to figure that out during
probe time instead of hardcoding it. E.g. by looking at the SFDP
data. Have a look at various fixups in drivers/mtd/spi-nor/.
compatibles are really the last resort to distinguish flash devices.
Next time, please mention such information in the commit message,
please.
Also please have a look at
https://docs.kernel.org/driver-api/mtd/spi-nor.html
-michael
next prev parent reply other threads:[~2024-06-28 16:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 14:03 [PATCH 0/4] Add support for SPI-NOR Macronix OTP Erez Geva
2024-06-28 14:03 ` [PATCH 1/4] Add generic functions for accessing the SPI-NOR chip Erez Geva
2024-06-28 14:39 ` Tudor Ambarus
2024-06-28 14:03 ` [PATCH 2/4] Add support for SPI-NOR Macronix OTP Erez Geva
2024-06-28 14:03 ` [PATCH 3/4] dt-bindings: mtd: macronix,mx25l12833f: add SPI-NOR chip Erez Geva
2024-06-28 15:57 ` Conor Dooley
2024-06-28 16:04 ` Michael Walle
[not found] ` <CANeKEMMrXK=mw=n=9DuTnprkTs3ct446oaC2QTJyst8Nd+D6rw@mail.gmail.com>
2024-06-28 16:44 ` Erez
2024-06-28 16:51 ` Michael Walle [this message]
2024-06-28 17:17 ` Erez
2024-06-28 17:45 ` Michael Walle
2024-06-28 19:31 ` Erez
2024-06-28 14:03 ` [PATCH 4/4] Add Macronix SPI-NOR mx25l12833f with OTP Erez Geva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2BT0DT9UQ66.2L497FSY7GMAL@kernel.org \
--to=mwalle@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=erezgeva2@gmail.com \
--cc=erezgeva@nwtime.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).