From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FAFB1534E9; Mon, 7 Oct 2024 07:50:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728287445; cv=none; b=RivKZH2QRxRmOe497rtdFj5lO1QIfDC8JDUwb4PDvjv5tNaRLbHkoT7VUI/ZQcJqGwfcW+AgQ4UUjApxyGhu6ZVJCkrqscRBUZ2DfNN6Q+MYI8b/cTwH9kNNbUlr5Nl50FgjcKbwVb6P2D5gvXeeBpLzmXhaXHirlYGxAsOPhEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728287445; c=relaxed/simple; bh=LZwLhPcihpVwhqUd44bHekSn+fvPmdtdSBIxwelAqgU=; h=Content-Type:Date:Message-Id:Subject:Cc:From:To:References: In-Reply-To; b=qAAYwWiFCDpi6Q5WbGcuQYI1xqxhdvRk95W29Z9aaV+jMIOszyt9d7ChKLokfpMBMAJgf4Curf06MHV51aGpr/aCVhhn5khdLmMlREYvOVruHflKHcaIsUN8LpoPXHYX6fBIyfTcM/BGenMPePmZ66ZBji4QPhx7+hVKr+J2LFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GK8EWprj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GK8EWprj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 557DBC4CEC6; Mon, 7 Oct 2024 07:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728287443; bh=LZwLhPcihpVwhqUd44bHekSn+fvPmdtdSBIxwelAqgU=; h=Date:Subject:Cc:From:To:References:In-Reply-To:From; b=GK8EWprjujC9Tfvzj6WVPbnrV2bF6TKHAk2EAEqU41FrNmpVkNiQZ4sJBWYAqDWEF 0KB9XVHtxTc7/rv21PlOB0YBw46iOu9cX+WnSX79m0cVdJgDQ84i4HRjL0c6vmxOuX DQr5O05dm1qtHgasFGHJk5B/52rCgL68ohQme0HRkOBqeYUwn7zHI6BReTf+NX3FI+ vbcHvcuquWjy1orykoi97YVXsCVD3t/5RvJ65AYRqu8YmjgwryBldzdRVQg4aT1fP7 n0VxLzbNachbfkfInMr9jW5/2OIYYy3d+CZRgu0U/hVziwX9tbzzCHckyPYWvm1K7w 1/CDpp+F5UmLA== Content-Type: multipart/signed; boundary=4f89559e3e3addf49573992635c3f51e2eb8df6bf427dc56eda58fc4e794; micalg=pgp-sha384; protocol="application/pgp-signature" Date: Mon, 07 Oct 2024 09:50:39 +0200 Message-Id: Subject: Re: [PATCH v2 2/3] mtd: spi-nor: support vcc-supply regulator Cc: "Rob Herring" , "Conor Dooley" , "Fabio Estevam" , "Vignesh Raghavendra" , , , "Richard Weinberger" , "Sascha Hauer" , "Marco Felsch" , , "Tudor Ambarus" , , , "Pengutronix Kernel Team" , "Miquel Raynal" , "Krzysztof Kozlowski" , "Shawn Guo" , "Peng Fan" , "Pratyush Yadav" From: "Michael Walle" To: "Marc Kleine-Budde" , "Peng Fan (OSS)" X-Mailer: aerc 0.16.0 References: <20240930-spi-v2-0-ed7f6bcbe0df@nxp.com> <20240930-spi-v2-2-ed7f6bcbe0df@nxp.com> <20240930-wonderful-wealthy-aardwolf-b455d6-mkl@pengutronix.de> <20240930-amaranth-stallion-of-fantasy-67701d-mkl@pengutronix.de> In-Reply-To: <20240930-amaranth-stallion-of-fantasy-67701d-mkl@pengutronix.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: --4f89559e3e3addf49573992635c3f51e2eb8df6bf427dc56eda58fc4e794 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi, > > > + ret =3D devm_regulator_get_enable(dev, "vcc"); > > > + if (ret) > > > + return ret; > > > + > >=20 > > What happens if the SPI-NOR doesn't have a "vcc" regulator? > > ...the SPI-NOR will use the dummy regulator. Which then prints a warning "using dummy regulator". Is that the usual way to go? I mean the regulator is actually mandatory because it is the main voltage rail for the flash. To get rid of the warning one can add a fixed-regulator (which is correct anyway). But OTOH, the device tree lists it as optional (marking it as required isn't an option either because virtually all device trees won't have that property). -michael --4f89559e3e3addf49573992635c3f51e2eb8df6bf427dc56eda58fc4e794 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKgEABMJADAWIQTIVZIcOo5wfU/AngkSJzzuPgIf+AUCZwOS0BIcbXdhbGxlQGtl cm5lbC5vcmcACgkQEic87j4CH/itIQGAlVlJTTCQIXmqzui5WhdsuBn8I74X+Pl7 YIOZ5srEjl+s75tdMuZ79ixoF50nGGX2AXwJv/geIp9+ua4N3snMvPChaw43SAbu nfe1itE/wQHdobQbIS5fXEZsl0asg29UJfg= =bBef -----END PGP SIGNATURE----- --4f89559e3e3addf49573992635c3f51e2eb8df6bf427dc56eda58fc4e794--