Re: [PATCH 2/3] arm64: dts: rockchip: Prepare RK356x SoC dtsi files for per-variant OPPs

["Diederik de Haas" <didi.debian@cknow.org>]

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

Hi Dragan,

On Sat Oct 12, 2024 at 9:41 PM CEST, Diederik de Haas wrote:
> On Sat Oct 12, 2024 at 7:04 PM CEST, Dragan Simic wrote:
> >  
> > -&pipegrf {
> > -	compatible = "rockchip,rk3566-pipe-grf", "syscon";
>
> This seems unrelated?
>
> > +&cpu0 {
> > +	operating-points-v2 = <&cpu0_opp_table>;
> >  };
> >  
> > -&power {
> > -	power-domain@RK3568_PD_PIPE {
> > -		reg = <RK3568_PD_PIPE>;
> > -		clocks = <&cru PCLK_PIPE>;
> > -		pm_qos = <&qos_pcie2x1>,
> > -			 <&qos_sata1>,
> > -			 <&qos_sata2>,
> > -			 <&qos_usb3_0>,
> > -			 <&qos_usb3_1>;
> > -		#power-domain-cells = <0>;
> > -	};
>
> This seems unrelated to me and possibly a functional change?
> If this was intended, then a description in the commit message would be
> nice why this is appropriate and possibly moved to a separate patch?
>
> > +&cpu1 {
> > +	operating-points-v2 = <&cpu0_opp_table>;
> > +};
> > +
> > +&cpu2 {
> > +	operating-points-v2 = <&cpu0_opp_table>;
> >  };
> >  
> > -&usb_host0_xhci {
> > -	phys = <&usb2phy0_otg>;
> > -	phy-names = "usb2-phy";
> > -	extcon = <&usb2phy0>;
> > -	maximum-speed = "high-speed";
>
> This also looks unrelated and a functional change?
>
> > +&cpu3 {
> > +	operating-points-v2 = <&cpu0_opp_table>;
> >  };
> >  
> > -&vop {
> > -	compatible = "rockchip,rk3566-vop";
>
> This also looks unrelated?

It turns out I was wrong.
The elements I thought were removed, aren't removed.

Sorry for the noise.

Diederik

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]