From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1987416F0E8 for ; Sat, 19 Oct 2024 18:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729361362; cv=none; b=cTFWahYGxoaMOdzGULlE76jXj71MIPgkUY4PwSo0ZWc3o97w6V18GXvRSn2kZSMVjudbZPHRAv7RWqJ0uGAdD6lUSy2e6oZ9G/PxVH32s2M+iGsNtx52hPOlC7xRsrD8qaa4NX5X2gKppyQJcFaTYPJ06n7nS2aMtTOw25+WlHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729361362; c=relaxed/simple; bh=EWobNxr/fu8G78jXjGTzejsIyUdAaSkwE4u8iTfF/nc=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=c7mDnxIGIPoVchjSywPmcgnyYcoWd3aCovuUCax7mxjViI28nsXgOC4wTz2zyEo8GX1hRdQ6xiNolMkgF2VyC0lB838aY+uI/A2SI4KdvbjoYzn8pHOjiCqLiz5cC7KYMhPlfyaqAv2+WId2Jc1p4Y0QHAAa32FX5Sx+H9BbC60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=AQsNfew+; arc=none smtp.client-ip=95.215.58.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="AQsNfew+" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1729361355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f3RtjINZGSgrKRy2wNDqwWrIHrIIPJ53FJ8P+x6DkhI=; b=AQsNfew+K6F+CLgKgr50utpQXBypfTUxchrOeI73zMAcWok/7hgMhCo6fub0UnDP6iuk5d ZutrSF4lZ5udnjXawQlruQMscn5kBPnMmo1oBfOpCu+wW68/QujudwXWre10YG4AD1vj8j Cz5ZOjRz+xwUEhUCEYXsnPJme9hUa3DABRy4c7ypl0BcmJAzWRPT7n3udouF89ohdHBCVC i4/6mGEHDVrbMtmh/v6HKjrwxqyfkT3jfGi8R99cBpi+eAxk9HRv0kFBqsBeqoITrqq1ya 3OjTbRJemUVysfTQbgYf1LvJ8i1Af0xMBNNQFjB2gxCVywk8mf1pyN/Ye/Y5nA== Content-Type: multipart/signed; boundary=eb9158f3fd3022c747c09e202d1d0a175e416ede785f1ca7d155a4b18fff; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Sat, 19 Oct 2024 20:09:02 +0200 Message-Id: Cc: , , , , , , Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Prepare RK356x SoC dtsi files for per-variant OPPs X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Dragan Simic" , References: In-Reply-To: X-Migadu-Flow: FLOW_OUT --eb9158f3fd3022c747c09e202d1d0a175e416ede785f1ca7d155a4b18fff Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Dragan, On Sat Oct 12, 2024 at 9:41 PM CEST, Diederik de Haas wrote: > On Sat Oct 12, 2024 at 7:04 PM CEST, Dragan Simic wrote: > > =20 > > -&pipegrf { > > - compatible =3D "rockchip,rk3566-pipe-grf", "syscon"; > > This seems unrelated? > > > +&cpu0 { > > + operating-points-v2 =3D <&cpu0_opp_table>; > > }; > > =20 > > -&power { > > - power-domain@RK3568_PD_PIPE { > > - reg =3D ; > > - clocks =3D <&cru PCLK_PIPE>; > > - pm_qos =3D <&qos_pcie2x1>, > > - <&qos_sata1>, > > - <&qos_sata2>, > > - <&qos_usb3_0>, > > - <&qos_usb3_1>; > > - #power-domain-cells =3D <0>; > > - }; > > This seems unrelated to me and possibly a functional change? > If this was intended, then a description in the commit message would be > nice why this is appropriate and possibly moved to a separate patch? > > > +&cpu1 { > > + operating-points-v2 =3D <&cpu0_opp_table>; > > +}; > > + > > +&cpu2 { > > + operating-points-v2 =3D <&cpu0_opp_table>; > > }; > > =20 > > -&usb_host0_xhci { > > - phys =3D <&usb2phy0_otg>; > > - phy-names =3D "usb2-phy"; > > - extcon =3D <&usb2phy0>; > > - maximum-speed =3D "high-speed"; > > This also looks unrelated and a functional change? > > > +&cpu3 { > > + operating-points-v2 =3D <&cpu0_opp_table>; > > }; > > =20 > > -&vop { > > - compatible =3D "rockchip,rk3566-vop"; > > This also looks unrelated? It turns out I was wrong. The elements I thought were removed, aren't removed. Sorry for the noise. Diederik --eb9158f3fd3022c747c09e202d1d0a175e416ede785f1ca7d155a4b18fff Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZxP1wwAKCRDXblvOeH7b bnomAQCauVO5HYPsaXNdYa5Tz50X1ZlJC7CDUvnlwWrQif3qFQEApyYcsmXRi4Xv ePPHwirwTWwZXt6w4Rr5ksGu3kE2Rg4= =NC6L -----END PGP SIGNATURE----- --eb9158f3fd3022c747c09e202d1d0a175e416ede785f1ca7d155a4b18fff--