From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E24B863D for ; Wed, 4 Dec 2024 10:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733309309; cv=none; b=by/p005pXNLlvJfpuy33mOd4khZ7qAQC1SqZGgZaEX7APb/m09pFw9XI0kL0ahUjRn3GgaXvds5gk8+MJFYfmo7eOieRKkzLw3Q+sFBSyshi4AqyZg/Pqllj396bWZ7B9ZYB2jOkWnOf0XXJsdcC08OZTNpKXw0lAlO5Hr3FGTY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733309309; c=relaxed/simple; bh=nMKJotmOfJV34Qf8Uaok9S3w0cWQJ2lUaPe4ebMComY=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=tuGk/g0W3NHx9RDw5mV8Qjf6/I+6Lw9O0KLMae33H78Z2QKdxnlw3uS4w18ZM3ySjia7kgnB2yffnZiNAtgzGtjwFfdnQZdPaicensyCAYrkfaKIj6S4Dv0m3R/h/d+vhgNH76j5PZ83/OH4BuCzPyF1DlxBWuU6WqUdwd1Yb1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=qLo3qT2+; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="qLo3qT2+" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1733309293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O2UKodnZ8Rm7sgDDRiSGv7A9dpUqJ+j48TEG+riJO/c=; b=qLo3qT2+panflIVAmf4iYX0CPTVCzg9EkWVcKb7KeKgZnE+P9MMOqfsJ+LFr0ZL1GWnZSK R0habEwAovGA6gOKjDgW0+C6xVjiibx1RNax0qkInVOtt2NKjJomzme3h37i++IiO+TML3 6oH0x6pXWYEdza9HGISMYaq0yPW8pF5oXpDuu4qyHAd33FR1/hCIhZwu89htbcM0LsV+Ux j0D01g+ub5DCmJSA2NSVja29btWrot8o6MN5pzSVlbNGukeKV7czBY0F7pksj+1yTEoxGv 2+GedYEZFSrYlyePSSgQQzVY6tIzdBh599PkxfnPWGGiRAu3YFZwCSUMSmXMcQ== Content-Type: multipart/signed; boundary=36be8bfcf2ccc3f593d537c5169e7561860be4acb341ccb6b71acfde7e94; micalg=pgp-sha256; protocol="application/pgp-signature" Date: Wed, 04 Dec 2024 11:48:02 +0100 Message-Id: Cc: , , , , , , , , , , , , , , , , , , , "Kever Yang" , "Heiko Stuebner" , "Daniel Semkowicz" Subject: Re: [PATCH v3 3/3] drm/rockchip: Add MIPI DSI2 glue driver for RK3588 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Heiko Stuebner" References: <20241203165450.1501219-1-heiko@sntech.de> <20241203165450.1501219-4-heiko@sntech.de> In-Reply-To: X-Migadu-Flow: FLOW_OUT --36be8bfcf2ccc3f593d537c5169e7561860be4acb341ccb6b71acfde7e94 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 If there's going to be another version (to fix this) ... On Wed Dec 4, 2024 at 3:16 AM CET, Kever Yang wrote: > On 2024/12/4 00:54, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > This adds the glue code for the MIPI DSI2 bridge on Rockchip SoCs and > > enables its use on the RK3588. > > > > Right now the DSI2 controller is always paired with a DC-phy based on a > > Samsung IP, so the interface values are set statically for now. > > This stays true for the upcoming RK3576 as well. > > > > Tested-by: Daniel Semkowicz > > Signed-off-by: Heiko Stuebner > > --- > > drivers/gpu/drm/rockchip/Kconfig | 10 + > > drivers/gpu/drm/rockchip/Makefile | 1 + > > .../gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c | 524 +++++++++++++++++= + > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 + > > drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + > > 5 files changed, 538 insertions(+) > > create mode 100644 drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c > > > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchi= p/Kconfig > > index 448fadd4ba15..84af423b7f90 100644 > > --- a/drivers/gpu/drm/rockchip/Kconfig > > +++ b/drivers/gpu/drm/rockchip/Kconfig > > @@ -10,6 +10,7 @@ config DRM_ROCKCHIP > > select DRM_DW_HDMI if ROCKCHIP_DW_HDMI > > select DRM_DW_HDMI_QP if ROCKCHIP_DW_HDMI_QP > > select DRM_DW_MIPI_DSI if ROCKCHIP_DW_MIPI_DSI > > + select DRM_DW_MIPI_DSI2 if ROCKCHIP_DW_MIPI_DSI2 > > select GENERIC_PHY if ROCKCHIP_DW_MIPI_DSI > > select GENERIC_PHY_MIPI_DPHY if ROCKCHIP_DW_MIPI_DSI > > select SND_SOC_HDMI_CODEC if ROCKCHIP_CDN_DP && SND_SOC > > @@ -81,6 +82,15 @@ config ROCKCHIP_DW_MIPI_DSI > > enable MIPI DSI on RK3288 or RK3399 based SoC, you should > > select this option. > > =20 > > +config ROCKCHIP_DW_MIPI_DSI2 > > + bool "Rockchip specific extensions for Synopsys DW MIPI DSI2" > > + select GENERIC_PHY_MIPI_DPHY > > + help > > + This selects support for Rockchip SoC specific extensions > > + for the Synopsys DesignWare dsi driver. If you want to ... could you then also s/dsi/DSI/ ? Cheers, Diederik > > + enable MIPI DSI on RK3576 or RK3588 based SoC, you should > > + select this option. > > + > > config ROCKCHIP_INNO_HDMI > > bool "Rockchip specific extensions for Innosilicon HDMI" > > select DRM_DISPLAY_HDMI_HELPER > > diff --git a/drivers/gpu/drm/rockchip/Makefile b/drivers/gpu/drm/rockch= ip/Makefile > > index 3eab662a5a1d..2b867cebbc12 100644 > > --- a/drivers/gpu/drm/rockchip/Makefile > > +++ b/drivers/gpu/drm/rockchip/Makefile > > @@ -13,6 +13,7 @@ rockchipdrm-$(CONFIG_ROCKCHIP_CDN_DP) +=3D cdn-dp-cor= e.o cdn-dp-reg.o > > rockchipdrm-$(CONFIG_ROCKCHIP_DW_HDMI) +=3D dw_hdmi-rockchip.o > > rockchipdrm-$(CONFIG_ROCKCHIP_DW_HDMI_QP) +=3D dw_hdmi_qp-rockchip.o > > rockchipdrm-$(CONFIG_ROCKCHIP_DW_MIPI_DSI) +=3D dw-mipi-dsi-rockchip.= o > > +rockchipdrm-$(CONFIG_ROCKCHIP_DW_MIPI_DSI2) +=3D dw-mipi-dsi2-rockchip= .o > > rockchipdrm-$(CONFIG_ROCKCHIP_INNO_HDMI) +=3D inno_hdmi.o > > rockchipdrm-$(CONFIG_ROCKCHIP_LVDS) +=3D rockchip_lvds.o > > rockchipdrm-$(CONFIG_ROCKCHIP_RGB) +=3D rockchip_rgb.o > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c b/drivers= /gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c > > new file mode 100644 > > index 000000000000..55eed4001634 > > --- /dev/null > > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi2-rockchip.c > > @@ -0,0 +1,524 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Copyright (C) 2024 Rockchip Electronics Co.Ltd > This should be: > > Rockchip Electronics Co., Ltd. > > This typo is from vendor kernel, we will correct all this kind of issue l= ocally, > and Andy is going to correct other files in drm for mainline kernel. > > Thanks, > - Kever --36be8bfcf2ccc3f593d537c5169e7561860be4acb341ccb6b71acfde7e94 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZ1AzZgAKCRDXblvOeH7b bgWNAQC3fSnJVdLSgG4VTa6DlS3SopUVzVFSbfEGiC729h16vAEAwIBqQFd3xgCB KHlaIkQrEF/mSaPEoy27gQHJra96XQU= =cYSZ -----END PGP SIGNATURE----- --36be8bfcf2ccc3f593d537c5169e7561860be4acb341ccb6b71acfde7e94--