* [PATCH v2 0/2] Add support for Xiaomi Mi TV Stick
@ 2025-02-01 19:30 Ferass El Hafidi
2025-02-01 19:30 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add S805Y and " Ferass El Hafidi
2025-02-01 19:30 ` [PATCH v2 2/2] arm64: dts: amlogic: add support for xiaomi-aquaman/Mi " Ferass El Hafidi
0 siblings, 2 replies; 8+ messages in thread
From: Ferass El Hafidi @ 2025-02-01 19:30 UTC (permalink / raw)
To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-amlogic
Cc: linux-arm-kernel, devicetree, linux-kernel, funderscore,
~postmarketos/upstreaming, Artur Weber, Karl Chan,
Christian Hewitt
This patch series aims to add initial support for the Xiaomi Mi TV
Stick.
Xiaomi Mi TV Stick is a small Amlogic-based Android TV stick released in
2020, and known as `xiaomi-aquaman` internally (in the downstream kernel,
u-boot, ...)
Its specifications are as follows:
* Amlogic S805Y SoC (believed to be mostly identical to S805X)
* 8 GB eMMC
* 1 GB of RAM
* Android TV 9, upgradable to Android TV 10
There are multiple variants:
* 1. Green PCB, manufactured in 2020, known UART pinout (helpfully
labeled on the board)
* 2. Blue PCB, not much documentation about it, presumably manufactured
between 2021 and 2023
* 3. Green PCB, manufactured in 2023, known UART pinout, some layout
changes compared to the 2020 variant
Among these variants, there are many boards using multiple different
Wi-Fi chips. Supporting all of them is out of scope for this patch
series.
As of the time of writing this has only been tested on the 3rd variant.
It is believed that software-wise all three work mostly the same (if we
don't count Wi-Fi), but testing on the other variants would still be
appreciated.
The devicetree is based on the Amlogic P241 DTS.
Changes since v1 [1]:
* remove useless nodes: cvbs-connector, ethmac, internal_phy, ir
* add `amlogic,s805y` DT binding section
* add S805Y dtsi: meson-gxl-s805y.dtsi
* adjust DT `model` to "Xiaomi Mi TV Stick (Aquaman)"
* explain the changes being done a bit more in the commit message for
the DT patch
* drop `clocks` and `clock-names` from pwm_ef (background: [2])
* change sound `model` to "XIAOMI-AQUAMAN"
[1]: https://lore.kernel.org/all/20250131200319.19996-1-funderscore@postmarketos.org/
[2]: https://lore.kernel.org/linux-amlogic/20241227212514.1376682-1-martin.blumenstingl@googlemail.com/
Ferass El Hafidi (2):
dt-bindings: arm: amlogic: add S805Y and Mi TV Stick
arm64: dts: amlogic: add support for xiaomi-aquaman/Mi TV Stick
.../devicetree/bindings/arm/amlogic.yaml | 7 +
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../meson-gxl-s805y-xiaomi-aquaman.dts | 288 ++++++++++++++++++
.../boot/dts/amlogic/meson-gxl-s805y.dtsi | 10 +
4 files changed, 306 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s805y-xiaomi-aquaman.dts
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s805y.dtsi
--
2.47.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] dt-bindings: arm: amlogic: add S805Y and Mi TV Stick
2025-02-01 19:30 [PATCH v2 0/2] Add support for Xiaomi Mi TV Stick Ferass El Hafidi
@ 2025-02-01 19:30 ` Ferass El Hafidi
2025-02-02 13:54 ` Krzysztof Kozlowski
2025-02-01 19:30 ` [PATCH v2 2/2] arm64: dts: amlogic: add support for xiaomi-aquaman/Mi " Ferass El Hafidi
1 sibling, 1 reply; 8+ messages in thread
From: Ferass El Hafidi @ 2025-02-01 19:30 UTC (permalink / raw)
To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-amlogic
Cc: linux-arm-kernel, devicetree, linux-kernel, funderscore,
~postmarketos/upstreaming, Artur Weber, Karl Chan,
Christian Hewitt
From: Ferass El Hafidi <funderscore@postmarketos.org>
Add support for the Amlogic S805Y SoC and the Xiaomi Mi TV Stick (aka.
xiaomi-aquaman). The S805Y is very similar to the S805X, with just a
few minor differences.
Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
---
Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
index 0647851ae..3403362e0 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.yaml
+++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
@@ -73,6 +73,13 @@ properties:
- const: amlogic,s805x
- const: amlogic,meson-gxl
+ - description: Boards with the Amlogic Meson GXL S805Y SoC
+ items:
+ - enum:
+ - xiaomi,aquaman
+ - const: amlogic,s805y
+ - const: amlogic,meson-gxl
+
- description: Boards with the Amlogic Meson GXL S905W SoC
items:
- enum:
--
2.47.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] arm64: dts: amlogic: add support for xiaomi-aquaman/Mi TV Stick
2025-02-01 19:30 [PATCH v2 0/2] Add support for Xiaomi Mi TV Stick Ferass El Hafidi
2025-02-01 19:30 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add S805Y and " Ferass El Hafidi
@ 2025-02-01 19:30 ` Ferass El Hafidi
1 sibling, 0 replies; 8+ messages in thread
From: Ferass El Hafidi @ 2025-02-01 19:30 UTC (permalink / raw)
To: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-amlogic
Cc: linux-arm-kernel, devicetree, linux-kernel, funderscore,
~postmarketos/upstreaming, Artur Weber, Karl Chan,
Christian Hewitt
From: Ferass El Hafidi <funderscore@postmarketos.org>
Xiaomi Mi TV Stick is a small Amlogic-based Android TV stick released in
2020. It is known as `xiaomi-aquaman` internally. Specifications:
* Amlogic S805Y SoC
* Android TV 9, upgradable to Android TV 10
* 8 GB eMMC
* 1 GB of RAM
The devicetree is based on p241's DT, with some changes to better match
the Mi TV Stick:
* there is no Ethernet port, no IR, no CVBS connector on the stick
* a white LED is present
* adjust memory to have 1 GB of RAM available
Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
---
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../meson-gxl-s805y-xiaomi-aquaman.dts | 288 ++++++++++++++++++
.../boot/dts/amlogic/meson-gxl-s805y.dtsi | 10 +
3 files changed, 299 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s805y-xiaomi-aquaman.dts
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s805y.dtsi
diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index 2fbda8419..0921707f1 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -49,6 +49,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-wetek-hub.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-wetek-play2.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-libretech-ac.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-p241.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805y-xiaomi-aquaman.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-libretech-pc.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-mecool-kii-pro.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s805y-xiaomi-aquaman.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s805y-xiaomi-aquaman.dts
new file mode 100644
index 000000000..c29cc01d8
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s805y-xiaomi-aquaman.dts
@@ -0,0 +1,288 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2025 Ferass El Hafidi <funderscore@postmarketos.org>
+ * Based on meson-gxl-s805x-p241.dtb:
+ * - Copyright (c) 2018 BayLibre, SAS.
+ * Author: Neil Armstrong <narmstrong@baylibre.com>
+ * Author: Jerome Brunet <jbrunet@baylibre.com>
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/sound/meson-aiu.h>
+
+#include "meson-gxl-s805y.dtsi"
+
+/ {
+ compatible = "xiaomi,aquaman", "amlogic,s805y", "amlogic,meson-gxl";
+ model = "Xiaomi Mi TV Stick (aquaman)";
+
+ aliases {
+ serial0 = &uart_AO;
+ serial1 = &uart_A;
+ };
+
+ au2: analog-amplifier {
+ compatible = "simple-audio-amplifier";
+ sound-name-prefix = "AU2";
+ VCC-supply = <&vcc_5v>;
+ enable-gpios = <&gpio GPIOH_5 GPIO_ACTIVE_HIGH>;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ emmc_pwrseq: emmc-pwrseq {
+ compatible = "mmc-pwrseq-emmc";
+ reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>;
+ };
+
+ hdmi-connector {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_connector_in: endpoint {
+ remote-endpoint = <&hdmi_tx_tmds_out>;
+ };
+ };
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ led-white {
+ color = <LED_COLOR_ID_WHITE>;
+ function = LED_FUNCTION_POWER;
+ gpios = <&gpio GPIODV_24 GPIO_ACTIVE_HIGH>;
+ default-state = "on";
+ panic-indicator;
+ };
+ };
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x0 0x0 0x40000000>;
+ };
+
+ vddio_boot: regulator-vddio-boot {
+ compatible = "regulator-fixed";
+ regulator-name = "VDDIO_BOOT";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ vddao_3v3: regulator-vddao-3v3 {
+ compatible = "regulator-fixed";
+ regulator-name = "VDDAO_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ vddio_ao18: regulator-vddio-ao18 {
+ compatible = "regulator-fixed";
+ regulator-name = "VDDIO_AO18";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ vcc_3v3: regulator-vcc-3v3 {
+ compatible = "regulator-fixed";
+ regulator-name = "VCC_3V3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ vcc_5v: regulator-vcc-5v {
+ compatible = "regulator-fixed";
+ regulator-name = "VCC_5V";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ };
+
+ emmc_pwrseq: emmc-pwrseq {
+ compatible = "mmc-pwrseq-emmc";
+ reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>;
+ };
+
+ wifi32k: wifi32k {
+ compatible = "pwm-clock";
+ #clock-cells = <0>;
+ clock-frequency = <32768>;
+ pwms = <&pwm_ef 0 30518 0>; /* PWM_E at 32.768KHz */
+ };
+
+ sdio_pwrseq: sdio-pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>;
+ clocks = <&wifi32k>;
+ clock-names = "ext_clock";
+ };
+
+ sound {
+ compatible = "amlogic,gx-sound-card";
+ model = "XIAOMI-AQUAMAN";
+ audio-aux-devs = <&au2>;
+ audio-widgets = "Line", "Lineout";
+ audio-routing = "AU2 INL", "ACODEC LOLN",
+ "AU2 INR", "ACODEC LORN",
+ "Lineout", "AU2 OUTL",
+ "Lineout", "AU2 OUTR";
+ clocks = <&clkc CLKID_MPLL0>,
+ <&clkc CLKID_MPLL1>,
+ <&clkc CLKID_MPLL2>;
+
+ assigned-clocks = <&clkc CLKID_MPLL0>,
+ <&clkc CLKID_MPLL1>,
+ <&clkc CLKID_MPLL2>;
+ assigned-clock-parents = <0>, <0>, <0>;
+ assigned-clock-rates = <294912000>,
+ <270950400>,
+ <393216000>;
+
+ dai-link-0 {
+ sound-dai = <&aiu AIU_CPU CPU_I2S_FIFO>;
+ };
+
+ dai-link-1 {
+ sound-dai = <&aiu AIU_CPU CPU_I2S_ENCODER>;
+ dai-format = "i2s";
+ mclk-fs = <256>;
+
+ codec-0 {
+ sound-dai = <&aiu AIU_HDMI CTRL_I2S>;
+ };
+
+ codec-1 {
+ sound-dai = <&aiu AIU_ACODEC CTRL_I2S>;
+ };
+ };
+
+ dai-link-2 {
+ sound-dai = <&aiu AIU_HDMI CTRL_OUT>;
+
+ codec-0 {
+ sound-dai = <&hdmi_tx>;
+ };
+ };
+
+ dai-link-3 {
+ sound-dai = <&aiu AIU_ACODEC CTRL_OUT>;
+
+ codec-0 {
+ sound-dai = <&acodec>;
+ };
+ };
+ };
+};
+
+&acodec {
+ AVDD-supply = <&vddio_ao18>;
+ status = "okay";
+};
+
+&aiu {
+ status = "okay";
+};
+
+&cec_AO {
+ status = "okay";
+ pinctrl-0 = <&ao_cec_pins>;
+ pinctrl-names = "default";
+ hdmi-phandle = <&hdmi_tx>;
+};
+
+&hdmi_tx {
+ status = "okay";
+ pinctrl-0 = <&hdmi_hpd_pins>, <&hdmi_i2c_pins>;
+ pinctrl-names = "default";
+ hdmi-supply = <&vcc_5v>;
+};
+
+&hdmi_tx_tmds_port {
+ hdmi_tx_tmds_out: endpoint {
+ remote-endpoint = <&hdmi_connector_in>;
+ };
+};
+
+&saradc {
+ status = "okay";
+ vref-supply = <&vddio_ao18>;
+};
+
+/* Wireless SDIO Module */
+&sd_emmc_a {
+ status = "disabled";
+ pinctrl-0 = <&sdio_pins>;
+ pinctrl-1 = <&sdio_clk_gate_pins>;
+ pinctrl-names = "default", "clk-gate";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ bus-width = <4>;
+ cap-sd-highspeed;
+ max-frequency = <50000000>;
+
+ non-removable;
+ disable-wp;
+
+ /* WiFi firmware requires power to be kept while in suspend */
+ keep-power-in-suspend;
+
+ mmc-pwrseq = <&sdio_pwrseq>;
+
+ vmmc-supply = <&vddao_3v3>;
+ vqmmc-supply = <&vddio_boot>;
+};
+
+/* eMMC */
+&sd_emmc_c {
+ status = "okay";
+ pinctrl-0 = <&emmc_pins>, <&emmc_ds_pins>;
+ pinctrl-1 = <&emmc_clk_gate_pins>;
+ pinctrl-names = "default", "clk-gate";
+
+ bus-width = <8>;
+ cap-mmc-highspeed;
+ max-frequency = <200000000>;
+ non-removable;
+ disable-wp;
+ mmc-ddr-1_8v;
+ mmc-hs200-1_8v;
+
+ mmc-pwrseq = <&emmc_pwrseq>;
+ vmmc-supply = <&vcc_3v3>;
+ vqmmc-supply = <&vddio_boot>;
+};
+
+&pwm_ef {
+ status = "okay";
+ pinctrl-0 = <&pwm_e_pins>;
+ pinctrl-names = "default";
+};
+
+/* This is connected to the Bluetooth module: */
+&uart_A {
+ status = "okay";
+ pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
+ pinctrl-names = "default";
+ uart-has-rtscts;
+};
+
+&uart_AO {
+ status = "okay";
+ pinctrl-0 = <&uart_ao_a_pins>;
+ pinctrl-names = "default";
+};
+
+&usb {
+ status = "okay";
+ dr_mode = "otg";
+};
+
+&usb2_phy0 {
+ vbus-supply = <&vcc_5v>;
+};
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s805y.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl-s805y.dtsi
new file mode 100644
index 000000000..49b29b71f
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s805y.dtsi
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2025 Ferass El Hafidi <funderscore@postmarketos.org>
+ */
+
+#include "meson-gxl-s805x.dtsi"
+
+/ {
+ compatible = "amlogic,s805y", "amlogic,meson-gxl";
+};
--
2.47.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add S805Y and Mi TV Stick
2025-02-01 19:30 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add S805Y and " Ferass El Hafidi
@ 2025-02-02 13:54 ` Krzysztof Kozlowski
2025-02-02 13:55 ` Ferass El Hafidi
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-02 13:54 UTC (permalink / raw)
To: Ferass El Hafidi
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-amlogic,
linux-arm-kernel, devicetree, linux-kernel,
~postmarketos/upstreaming, Artur Weber, Karl Chan,
Christian Hewitt
On Sat, Feb 01, 2025 at 07:30:43PM +0000, Ferass El Hafidi wrote:
> From: Ferass El Hafidi <funderscore@postmarketos.org>
>
> Add support for the Amlogic S805Y SoC and the Xiaomi Mi TV Stick (aka.
> xiaomi-aquaman). The S805Y is very similar to the S805X, with just a
> few minor differences.
>
> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
Please run checkpatch. You have from/SoB mismatch.
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add S805Y and Mi TV Stick
2025-02-02 13:54 ` Krzysztof Kozlowski
@ 2025-02-02 13:55 ` Ferass El Hafidi
2025-02-02 14:07 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Ferass El Hafidi @ 2025-02-02 13:55 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-amlogic,
linux-arm-kernel, devicetree, linux-kernel,
~postmarketos/upstreaming, Artur Weber, Karl Chan,
Christian Hewitt
Hi,
On Sun Feb 2, 2025 at 1:54 PM UTC, Krzysztof Kozlowski wrote:
> On Sat, Feb 01, 2025 at 07:30:43PM +0000, Ferass El Hafidi wrote:
> > From: Ferass El Hafidi <funderscore@postmarketos.org>
> >
> > Add support for the Amlogic S805Y SoC and the Xiaomi Mi TV Stick (aka.
> > xiaomi-aquaman). The S805Y is very similar to the S805X, with just a
> > few minor differences.
> >
> > Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
>
> Please run checkpatch. You have from/SoB mismatch.
I don't see any mismatch. Maybe it complains because of a spurious
non-breaking space?
Regards.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add S805Y and Mi TV Stick
2025-02-02 13:55 ` Ferass El Hafidi
@ 2025-02-02 14:07 ` Krzysztof Kozlowski
2025-02-02 14:07 ` Ferass El Hafidi
2025-02-03 9:16 ` Ferass El Hafidi
0 siblings, 2 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-02 14:07 UTC (permalink / raw)
To: Ferass El Hafidi
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-amlogic,
linux-arm-kernel, devicetree, linux-kernel,
~postmarketos/upstreaming, Artur Weber, Karl Chan,
Christian Hewitt
On 02/02/2025 14:55, Ferass El Hafidi wrote:
> Hi,
>
> On Sun Feb 2, 2025 at 1:54 PM UTC, Krzysztof Kozlowski wrote:
>> On Sat, Feb 01, 2025 at 07:30:43PM +0000, Ferass El Hafidi wrote:
>>> From: Ferass El Hafidi <funderscore@postmarketos.org>
>>>
>>> Add support for the Amlogic S805Y SoC and the Xiaomi Mi TV Stick (aka.
>>> xiaomi-aquaman). The S805Y is very similar to the S805X, with just a
>>> few minor differences.
>>>
>>> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
>>
>> Please run checkpatch. You have from/SoB mismatch.
>
> I don't see any mismatch. Maybe it complains because of a spurious
> non-breaking space?
>
Could be, no clue. I copied them to editor and it also sees mismatch -
both entries just do not match.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add S805Y and Mi TV Stick
2025-02-02 14:07 ` Krzysztof Kozlowski
@ 2025-02-02 14:07 ` Ferass El Hafidi
2025-02-03 9:16 ` Ferass El Hafidi
1 sibling, 0 replies; 8+ messages in thread
From: Ferass El Hafidi @ 2025-02-02 14:07 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-amlogic,
linux-arm-kernel, devicetree, linux-kernel,
~postmarketos/upstreaming, Artur Weber, Karl Chan,
Christian Hewitt
On Sun Feb 2, 2025 at 2:07 PM UTC, Krzysztof Kozlowski wrote:
> On 02/02/2025 14:55, Ferass El Hafidi wrote:
> > Hi,
> >
> > On Sun Feb 2, 2025 at 1:54 PM UTC, Krzysztof Kozlowski wrote:
> >> On Sat, Feb 01, 2025 at 07:30:43PM +0000, Ferass El Hafidi wrote:
> >>> From: Ferass El Hafidi <funderscore@postmarketos.org>
> >>>
> >>> Add support for the Amlogic S805Y SoC and the Xiaomi Mi TV Stick (aka.
> >>> xiaomi-aquaman). The S805Y is very similar to the S805X, with just a
> >>> few minor differences.
> >>>
> >>> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
> >>
> >> Please run checkpatch. You have from/SoB mismatch.
> >
> > I don't see any mismatch. Maybe it complains because of a spurious
> > non-breaking space?
> >
> Could be, no clue. I copied them to editor and it also sees mismatch -
> both entries just do not match.
OK, I'll see what I can do.
>
> Best regards,
> Krzysztof
Cheers.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add S805Y and Mi TV Stick
2025-02-02 14:07 ` Krzysztof Kozlowski
2025-02-02 14:07 ` Ferass El Hafidi
@ 2025-02-03 9:16 ` Ferass El Hafidi
1 sibling, 0 replies; 8+ messages in thread
From: Ferass El Hafidi @ 2025-02-03 9:16 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-amlogic,
linux-arm-kernel, devicetree, linux-kernel,
~postmarketos/upstreaming, Artur Weber, Karl Chan,
Christian Hewitt
Hi Krzysztof,
On Sun Feb 2, 2025 at 2:07 PM UTC, Krzysztof Kozlowski wrote:
> On 02/02/2025 14:55, Ferass El Hafidi wrote:
> > Hi,
> >
> > On Sun Feb 2, 2025 at 1:54 PM UTC, Krzysztof Kozlowski wrote:
> >> On Sat, Feb 01, 2025 at 07:30:43PM +0000, Ferass El Hafidi wrote:
> >>> From: Ferass El Hafidi <funderscore@postmarketos.org>
> >>>
> >>> Add support for the Amlogic S805Y SoC and the Xiaomi Mi TV Stick (aka.
> >>> xiaomi-aquaman). The S805Y is very similar to the S805X, with just a
> >>> few minor differences.
> >>>
> >>> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org>
> >>
> >> Please run checkpatch. You have from/SoB mismatch.
> >
> > I don't see any mismatch. Maybe it complains because of a spurious
> > non-breaking space?
> >
> Could be, no clue. I copied them to editor and it also sees mismatch -
> both entries just do not match.
The From/SoB mismatch should be fixed in the v3:
https://lore.kernel.org/linux-amlogic/20250203091453.15751-1-funderscore@postmarketos.org/T/#u
Thanks.
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-02-03 9:17 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-01 19:30 [PATCH v2 0/2] Add support for Xiaomi Mi TV Stick Ferass El Hafidi
2025-02-01 19:30 ` [PATCH v2 1/2] dt-bindings: arm: amlogic: add S805Y and " Ferass El Hafidi
2025-02-02 13:54 ` Krzysztof Kozlowski
2025-02-02 13:55 ` Ferass El Hafidi
2025-02-02 14:07 ` Krzysztof Kozlowski
2025-02-02 14:07 ` Ferass El Hafidi
2025-02-03 9:16 ` Ferass El Hafidi
2025-02-01 19:30 ` [PATCH v2 2/2] arm64: dts: amlogic: add support for xiaomi-aquaman/Mi " Ferass El Hafidi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).