From: Benno Lossin <benno.lossin@proton.me>
To: "Tamir Duberstein" <tamird@gmail.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas@fjasle.eu>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Brendan Higgins" <brendan.higgins@linux.dev>,
"David Gow" <davidgow@google.com>, "Rae Moar" <rmoar@google.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Russ Weight" <russ.weight@linux.dev>,
"Rob Herring" <robh@kernel.org>,
"Saravana Kannan" <saravanak@google.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, linux-pci@vger.kernel.org,
linux-block@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/5] rust: enable `clippy::ptr_cast_constness` lint
Date: Wed, 12 Mar 2025 14:40:58 +0000 [thread overview]
Message-ID: <D8ED6OB8UFD3.2O2SXDLJO5TUI@proton.me> (raw)
In-Reply-To: <20250309-ptr-as-ptr-v2-3-25d60ad922b7@gmail.com>
On Sun Mar 9, 2025 at 5:00 PM CET, Tamir Duberstein wrote:
> In Rust 1.72.0, Clippy introduced the `ptr_cast_constness` lint [1]:
>
>> Though `as` casts between raw pointers are not terrible,
>> `pointer::cast_mut` and `pointer::cast_const` are safer because they
>> cannot accidentally cast the pointer to another type.
>
> There are only 2 affected sites:
> - `*mut T as *const U as *mut U` becomes `(*mut T).cast()`
> - `&self as *const Self as *mut Self` becomes a reference-to-pointer
> coercion + `(*const Self).cast()`.
>
> Apply these changes and enable the lint -- no functional change
> intended.
>
> Link: https://rust-lang.github.io/rust-clippy/master/index.html#ptr_cast_constness [1]
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
---
Cheers,
Benno
> ---
> Makefile | 1 +
> rust/kernel/block/mq/request.rs | 5 +++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2025-03-12 14:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 16:00 [PATCH v2 0/5] rust: reduce pointer casts, enable related lints Tamir Duberstein
2025-03-09 16:00 ` [PATCH v2 1/5] rust: retain pointer mut-ness in `container_of!` Tamir Duberstein
2025-03-12 14:22 ` Benno Lossin
2025-03-12 15:13 ` Tamir Duberstein
2025-03-09 16:00 ` [PATCH v2 2/5] rust: enable `clippy::ptr_as_ptr` lint Tamir Duberstein
2025-03-12 14:39 ` Benno Lossin
2025-03-12 15:18 ` Tamir Duberstein
2025-03-12 15:25 ` Benno Lossin
2025-03-09 16:00 ` [PATCH v2 3/5] rust: enable `clippy::ptr_cast_constness` lint Tamir Duberstein
2025-03-12 14:40 ` Benno Lossin [this message]
2025-03-09 16:00 ` [PATCH v2 4/5] rust: enable `clippy::as_ptr_cast_mut` lint Tamir Duberstein
2025-03-11 13:08 ` Benno Lossin
2025-03-09 16:00 ` [PATCH v2 5/5] rust: enable `clippy::as_underscore` lint Tamir Duberstein
2025-03-12 15:05 ` Benno Lossin
2025-03-12 15:35 ` Tamir Duberstein
2025-03-12 15:49 ` Miguel Ojeda
2025-03-12 17:05 ` Benno Lossin
2025-03-12 18:01 ` Tamir Duberstein
2025-03-12 19:10 ` Benno Lossin
2025-03-12 19:19 ` Tamir Duberstein
2025-03-12 19:43 ` Benno Lossin
2025-03-12 20:07 ` Tamir Duberstein
2025-03-12 20:41 ` Tamir Duberstein
2025-03-12 21:01 ` Benno Lossin
2025-03-12 21:04 ` Tamir Duberstein
2025-03-12 21:10 ` Tamir Duberstein
2025-03-12 21:30 ` Benno Lossin
2025-03-12 22:24 ` Tamir Duberstein
2025-03-12 22:38 ` Benno Lossin
2025-03-13 10:47 ` Tamir Duberstein
2025-03-13 14:11 ` Benno Lossin
2025-03-13 17:50 ` Tamir Duberstein
2025-03-13 18:12 ` Benno Lossin
2025-03-14 12:26 ` Tamir Duberstein
2025-03-12 20:42 ` Benno Lossin
2025-03-12 15:41 ` Miguel Ojeda
2025-03-12 15:07 ` [PATCH v2 0/5] rust: reduce pointer casts, enable related lints Benno Lossin
2025-03-12 15:14 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8ED6OB8UFD3.2O2SXDLJO5TUI@proton.me \
--to=benno.lossin@proton.me \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brendan.higgins@linux.dev \
--cc=dakr@kernel.org \
--cc=davidgow@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rmoar@google.com \
--cc=robh@kernel.org \
--cc=russ.weight@linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=saravanak@google.com \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).