* [PATCH v4 1/8] arm64: dts: qcom: qcs6490-audioreach: Add gpr node
2025-05-27 11:12 [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Prasad Kumpatla
@ 2025-05-27 11:12 ` Prasad Kumpatla
2025-06-17 20:45 ` Bjorn Andersson
2025-05-27 11:12 ` [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution Prasad Kumpatla
` (7 subsequent siblings)
8 siblings, 1 reply; 31+ messages in thread
From: Prasad Kumpatla @ 2025-05-27 11:12 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, quic_pkumpatl, kernel,
Mohammad Rafi Shaik, Konrad Dybcio
From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Add GPR(Generic Pack router) node along with
APM(Audio Process Manager) and PRM(Proxy resource
Manager) audio services.
Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
.../boot/dts/qcom/qcs6490-audioreach.dtsi | 53 +++++++++++++++++++
arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +-
2 files changed, 54 insertions(+), 1 deletion(-)
create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
new file mode 100644
index 000000000000..29d4a6a2db26
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * qcs6490 device tree source for Audioreach Solution.
+ * This file will handle the common audio device tree nodes.
+ *
+ * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#include <dt-bindings/clock/qcom,lpass-sc7280.h>
+#include <dt-bindings/soc/qcom,gpr.h>
+#include <dt-bindings/sound/qcom,q6afe.h>
+#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
+
+&remoteproc_adsp_glink {
+ /delete-node/ apr;
+
+ gpr {
+ compatible = "qcom,gpr";
+ qcom,glink-channels = "adsp_apps";
+ qcom,domain = <GPR_DOMAIN_ID_ADSP>;
+ qcom,intents = <512 20>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ q6apm: service@1 {
+ compatible = "qcom,q6apm";
+ reg = <GPR_APM_MODULE_IID>;
+ #sound-dai-cells = <0>;
+ qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
+
+ q6apmdai: dais {
+ compatible = "qcom,q6apm-dais";
+ iommus = <&apps_smmu 0x1801 0x0>;
+ };
+
+ q6apmbedai: bedais {
+ compatible = "qcom,q6apm-lpass-dais";
+ #sound-dai-cells = <1>;
+ };
+ };
+
+ q6prm: service@2 {
+ compatible = "qcom,q6prm";
+ reg = <GPR_PRM_MODULE_IID>;
+ qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
+
+ q6prmcc: clock-controller {
+ compatible = "qcom,q6prm-lpass-clocks";
+ #clock-cells = <2>;
+ };
+ };
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index b1cc3bc1aec8..708df3f08984 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -3814,7 +3814,7 @@ remoteproc_adsp: remoteproc@3700000 {
status = "disabled";
- glink-edge {
+ remoteproc_adsp_glink: glink-edge {
interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
IPCC_MPROC_SIGNAL_GLINK_QMP
IRQ_TYPE_EDGE_RISING>;
--
2.34.1
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [PATCH v4 1/8] arm64: dts: qcom: qcs6490-audioreach: Add gpr node
2025-05-27 11:12 ` [PATCH v4 1/8] arm64: dts: qcom: qcs6490-audioreach: Add gpr node Prasad Kumpatla
@ 2025-06-17 20:45 ` Bjorn Andersson
2025-06-25 6:50 ` Prasad Kumpatla
0 siblings, 1 reply; 31+ messages in thread
From: Bjorn Andersson @ 2025-06-17 20:45 UTC (permalink / raw)
To: Prasad Kumpatla
Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Konrad Dybcio,
cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik,
Konrad Dybcio
On Tue, May 27, 2025 at 04:42:20PM +0530, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>
> Add GPR(Generic Pack router) node along with
> APM(Audio Process Manager) and PRM(Proxy resource
> Manager) audio services.
>
This should talk about the choice of adding a new "-audioreach.dtsi"
file, and should cover why it wouldn't make more sense to add the
opposite of this change in sc7180-trogdor.dtsi.
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> .../boot/dts/qcom/qcs6490-audioreach.dtsi | 53 +++++++++++++++++++
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +-
> 2 files changed, 54 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> new file mode 100644
> index 000000000000..29d4a6a2db26
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> @@ -0,0 +1,53 @@
> +// SPDX-License-Identifier: GPL-2.0-only
We can be more permissive than that, please use BSD-3-Clause.
> +/*
> + * qcs6490 device tree source for Audioreach Solution.
> + * This file will handle the common audio device tree nodes.
"Common audio device tree nodes", but not those audio device tree nodes
that are already specified in sc7180.dtsi...
> + *
> + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +#include <dt-bindings/clock/qcom,lpass-sc7280.h>
> +#include <dt-bindings/soc/qcom,gpr.h>
> +#include <dt-bindings/sound/qcom,q6afe.h>
> +#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
> +
> +&remoteproc_adsp_glink {
> + /delete-node/ apr;
> +
> + gpr {
Glink only consider available (status = "okay") nodes, so if there's a
even spread across AudioReach and not, we could even move this to
sc7180.dtsi and mark both status = "disabled", and have the appropriate
one enabled for each board.
Regards,
Bjorn
> + compatible = "qcom,gpr";
> + qcom,glink-channels = "adsp_apps";
> + qcom,domain = <GPR_DOMAIN_ID_ADSP>;
> + qcom,intents = <512 20>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + q6apm: service@1 {
> + compatible = "qcom,q6apm";
> + reg = <GPR_APM_MODULE_IID>;
> + #sound-dai-cells = <0>;
> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
> +
> + q6apmdai: dais {
> + compatible = "qcom,q6apm-dais";
> + iommus = <&apps_smmu 0x1801 0x0>;
> + };
> +
> + q6apmbedai: bedais {
> + compatible = "qcom,q6apm-lpass-dais";
> + #sound-dai-cells = <1>;
> + };
> + };
> +
> + q6prm: service@2 {
> + compatible = "qcom,q6prm";
> + reg = <GPR_PRM_MODULE_IID>;
> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
> +
> + q6prmcc: clock-controller {
> + compatible = "qcom,q6prm-lpass-clocks";
> + #clock-cells = <2>;
> + };
> + };
> + };
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index b1cc3bc1aec8..708df3f08984 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -3814,7 +3814,7 @@ remoteproc_adsp: remoteproc@3700000 {
>
> status = "disabled";
>
> - glink-edge {
> + remoteproc_adsp_glink: glink-edge {
> interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
> IPCC_MPROC_SIGNAL_GLINK_QMP
> IRQ_TYPE_EDGE_RISING>;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH v4 1/8] arm64: dts: qcom: qcs6490-audioreach: Add gpr node
2025-06-17 20:45 ` Bjorn Andersson
@ 2025-06-25 6:50 ` Prasad Kumpatla
2025-07-05 12:16 ` Dmitry Baryshkov
0 siblings, 1 reply; 31+ messages in thread
From: Prasad Kumpatla @ 2025-06-25 6:50 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Konrad Dybcio,
cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik,
Konrad Dybcio
On 6/18/2025 2:15 AM, Bjorn Andersson wrote:
> On Tue, May 27, 2025 at 04:42:20PM +0530, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>
>> Add GPR(Generic Pack router) node along with
>> APM(Audio Process Manager) and PRM(Proxy resource
>> Manager) audio services.
>>
>
> This should talk about the choice of adding a new "-audioreach.dtsi"
> file, and should cover why it wouldn't make more sense to add the
> opposite of this change in sc7180-trogdor.dtsi.
Ack
>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>> .../boot/dts/qcom/qcs6490-audioreach.dtsi | 53 +++++++++++++++++++
>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +-
>> 2 files changed, 54 insertions(+), 1 deletion(-)
>> create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
>> new file mode 100644
>> index 000000000000..29d4a6a2db26
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
>> @@ -0,0 +1,53 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>
> We can be more permissive than that, please use BSD-3-Clause.
Ack
>
>> +/*
>> + * qcs6490 device tree source for Audioreach Solution.
>> + * This file will handle the common audio device tree nodes.
>
> "Common audio device tree nodes", but not those audio device tree nodes
> that are already specified in sc7180.dtsi...
Ack
>
>> + *
>> + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
>> + */
>> +
>> +#include <dt-bindings/clock/qcom,lpass-sc7280.h>
>> +#include <dt-bindings/soc/qcom,gpr.h>
>> +#include <dt-bindings/sound/qcom,q6afe.h>
>> +#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
>> +
>> +&remoteproc_adsp_glink {
>> + /delete-node/ apr;
>> +
>> + gpr {
>
> Glink only consider available (status = "okay") nodes, so if there's a
> even spread across AudioReach and not, we could even move this to
> sc7180.dtsi and mark both status = "disabled", and have the appropriate
> one enabled for each board.
I am trying to add apr and gpr both the nodes under glink-edge, but yaml
not allowing to add both the nodes.
Facing yaml errors, it's accepting apr (or) gpr only one subnode.
Please find the error logs for reference.
arch/arm64/boot/dts/qcom/qcm6490-idp.dtb: remoteproc@3700000:
glink-edge:gpr: False schema does not allow {'compatible': ['qcom,gpr'],
'qcom,glink-channels': ['adsp_apps'], 'qcom,domain': 2, 'qcom,intents':
[[512, 20]], '#address-cells': 1, '#size-cells': 0, 'service@1':
{'compatible': ['qcom,q6apm'], 'reg': [[1]], '#sound-dai-cells': 0,
'qcom,protection-domain': ['avs/audio', 'msm/adsp/audio_pd'], 'phandle':
356, 'dais': {'compatible': ['qcom,q6apm-dais'], 'iommus': [[66, 6145,
0]]}, 'bedais': {'compatible': ['qcom,q6apm-lpass-dais'],
'#sound-dai-cells': 1, 'phandle': 355}}, 'service@2': {'compatible':
['qcom,q6prm'], 'reg': [[2]], 'qcom,protection-domain': ['avs/audio',
'msm/adsp/audio_pd'], 'clock-controller': {'compatible':
['qcom,q6prm-lpass-clocks'], '#clock-cells': 2, 'phandle': 204}}}
from schema $id:
http://devicetree.org/schemas/remoteproc/qcom,sc7180-pas.yaml#
arch/arm64/boot/dts/qcom/qcm6490-idp.dtb: remoteproc@3700000:
glink-edge:apr: False schema does not allow {'compatible':
['qcom,apr-v2'], 'qcom,glink-channels': ['apr_audio_svc'],
'qcom,domain': 4, '#address-cells': 1, '#size-cells': 0, 'service@3':
{'reg': [[3]], 'compatible': ['qcom,q6core'], 'qcom,protection-domain':
['avs/audio', 'msm/adsp/audio_pd']}, 'service@4': {'compatible':
['qcom,q6afe'], 'reg': [[4]], 'qcom,protection-domain': ['avs/audio',
'msm/adsp/audio_pd'], 'dais': {'compatible': ['qcom,q6afe-dais'],
'#address-cells': 1, '#size-cells': 0, '#sound-dai-cells': 1},
'clock-controller': {'compatible': ['qcom,q6afe-clocks'],
'#clock-cells': 2}}, 'service@7': {'compatible': ['qcom,q6asm'], 'reg':
[[7]], 'qcom,protection-domain': ['avs/audio', 'msm/adsp/audio_pd'],
'dais': {'compatible': ['qcom,q6asm-dais'], '#address-cells': 1,
'#size-cells': 0, '#sound-dai-cells': 1, 'iommus': [[66, 6145, 0]],
'dai@0': {'reg': [[0]]}, 'dai@1': {'reg': [[1]]}, 'dai@2': {'reg':
[[2]]}}}, 'service@8': {'compatible': ['qcom,q6adm'], 'reg': [[8]],
'qcom,protection-domain': ['avs/audio', 'msm/adsp/audio_pd'], 'routing':
{'compatible': ['qcom,q6adm-routing'], '#sound-dai-cells': 0}}}
from schema $id:
http://devicetree.org/schemas/remoteproc/qcom,sc7180-pas.yaml#
arch/arm64/boot/dts/qcom/qcm6490-idp.dtb: remoteproc@3700000:
Unevaluated properties are not allowed ('glink-edge',
'qcom,smem-state-names', 'qcom,smem-states' were unexpected)
from schema $id:
http://devicetree.org/schemas/remoteproc/qcom,sc7180-pas.yaml#
/local/mnt/workspace/ANDRIOD/K2C_project/UPSTREAM/linux_next_11_June_2025/linux-next/arch/arm64/boot/dts/qcom
Thanks,
Prasad
>
> Regards,
> Bjorn
>
>> + compatible = "qcom,gpr";
>> + qcom,glink-channels = "adsp_apps";
>> + qcom,domain = <GPR_DOMAIN_ID_ADSP>;
>> + qcom,intents = <512 20>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + q6apm: service@1 {
>> + compatible = "qcom,q6apm";
>> + reg = <GPR_APM_MODULE_IID>;
>> + #sound-dai-cells = <0>;
>> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
>> +
>> + q6apmdai: dais {
>> + compatible = "qcom,q6apm-dais";
>> + iommus = <&apps_smmu 0x1801 0x0>;
>> + };
>> +
>> + q6apmbedai: bedais {
>> + compatible = "qcom,q6apm-lpass-dais";
>> + #sound-dai-cells = <1>;
>> + };
>> + };
>> +
>> + q6prm: service@2 {
>> + compatible = "qcom,q6prm";
>> + reg = <GPR_PRM_MODULE_IID>;
>> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
>> +
>> + q6prmcc: clock-controller {
>> + compatible = "qcom,q6prm-lpass-clocks";
>> + #clock-cells = <2>;
>> + };
>> + };
>> + };
>> +};
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index b1cc3bc1aec8..708df3f08984 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -3814,7 +3814,7 @@ remoteproc_adsp: remoteproc@3700000 {
>>
>> status = "disabled";
>>
>> - glink-edge {
>> + remoteproc_adsp_glink: glink-edge {
>> interrupts-extended = <&ipcc IPCC_CLIENT_LPASS
>> IPCC_MPROC_SIGNAL_GLINK_QMP
>> IRQ_TYPE_EDGE_RISING>;
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH v4 1/8] arm64: dts: qcom: qcs6490-audioreach: Add gpr node
2025-06-25 6:50 ` Prasad Kumpatla
@ 2025-07-05 12:16 ` Dmitry Baryshkov
0 siblings, 0 replies; 31+ messages in thread
From: Dmitry Baryshkov @ 2025-07-05 12:16 UTC (permalink / raw)
To: Prasad Kumpatla
Cc: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio, cros-qcom-dts-watchers, linux-arm-msm, linux-gpio,
devicetree, linux-kernel, linux-sound, kernel,
Mohammad Rafi Shaik, Konrad Dybcio
On Wed, Jun 25, 2025 at 12:20:39PM +0530, Prasad Kumpatla wrote:
>
>
> On 6/18/2025 2:15 AM, Bjorn Andersson wrote:
> > On Tue, May 27, 2025 at 04:42:20PM +0530, Prasad Kumpatla wrote:
> > > From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> > >
> > > Add GPR(Generic Pack router) node along with
> > > APM(Audio Process Manager) and PRM(Proxy resource
> > > Manager) audio services.
> > >
> >
> > This should talk about the choice of adding a new "-audioreach.dtsi"
> > file, and should cover why it wouldn't make more sense to add the
> > opposite of this change in sc7180-trogdor.dtsi.
>
> Ack
>
> >
> > > Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> > > Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> > > Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > > ---
> > > .../boot/dts/qcom/qcs6490-audioreach.dtsi | 53 +++++++++++++++++++
> > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +-
> > > 2 files changed, 54 insertions(+), 1 deletion(-)
> > > create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> > > new file mode 100644
> > > index 000000000000..29d4a6a2db26
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> > > @@ -0,0 +1,53 @@
> > > +// SPDX-License-Identifier: GPL-2.0-only
> >
> > We can be more permissive than that, please use BSD-3-Clause.
>
> Ack
>
> >
> > > +/*
> > > + * qcs6490 device tree source for Audioreach Solution.
> > > + * This file will handle the common audio device tree nodes.
> >
> > "Common audio device tree nodes", but not those audio device tree nodes
> > that are already specified in sc7180.dtsi...
>
> Ack
>
> >
> > > + *
> > > + * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
> > > + */
> > > +
> > > +#include <dt-bindings/clock/qcom,lpass-sc7280.h>
> > > +#include <dt-bindings/soc/qcom,gpr.h>
> > > +#include <dt-bindings/sound/qcom,q6afe.h>
> > > +#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
> > > +
> > > +&remoteproc_adsp_glink {
> > > + /delete-node/ apr;
> > > +
> > > + gpr {
> >
> > Glink only consider available (status = "okay") nodes, so if there's a
> > even spread across AudioReach and not, we could even move this to
> > sc7180.dtsi and mark both status = "disabled", and have the appropriate
> > one enabled for each board.
>
> I am trying to add apr and gpr both the nodes under glink-edge, but yaml not
> allowing to add both the nodes.
>
> Facing yaml errors, it's accepting apr (or) gpr only one subnode.
It should be fine to add both nodes as disabled and select corresponding
nodes only when it is actually implemented by the platform.
>
> Please find the error logs for reference.
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution
2025-05-27 11:12 [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Prasad Kumpatla
2025-05-27 11:12 ` [PATCH v4 1/8] arm64: dts: qcom: qcs6490-audioreach: Add gpr node Prasad Kumpatla
@ 2025-05-27 11:12 ` Prasad Kumpatla
2025-05-27 11:58 ` Krzysztof Kozlowski
2025-05-27 11:12 ` [PATCH v4 3/8] arm64: dts: qcom: sc7280: Add WSA SoundWire and LPASS support Prasad Kumpatla
` (6 subsequent siblings)
8 siblings, 1 reply; 31+ messages in thread
From: Prasad Kumpatla @ 2025-05-27 11:12 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, quic_pkumpatl, kernel,
Mohammad Rafi Shaik
From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Manage clock settings for ADSP solution and document the clock properties
on sc7280 lpass pincontrol node which is required for ADSP based
solution.
Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
---
.../qcom,sc7280-lpass-lpi-pinctrl.yaml | 10 ++++++++
.../bindings/sound/qcom,lpass-va-macro.yaml | 12 +++++++---
.../bindings/sound/qcom,lpass-wsa-macro.yaml | 24 ++++++++++++++++---
3 files changed, 40 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
index 08801cc4e476..b1270124bfe3 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
@@ -20,6 +20,16 @@ properties:
reg:
maxItems: 2
+ clocks:
+ items:
+ - description: LPASS Core voting clock
+ - description: LPASS Audio voting clock
+
+ clock-names:
+ items:
+ - const: core
+ - const: audio
+
patternProperties:
"-state$":
oneOf:
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
index f41deaa6f4df..92b97c214060 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
@@ -78,10 +78,16 @@ allOf:
then:
properties:
clocks:
- maxItems: 1
+ minItems: 1
+ maxItems: 3
clock-names:
- items:
- - const: mclk
+ oneOf:
+ - items: # for ADSP based platforms
+ - const: mclk
+ - const: macro
+ - const: dcodec
+ - items: # for ADSP bypass based platforms
+ - const: mclk
- if:
properties:
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
index 9082e363c709..6a999ed484e7 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
@@ -35,11 +35,11 @@ properties:
const: 0
clocks:
- minItems: 4
+ minItems: 3
maxItems: 6
clock-names:
- minItems: 4
+ minItems: 3
maxItems: 6
clock-output-names:
@@ -59,12 +59,30 @@ required:
allOf:
- $ref: dai-common.yaml#
-
- if:
properties:
compatible:
enum:
- qcom,sc7280-lpass-wsa-macro
+ then:
+ properties:
+ clock-names:
+ oneOf:
+ - items: # for ADSP based platforms
+ - const: mclk
+ - const: npl
+ - const: macro
+ - const: dcodec
+ - const: fsgen
+ - items: # for ADSP bypass based platforms
+ - const: mclk
+ - const: npl
+ - const: fsgen
+
+ - if:
+ properties:
+ compatible:
+ enum:
- qcom,sm8250-lpass-wsa-macro
- qcom,sm8450-lpass-wsa-macro
- qcom,sc8280xp-lpass-wsa-macro
--
2.34.1
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution
2025-05-27 11:12 ` [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution Prasad Kumpatla
@ 2025-05-27 11:58 ` Krzysztof Kozlowski
2025-06-01 12:45 ` Prasad Kumpatla
0 siblings, 1 reply; 31+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-27 11:58 UTC (permalink / raw)
To: Prasad Kumpatla, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 27/05/2025 13:12, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>
> Manage clock settings for ADSP solution and document the clock properties
> on sc7280 lpass pincontrol node which is required for ADSP based
> solution.
>
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> ---
Nothing in cover letter explained what was happening with this patch.
Provide changelog under --- in such case.
> .../qcom,sc7280-lpass-lpi-pinctrl.yaml | 10 ++++++++
> .../bindings/sound/qcom,lpass-va-macro.yaml | 12 +++++++---
> .../bindings/sound/qcom,lpass-wsa-macro.yaml | 24 ++++++++++++++++---
Split patches per subsystem. Pinctrl is not ASoC.
> 3 files changed, 40 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
> index 08801cc4e476..b1270124bfe3 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
> @@ -20,6 +20,16 @@ properties:
> reg:
> maxItems: 2
>
> + clocks:
> + items:
> + - description: LPASS Core voting clock
> + - description: LPASS Audio voting clock
> +
> + clock-names:
> + items:
> + - const: core
> + - const: audio
> +
> patternProperties:
> "-state$":
> oneOf:
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> index f41deaa6f4df..92b97c214060 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> @@ -78,10 +78,16 @@ allOf:
> then:
> properties:
> clocks:
> - maxItems: 1
> + minItems: 1
> + maxItems: 3
> clock-names:
> - items:
> - - const: mclk
> + oneOf:
> + - items: # for ADSP based platforms
> + - const: mclk
> + - const: macro
> + - const: dcodec
> + - items: # for ADSP bypass based platforms
> + - const: mclk
This device always receives same amount of clocks. Hardware is not
different if you decide to not use ADSP.
>
> - if:
> properties:
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
> index 9082e363c709..6a999ed484e7 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
> @@ -35,11 +35,11 @@ properties:
> const: 0
>
> clocks:
> - minItems: 4
> + minItems: 3
> maxItems: 6
>
> clock-names:
> - minItems: 4
> + minItems: 3
> maxItems: 6
>
> clock-output-names:
> @@ -59,12 +59,30 @@ required:
>
> allOf:
> - $ref: dai-common.yaml#
> -
> - if:
> properties:
> compatible:
> enum:
> - qcom,sc7280-lpass-wsa-macro
> + then:
> + properties:
> + clock-names:
> + oneOf:
> + - items: # for ADSP based platforms
> + - const: mclk
> + - const: npl
> + - const: macro
> + - const: dcodec
> + - const: fsgen
> + - items: # for ADSP bypass based platforms
> + - const: mclk
> + - const: npl
> + - const: fsgen
This silently breaks ABI. Third clock is macro.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution
2025-05-27 11:58 ` Krzysztof Kozlowski
@ 2025-06-01 12:45 ` Prasad Kumpatla
2025-06-01 14:50 ` Krzysztof Kozlowski
0 siblings, 1 reply; 31+ messages in thread
From: Prasad Kumpatla @ 2025-06-01 12:45 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 5/27/2025 5:28 PM, Krzysztof Kozlowski wrote:
> On 27/05/2025 13:12, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>
>> Manage clock settings for ADSP solution and document the clock properties
>> on sc7280 lpass pincontrol node which is required for ADSP based
>> solution.
>>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> ---
>
> Nothing in cover letter explained what was happening with this patch.
> Provide changelog under --- in such case.
Ack, Will provide more info on commit text.
>
>> .../qcom,sc7280-lpass-lpi-pinctrl.yaml | 10 ++++++++
>> .../bindings/sound/qcom,lpass-va-macro.yaml | 12 +++++++---
>> .../bindings/sound/qcom,lpass-wsa-macro.yaml | 24 ++++++++++++++++---
>
> Split patches per subsystem. Pinctrl is not ASoC.
Ack
>
>> 3 files changed, 40 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
>> index 08801cc4e476..b1270124bfe3 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
>> @@ -20,6 +20,16 @@ properties:
>> reg:
>> maxItems: 2
>>
>> + clocks:
>> + items:
>> + - description: LPASS Core voting clock
>> + - description: LPASS Audio voting clock
>> +
>> + clock-names:
>> + items:
>> + - const: core
>> + - const: audio
>> +
>> patternProperties:
>> "-state$":
>> oneOf:
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> index f41deaa6f4df..92b97c214060 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> @@ -78,10 +78,16 @@ allOf:
>> then:
>> properties:
>> clocks:
>> - maxItems: 1
>> + minItems: 1
>> + maxItems: 3
>> clock-names:
>> - items:
>> - - const: mclk
>> + oneOf:
>> + - items: # for ADSP based platforms
>> + - const: mclk
>> + - const: macro
>> + - const: dcodec
>> + - items: # for ADSP bypass based platforms
>> + - const: mclk
>
> This device always receives same amount of clocks. Hardware is not
> different if you decide to not use ADSP.
for sc7280 clock handling only supports non-DSP based solution, macro
and dcodec votes are placed using CPU-Powerdomains. Which are not under
clocking properties. In ADSP based platforms macro and dcodec votes
should be placed from ADSP.>
>>
>> - if:
>> properties:
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
>> index 9082e363c709..6a999ed484e7 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
>> @@ -35,11 +35,11 @@ properties:
>> const: 0
>>
>> clocks:
>> - minItems: 4
>> + minItems: 3
>> maxItems: 6
>>
>> clock-names:
>> - minItems: 4
>> + minItems: 3
>> maxItems: 6
>>
>> clock-output-names:
>> @@ -59,12 +59,30 @@ required:
>>
>> allOf:
>> - $ref: dai-common.yaml#
>> -
>> - if:
>> properties:
>> compatible:
>> enum:
>> - qcom,sc7280-lpass-wsa-macro
>> + then:
>> + properties:
>> + clock-names:
>> + oneOf:
>> + - items: # for ADSP based platforms
>> + - const: mclk
>> + - const: npl
>> + - const: macro
>> + - const: dcodec
>> + - const: fsgen
>> + - items: # for ADSP bypass based platforms
>> + - const: mclk
>> + - const: npl
>> + - const: fsgen
>
> This silently breaks ABI. Third clock is macro.
Ack, will check and update.
Thanks,
Prasad>
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution
2025-06-01 12:45 ` Prasad Kumpatla
@ 2025-06-01 14:50 ` Krzysztof Kozlowski
2025-06-10 13:10 ` Konrad Dybcio
0 siblings, 1 reply; 31+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-01 14:50 UTC (permalink / raw)
To: Prasad Kumpatla, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 01/06/2025 14:45, Prasad Kumpatla wrote:
>>> properties:
>>> clocks:
>>> - maxItems: 1
>>> + minItems: 1
>>> + maxItems: 3
>>> clock-names:
>>> - items:
>>> - - const: mclk
>>> + oneOf:
>>> + - items: # for ADSP based platforms
>>> + - const: mclk
>>> + - const: macro
>>> + - const: dcodec
>>> + - items: # for ADSP bypass based platforms
>>> + - const: mclk
>>
>> This device always receives same amount of clocks. Hardware is not
>> different if you decide to not use ADSP.
> for sc7280 clock handling only supports non-DSP based solution, macro
ONLY?
> and dcodec votes are placed using CPU-Powerdomains. Which are not under
> clocking properties. In ADSP based platforms macro and dcodec votes
> should be placed from ADSP.>
I don't understand this, that's barely a sentence. Anyway if that's
ONLY, then seems pretty fixed and I don't get why you make it flexible.
Expressing clocks as CPU powerdomains is not really correct.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution
2025-06-01 14:50 ` Krzysztof Kozlowski
@ 2025-06-10 13:10 ` Konrad Dybcio
0 siblings, 0 replies; 31+ messages in thread
From: Konrad Dybcio @ 2025-06-10 13:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Prasad Kumpatla, Bjorn Andersson,
Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Srinivas Kandagatla, Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 6/1/25 4:50 PM, Krzysztof Kozlowski wrote:
> On 01/06/2025 14:45, Prasad Kumpatla wrote:
>>>> properties:
>>>> clocks:
>>>> - maxItems: 1
>>>> + minItems: 1
>>>> + maxItems: 3
>>>> clock-names:
>>>> - items:
>>>> - - const: mclk
>>>> + oneOf:
>>>> + - items: # for ADSP based platforms
>>>> + - const: mclk
>>>> + - const: macro
>>>> + - const: dcodec
>>>> + - items: # for ADSP bypass based platforms
>>>> + - const: mclk
>>>
>>> This device always receives same amount of clocks. Hardware is not
>>> different if you decide to not use ADSP.
>> for sc7280 clock handling only supports non-DSP based solution, macro
>
> ONLY?
>
>> and dcodec votes are placed using CPU-Powerdomains. Which are not under
>> clocking properties. In ADSP based platforms macro and dcodec votes
>> should be placed from ADSP.>
>
> I don't understand this, that's barely a sentence. Anyway if that's
> ONLY, then seems pretty fixed and I don't get why you make it flexible.
>
> Expressing clocks as CPU powerdomains is not really correct.
I think that's some jargon for "power domains controlled by the OS
running on the CPU".. I really hope PSCI has nothing to do with it..
Konrad
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH v4 3/8] arm64: dts: qcom: sc7280: Add WSA SoundWire and LPASS support
2025-05-27 11:12 [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Prasad Kumpatla
2025-05-27 11:12 ` [PATCH v4 1/8] arm64: dts: qcom: qcs6490-audioreach: Add gpr node Prasad Kumpatla
2025-05-27 11:12 ` [PATCH v4 2/8] ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution Prasad Kumpatla
@ 2025-05-27 11:12 ` Prasad Kumpatla
2025-05-31 18:32 ` Konrad Dybcio
2025-05-27 11:12 ` [PATCH v4 4/8] arm64: dts: qcom: qcs6490-audioreach: Modify LPASS macros clock settings for audioreach Prasad Kumpatla
` (5 subsequent siblings)
8 siblings, 1 reply; 31+ messages in thread
From: Prasad Kumpatla @ 2025-05-27 11:12 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, quic_pkumpatl, kernel,
Mohammad Rafi Shaik
From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Add WSA LPASS macro Codec along with SoundWire controller.
Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 76 ++++++++++++++++++++++++++++
1 file changed, 76 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 708df3f08984..d7460d67f35f 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2636,6 +2636,66 @@ swr1: soundwire@3230000 {
status = "disabled";
};
+ lpass_wsa_macro: codec@3240000 {
+ compatible = "qcom,sc7280-lpass-wsa-macro";
+ reg = <0x0 0x03240000 0x0 0x1000>;
+
+ clocks = <&lpass_aon LPASS_AON_CC_TX_MCLK_CLK>,
+ <&lpass_aon LPASS_AON_CC_TX_MCLK_2X_CLK>,
+ <&lpass_va_macro>;
+ clock-names = "mclk",
+ "npl",
+ "fsgen";
+
+ pinctrl-0 = <&lpass_wsa_swr_clk>, <&lpass_wsa_swr_data>;
+ pinctrl-names = "default";
+
+ power-domains = <&lpass_hm LPASS_CORE_CC_LPASS_CORE_HM_GDSC>,
+ <&lpass_aon LPASS_AON_CC_LPASS_AUDIO_HM_GDSC>;
+ power-domain-names = "macro", "dcodec";
+
+ #clock-cells = <0>;
+ clock-output-names = "mclk";
+ #sound-dai-cells = <1>;
+
+ status = "disabled";
+ };
+
+ swr2: soundwire@3250000 {
+ compatible = "qcom,soundwire-v1.6.0";
+ reg = <0x0 0x03250000 0x0 0x2000>;
+
+ interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&lpass_wsa_macro>;
+ clock-names = "iface";
+
+ resets = <&lpass_audiocc LPASS_AUDIO_SWR_WSA_CGCR>;
+ reset-names = "swr_audio_cgcr";
+
+ qcom,din-ports = <2>;
+ qcom,dout-ports = <6>;
+
+ qcom,ports-sinterval-low = /bits/ 8 <0x07 0x1f 0x3f 0x07
+ 0x1f 0x3f 0x0f 0x0f>;
+ qcom,ports-offset1 = /bits/ 8 <0x01 0x02 0x0c 0x06 0x12 0x0d 0x07 0x0a>;
+ qcom,ports-offset2 = /bits/ 8 <0xff 0x00 0x1f 0xff 0x00 0x1f 0x00 0x00>;
+ qcom,ports-hstart = /bits/ 8 <0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;
+ qcom,ports-hstop = /bits/ 8 <0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;
+ qcom,ports-word-length = /bits/ 8 <0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff>;
+ qcom,ports-block-pack-mode = /bits/ 8 <0xff 0xff 0x01 0xff 0xff 0x01
+ 0xff 0xff>;
+ qcom,ports-block-group-count = /bits/ 8 <0xff 0xff 0xff 0xff 0xff 0xff
+ 0xff 0xff>;
+ qcom,ports-lane-control = /bits/ 8 <0xff 0xff 0xff 0xff 0xff 0xff
+ 0xff 0xff>;
+
+ #address-cells = <2>;
+ #size-cells = <0>;
+ #sound-dai-cells = <1>;
+
+ status = "disabled";
+ };
+
lpass_audiocc: clock-controller@3300000 {
compatible = "qcom,sc7280-lpassaudiocc";
reg = <0 0x03300000 0 0x30000>,
@@ -2839,6 +2899,22 @@ lpass_tx_swr_data: tx-swr-data-state {
pins = "gpio1", "gpio2", "gpio14";
function = "swr_tx_data";
};
+
+ lpass_wsa_swr_clk: wsa-swr-clk-state {
+ pins = "gpio10";
+ function = "wsa_swr_clk";
+ drive-strength = <2>;
+ slew-rate = <1>;
+ bias-disable;
+ };
+
+ lpass_wsa_swr_data: wsa-swr-data-state {
+ pins = "gpio11";
+ function = "wsa_swr_data";
+ drive-strength = <2>;
+ slew-rate = <1>;
+ bias-bus-hold;
+ };
};
gpu: gpu@3d00000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [PATCH v4 3/8] arm64: dts: qcom: sc7280: Add WSA SoundWire and LPASS support
2025-05-27 11:12 ` [PATCH v4 3/8] arm64: dts: qcom: sc7280: Add WSA SoundWire and LPASS support Prasad Kumpatla
@ 2025-05-31 18:32 ` Konrad Dybcio
0 siblings, 0 replies; 31+ messages in thread
From: Konrad Dybcio @ 2025-05-31 18:32 UTC (permalink / raw)
To: Prasad Kumpatla, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 5/27/25 1:12 PM, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>
> Add WSA LPASS macro Codec along with SoundWire controller.
>
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> ---
[...]
> + swr2: soundwire@3250000 {
> + compatible = "qcom,soundwire-v1.6.0";
> + reg = <0x0 0x03250000 0x0 0x2000>;
0x10_000 for size
otherwise:
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH v4 4/8] arm64: dts: qcom: qcs6490-audioreach: Modify LPASS macros clock settings for audioreach
2025-05-27 11:12 [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Prasad Kumpatla
` (2 preceding siblings ...)
2025-05-27 11:12 ` [PATCH v4 3/8] arm64: dts: qcom: sc7280: Add WSA SoundWire and LPASS support Prasad Kumpatla
@ 2025-05-27 11:12 ` Prasad Kumpatla
2025-05-31 18:27 ` Konrad Dybcio
2025-05-27 11:12 ` [PATCH v4 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier Prasad Kumpatla
` (4 subsequent siblings)
8 siblings, 1 reply; 31+ messages in thread
From: Prasad Kumpatla @ 2025-05-27 11:12 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, quic_pkumpatl, kernel,
Mohammad Rafi Shaik
From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Modify and enable WSA, VA, RX and TX lpass macros and lpass_tlmm clock
settings. For audioreach solution mclk, npl and fsgen clocks are enabled
through the q6prm clock driver.
For qcs6490 RX drives clk from TX CORE which is mandated from DSP side,
Unlike dedicated core clocks. Core TX clk is used for both RX and
WSA as per DSP recommendations.
Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
---
.../boot/dts/qcom/qcs6490-audioreach.dtsi | 63 +++++++++++++++++++
1 file changed, 63 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
index 29d4a6a2db26..4111091f77b2 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
@@ -11,6 +11,69 @@
#include <dt-bindings/sound/qcom,q6afe.h>
#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
+&lpass_rx_macro {
+ /delete-property/ power-domains;
+ /delete-property/ power-domain-names;
+ clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_CLK_ID_TX_CORE_NPL_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&lpass_va_macro>;
+ clock-names = "mclk",
+ "npl",
+ "macro",
+ "dcodec",
+ "fsgen";
+};
+
+&lpass_tlmm {
+ clocks = <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
+ clock-names = "core",
+ "audio";
+};
+
+&lpass_tx_macro {
+ /delete-property/ power-domains;
+ /delete-property/ power-domain-names;
+ clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_CLK_ID_TX_CORE_NPL_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&lpass_va_macro>;
+ clock-names = "mclk",
+ "npl",
+ "macro",
+ "dcodec",
+ "fsgen";
+};
+
+&lpass_va_macro {
+ /delete-property/ power-domains;
+ /delete-property/ power-domain-names;
+ clocks = <&q6prmcc LPASS_CLK_ID_VA_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
+ clock-names = "mclk",
+ "macro",
+ "dcodec";
+};
+
+&lpass_wsa_macro {
+ /delete-property/ power-domains;
+ /delete-property/ power-domain-names;
+ clocks = <&q6prmcc LPASS_CLK_ID_TX_CORE_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_CLK_ID_TX_CORE_NPL_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+ <&lpass_va_macro>;
+ clock-names = "mclk",
+ "npl",
+ "macro",
+ "dcodec",
+ "fsgen";
+};
+
&remoteproc_adsp_glink {
/delete-node/ apr;
--
2.34.1
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [PATCH v4 4/8] arm64: dts: qcom: qcs6490-audioreach: Modify LPASS macros clock settings for audioreach
2025-05-27 11:12 ` [PATCH v4 4/8] arm64: dts: qcom: qcs6490-audioreach: Modify LPASS macros clock settings for audioreach Prasad Kumpatla
@ 2025-05-31 18:27 ` Konrad Dybcio
0 siblings, 0 replies; 31+ messages in thread
From: Konrad Dybcio @ 2025-05-31 18:27 UTC (permalink / raw)
To: Prasad Kumpatla, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 5/27/25 1:12 PM, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>
> Modify and enable WSA, VA, RX and TX lpass macros and lpass_tlmm clock
> settings. For audioreach solution mclk, npl and fsgen clocks are enabled
> through the q6prm clock driver.
>
> For qcs6490 RX drives clk from TX CORE which is mandated from DSP side,
> Unlike dedicated core clocks. Core TX clk is used for both RX and
> WSA as per DSP recommendations.
>
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH v4 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier
2025-05-27 11:12 [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Prasad Kumpatla
` (3 preceding siblings ...)
2025-05-27 11:12 ` [PATCH v4 4/8] arm64: dts: qcom: qcs6490-audioreach: Modify LPASS macros clock settings for audioreach Prasad Kumpatla
@ 2025-05-27 11:12 ` Prasad Kumpatla
2025-05-27 11:59 ` Krzysztof Kozlowski
2025-06-04 8:20 ` Dmitry Baryshkov
2025-05-27 11:12 ` [PATCH v4 6/8] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card Prasad Kumpatla
` (3 subsequent siblings)
8 siblings, 2 replies; 31+ messages in thread
From: Prasad Kumpatla @ 2025-05-27 11:12 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, quic_pkumpatl, kernel,
Mohammad Rafi Shaik
From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Add nodes for WSA8830 speakers amplifier on qcs6490-rb3gen2 board.
Enable lpass_wsa and lpass_va macros along with pinctrl settings
for audio.
Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
---
.../boot/dts/qcom/qcs6490-audioreach.dtsi | 18 ++++++++++
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 35 +++++++++++++++++++
2 files changed, 53 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
index 4111091f77b2..542a39ca72bb 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
@@ -11,6 +11,24 @@
#include <dt-bindings/sound/qcom,q6afe.h>
#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
+&lpass_dmic01_clk {
+ drive-strength = <8>;
+ bias-disable;
+};
+
+&lpass_dmic01_data {
+ bias-pull-down;
+};
+
+&lpass_dmic23_clk {
+ drive-strength = <8>;
+ bias-disable;
+};
+
+&lpass_dmic23_data {
+ bias-pull-down;
+};
+
&lpass_rx_macro {
/delete-property/ power-domains;
/delete-property/ power-domain-names;
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index 5fbcd48f2e2d..21cb392c36fa 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -19,6 +19,7 @@
#include "pm7325.dtsi"
#include "pm8350c.dtsi"
#include "pmk8350.dtsi"
+#include "qcs6490-audioreach.dtsi"
/delete-node/ &ipa_fw_mem;
/delete-node/ &rmtfs_mem;
@@ -765,6 +766,14 @@ redriver_usb_con_sbu: endpoint {
};
};
+&lpass_va_macro {
+ status = "okay";
+};
+
+&lpass_wsa_macro {
+ status = "okay";
+};
+
&mdss {
status = "okay";
};
@@ -1039,6 +1048,32 @@ &sdhc_2 {
status = "okay";
};
+&swr2 {
+ status = "okay";
+
+ left_spkr: speaker@0,1 {
+ compatible = "sdw10217020200";
+ reg = <0 1>;
+ powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
+ #sound-dai-cells = <0>;
+ sound-name-prefix = "SpkrLeft";
+ #thermal-sensor-cells = <0>;
+ vdd-supply = <&vreg_l18b_1p8>;
+ qcom,port-mapping = <1 2 3 7>;
+ };
+
+ right_spkr: speaker@0,2 {
+ compatible = "sdw10217020200";
+ reg = <0 2>;
+ powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
+ #sound-dai-cells = <0>;
+ sound-name-prefix = "SpkrRight";
+ #thermal-sensor-cells = <0>;
+ vdd-supply = <&vreg_l18b_1p8>;
+ qcom,port-mapping = <4 5 6 8>;
+ };
+};
+
&tlmm {
gpio-reserved-ranges = <32 2>, /* ADSP */
<48 4>; /* NFC */
--
2.34.1
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [PATCH v4 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier
2025-05-27 11:12 ` [PATCH v4 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier Prasad Kumpatla
@ 2025-05-27 11:59 ` Krzysztof Kozlowski
2025-06-01 12:52 ` Prasad Kumpatla
2025-06-04 8:20 ` Dmitry Baryshkov
1 sibling, 1 reply; 31+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-27 11:59 UTC (permalink / raw)
To: Prasad Kumpatla, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 27/05/2025 13:12, Prasad Kumpatla wrote:
> + left_spkr: speaker@0,1 {
> + compatible = "sdw10217020200";
> + reg = <0 1>;
> + powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
> + #sound-dai-cells = <0>;
> + sound-name-prefix = "SpkrLeft";
> + #thermal-sensor-cells = <0>;
> + vdd-supply = <&vreg_l18b_1p8>;
> + qcom,port-mapping = <1 2 3 7>;
> + };
> +
> + right_spkr: speaker@0,2 {
> + compatible = "sdw10217020200";
> + reg = <0 2>;
> + powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
This will fail during runtime. You never booted your DTS.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH v4 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier
2025-05-27 11:59 ` Krzysztof Kozlowski
@ 2025-06-01 12:52 ` Prasad Kumpatla
2025-06-01 14:54 ` Krzysztof Kozlowski
0 siblings, 1 reply; 31+ messages in thread
From: Prasad Kumpatla @ 2025-06-01 12:52 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 5/27/2025 5:29 PM, Krzysztof Kozlowski wrote:
> On 27/05/2025 13:12, Prasad Kumpatla wrote:
>> + left_spkr: speaker@0,1 {
>> + compatible = "sdw10217020200";
>> + reg = <0 1>;
>> + powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
>> + #sound-dai-cells = <0>;
>> + sound-name-prefix = "SpkrLeft";
>> + #thermal-sensor-cells = <0>;
>> + vdd-supply = <&vreg_l18b_1p8>;
>> + qcom,port-mapping = <1 2 3 7>;
>> + };
>> +
>> + right_spkr: speaker@0,2 {
>> + compatible = "sdw10217020200";
>> + reg = <0 2>;
>> + powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
>
>
> This will fail during runtime. You never booted your DTS.
No, its working fine, didn't seen any issues for far. Please help to
provide at which point of line seen issue or provide more context to
understand for me?
Thanks,
Prasad>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH v4 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier
2025-06-01 12:52 ` Prasad Kumpatla
@ 2025-06-01 14:54 ` Krzysztof Kozlowski
0 siblings, 0 replies; 31+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-01 14:54 UTC (permalink / raw)
To: Prasad Kumpatla, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 01/06/2025 14:52, Prasad Kumpatla wrote:
>
>
> On 5/27/2025 5:29 PM, Krzysztof Kozlowski wrote:
>> On 27/05/2025 13:12, Prasad Kumpatla wrote:
>>> + left_spkr: speaker@0,1 {
>>> + compatible = "sdw10217020200";
>>> + reg = <0 1>;
>>> + powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
>>> + #sound-dai-cells = <0>;
>>> + sound-name-prefix = "SpkrLeft";
>>> + #thermal-sensor-cells = <0>;
>>> + vdd-supply = <&vreg_l18b_1p8>;
>>> + qcom,port-mapping = <1 2 3 7>;
>>> + };
>>> +
>>> + right_spkr: speaker@0,2 {
>>> + compatible = "sdw10217020200";
>>> + reg = <0 2>;
>>> + powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
>>
>>
>> This will fail during runtime. You never booted your DTS.
>
> No, its working fine, didn't seen any issues for far. Please help to
> provide at which point of line seen issue or provide more context to
> understand for me?
Okay, so the driver uses non-exclusive GPIO. Well, this should be really
fixed now. There is no excuse now "cannot work", because I fixed WSA884x
so new DTS using this method should not be allowed. Non-exclusive in
this driver is buggy and works by pure coincidence. You should see clear
warnings and issues during probe, because working device WILL be reset
by the other device.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v4 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier
2025-05-27 11:12 ` [PATCH v4 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier Prasad Kumpatla
2025-05-27 11:59 ` Krzysztof Kozlowski
@ 2025-06-04 8:20 ` Dmitry Baryshkov
1 sibling, 0 replies; 31+ messages in thread
From: Dmitry Baryshkov @ 2025-06-04 8:20 UTC (permalink / raw)
To: Prasad Kumpatla
Cc: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio, cros-qcom-dts-watchers, linux-arm-msm, linux-gpio,
devicetree, linux-kernel, linux-sound, kernel,
Mohammad Rafi Shaik
On Tue, May 27, 2025 at 04:42:24PM +0530, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>
> Add nodes for WSA8830 speakers amplifier on qcs6490-rb3gen2 board.
>
> Enable lpass_wsa and lpass_va macros along with pinctrl settings
> for audio.
>
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> ---
> .../boot/dts/qcom/qcs6490-audioreach.dtsi | 18 ++++++++++
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 35 +++++++++++++++++++
> 2 files changed, 53 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> index 4111091f77b2..542a39ca72bb 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> @@ -11,6 +11,24 @@
> #include <dt-bindings/sound/qcom,q6afe.h>
> #include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
>
> +&lpass_dmic01_clk {
> + drive-strength = <8>;
> + bias-disable;
> +};
> +
> +&lpass_dmic01_data {
> + bias-pull-down;
> +};
> +
> +&lpass_dmic23_clk {
> + drive-strength = <8>;
> + bias-disable;
> +};
> +
> +&lpass_dmic23_data {
> + bias-pull-down;
> +};
> +
> &lpass_rx_macro {
> /delete-property/ power-domains;
> /delete-property/ power-domain-names;
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index 5fbcd48f2e2d..21cb392c36fa 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -19,6 +19,7 @@
> #include "pm7325.dtsi"
> #include "pm8350c.dtsi"
> #include "pmk8350.dtsi"
> +#include "qcs6490-audioreach.dtsi"
>
> /delete-node/ &ipa_fw_mem;
> /delete-node/ &rmtfs_mem;
> @@ -765,6 +766,14 @@ redriver_usb_con_sbu: endpoint {
> };
> };
>
> +&lpass_va_macro {
[ 10.942165] va_macro 3370000.codec: qcom,dmic-sample-rate dt entry missing
> + status = "okay";
> +};
> +
> +&lpass_wsa_macro {
> + status = "okay";
> +};
> +
> &mdss {
> status = "okay";
> };
> @@ -1039,6 +1048,32 @@ &sdhc_2 {
> status = "okay";
> };
>
> +&swr2 {
> + status = "okay";
> +
> + left_spkr: speaker@0,1 {
> + compatible = "sdw10217020200";
> + reg = <0 1>;
> + powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
> + #sound-dai-cells = <0>;
> + sound-name-prefix = "SpkrLeft";
> + #thermal-sensor-cells = <0>;
> + vdd-supply = <&vreg_l18b_1p8>;
> + qcom,port-mapping = <1 2 3 7>;
> + };
> +
> + right_spkr: speaker@0,2 {
> + compatible = "sdw10217020200";
> + reg = <0 2>;
> + powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
> + #sound-dai-cells = <0>;
> + sound-name-prefix = "SpkrRight";
> + #thermal-sensor-cells = <0>;
> + vdd-supply = <&vreg_l18b_1p8>;
> + qcom,port-mapping = <4 5 6 8>;
> + };
> +};
> +
> &tlmm {
> gpio-reserved-ranges = <32 2>, /* ADSP */
> <48 4>; /* NFC */
> --
> 2.34.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH v4 6/8] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card
2025-05-27 11:12 [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Prasad Kumpatla
` (4 preceding siblings ...)
2025-05-27 11:12 ` [PATCH v4 5/8] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier Prasad Kumpatla
@ 2025-05-27 11:12 ` Prasad Kumpatla
2025-05-27 12:00 ` Krzysztof Kozlowski
2025-05-27 11:12 ` [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec Prasad Kumpatla
` (2 subsequent siblings)
8 siblings, 1 reply; 31+ messages in thread
From: Prasad Kumpatla @ 2025-05-27 11:12 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, quic_pkumpatl, kernel,
Mohammad Rafi Shaik, Konrad Dybcio, Dmitry Baryshkov
From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Add the sound card node with tested playback over WSA8835 speakers
and digital on-board mics.
Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 45 ++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index 21cb392c36fa..c9beeccaa019 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -1048,6 +1048,51 @@ &sdhc_2 {
status = "okay";
};
+&sound {
+ compatible = "qcom,qcs6490-rb3gen2-sndcard";
+ model = "qcs6490-rb3gen2-snd-card";
+
+ audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT",
+ "SpkrRight IN", "WSA_SPK2 OUT",
+ "VA DMIC0", "vdd-micb",
+ "VA DMIC1", "vdd-micb",
+ "VA DMIC2", "vdd-micb",
+ "VA DMIC3", "vdd-micb";
+
+ wsa-dai-link {
+ link-name = "WSA Playback";
+
+ codec {
+ sound-dai = <&left_spkr>, <&right_spkr>,
+ <&swr2 0>, <&lpass_wsa_macro 0>;
+ };
+
+ cpu {
+ sound-dai = <&q6apmbedai WSA_CODEC_DMA_RX_0>;
+ };
+
+ platform {
+ sound-dai = <&q6apm>;
+ };
+ };
+
+ va-dai-link {
+ link-name = "VA Capture";
+
+ codec {
+ sound-dai = <&lpass_va_macro 0>;
+ };
+
+ cpu {
+ sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
+ };
+
+ platform {
+ sound-dai = <&q6apm>;
+ };
+ };
+};
+
&swr2 {
status = "okay";
--
2.34.1
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [PATCH v4 6/8] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card
2025-05-27 11:12 ` [PATCH v4 6/8] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card Prasad Kumpatla
@ 2025-05-27 12:00 ` Krzysztof Kozlowski
2025-06-01 12:56 ` Prasad Kumpatla
0 siblings, 1 reply; 31+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-27 12:00 UTC (permalink / raw)
To: Prasad Kumpatla, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik,
Konrad Dybcio, Dmitry Baryshkov
On 27/05/2025 13:12, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>
> Add the sound card node with tested playback over WSA8835 speakers
> and digital on-board mics.
>
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 45 ++++++++++++++++++++
> 1 file changed, 45 insertions(+)
Don't add one-node per patch. Add entire sound for this board.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v4 6/8] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card
2025-05-27 12:00 ` Krzysztof Kozlowski
@ 2025-06-01 12:56 ` Prasad Kumpatla
0 siblings, 0 replies; 31+ messages in thread
From: Prasad Kumpatla @ 2025-06-01 12:56 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik,
Konrad Dybcio, Dmitry Baryshkov
On 5/27/2025 5:30 PM, Krzysztof Kozlowski wrote:
> On 27/05/2025 13:12, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>
>> Add the sound card node with tested playback over WSA8835 speakers
>> and digital on-board mics.
>>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 45 ++++++++++++++++++++
>> 1 file changed, 45 insertions(+)
>
>
> Don't add one-node per patch. Add entire sound for this board.
Ack, Will takecare in upcoming platforms.
Thanks,
Prasad>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec
2025-05-27 11:12 [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Prasad Kumpatla
` (5 preceding siblings ...)
2025-05-27 11:12 ` [PATCH v4 6/8] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card Prasad Kumpatla
@ 2025-05-27 11:12 ` Prasad Kumpatla
2025-05-28 12:20 ` Alexey Klimov
2025-05-31 12:35 ` Konrad Dybcio
2025-05-27 11:12 ` [PATCH v4 8/8] arm64: dts: qcom: qcm6490-idp: Add sound card Prasad Kumpatla
2025-05-27 14:17 ` [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Alexey Klimov
8 siblings, 2 replies; 31+ messages in thread
From: Prasad Kumpatla @ 2025-05-27 11:12 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, quic_pkumpatl, kernel,
Mohammad Rafi Shaik
From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Add nodes for WSA8830 speakers and WCD9370 headset codec
on qcm6490-idp board.
Enable lpass macros along with audio support pin controls.
Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
---
arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 96 +++++++++++++++++++
.../boot/dts/qcom/qcs6490-audioreach.dtsi | 24 +++++
2 files changed, 120 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index 7a155ef6492e..884abbda74fd 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -18,6 +18,7 @@
#include "pm7325.dtsi"
#include "pm8350c.dtsi"
#include "pmk8350.dtsi"
+#include "qcs6490-audioreach.dtsi"
/delete-node/ &ipa_fw_mem;
/delete-node/ &rmtfs_mem;
@@ -169,6 +170,30 @@ vph_pwr: vph-pwr-regulator {
regulator-min-microvolt = <3700000>;
regulator-max-microvolt = <3700000>;
};
+
+ wcd9370: audio-codec-0 {
+ compatible = "qcom,wcd9370-codec";
+
+ pinctrl-0 = <&wcd_default>;
+ pinctrl-names = "default";
+
+ reset-gpios = <&tlmm 83 GPIO_ACTIVE_HIGH>;
+
+ vdd-buck-supply = <&vreg_l17b_1p7>;
+ vdd-rxtx-supply = <&vreg_l18b_1p8>;
+ vdd-px-supply = <&vreg_l18b_1p8>;
+ vdd-mic-bias-supply = <&vreg_bob_3p296>;
+
+ qcom,micbias1-microvolt = <1800000>;
+ qcom,micbias2-microvolt = <1800000>;
+ qcom,micbias3-microvolt = <1800000>;
+ qcom,micbias4-microvolt = <1800000>;
+
+ qcom,rx-device = <&wcd937x_rx>;
+ qcom,tx-device = <&wcd937x_tx>;
+
+ #sound-dai-cells = <1>;
+ };
};
&apps_rsc {
@@ -536,6 +561,22 @@ &gpu_zap_shader {
firmware-name = "qcom/qcm6490/a660_zap.mbn";
};
+&lpass_rx_macro {
+ status = "okay";
+};
+
+&lpass_tx_macro {
+ status = "okay";
+};
+
+&lpass_va_macro {
+ status = "okay";
+};
+
+&lpass_wsa_macro {
+ status = "okay";
+};
+
&mdss {
status = "okay";
};
@@ -716,6 +757,54 @@ &sdhc_2 {
cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>;
};
+&swr0 {
+ status = "okay";
+
+ wcd937x_rx: codec@0,4 {
+ compatible = "sdw20217010a00";
+ reg = <0 4>;
+ qcom,rx-port-mapping = <1 2 3 4 5>;
+ qcom,rx-channel-mapping = /bits/ 8 <1 2 1 1 2 1 1 2>;
+ };
+};
+
+&swr1 {
+ status = "okay";
+
+ wcd937x_tx: codec@0,3 {
+ compatible = "sdw20217010a00";
+ reg = <0 3>;
+ qcom,tx-port-mapping = <1 1 2 3>;
+ qcom,tx-channel-mapping = /bits/ 8 <1 2 1 1 2 3 3 4 1 2 3 4>;
+ };
+};
+
+&swr2 {
+ status = "okay";
+
+ left_spkr: speaker@0,1 {
+ compatible = "sdw10217020200";
+ reg = <0 1>;
+ powerdown-gpios = <&tlmm 63 GPIO_ACTIVE_LOW>;
+ #sound-dai-cells = <0>;
+ sound-name-prefix = "SpkrLeft";
+ #thermal-sensor-cells = <0>;
+ vdd-supply = <&vreg_l18b_1p8>;
+ qcom,port-mapping = <1 2 3 7>;
+ };
+
+ right_spkr: speaker@0,2 {
+ compatible = "sdw10217020200";
+ reg = <0 2>;
+ powerdown-gpios = <&tlmm 62 GPIO_ACTIVE_LOW>;
+ #sound-dai-cells = <0>;
+ sound-name-prefix = "SpkrRight";
+ #thermal-sensor-cells = <0>;
+ vdd-supply = <&vreg_l18b_1p8>;
+ qcom,port-mapping = <4 5 6 8>;
+ };
+};
+
&tlmm {
gpio-reserved-ranges = <32 2>, /* ADSP */
<48 4>; /* NFC */
@@ -725,6 +814,13 @@ sd_cd: sd-cd-state {
function = "gpio";
bias-pull-up;
};
+
+ wcd_default: wcd-reset-n-active-state {
+ pins = "gpio83";
+ function = "gpio";
+ drive-strength = <16>;
+ bias-disable;
+ };
};
&uart5 {
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
index 542a39ca72bb..2e75e7706fb4 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
@@ -29,6 +29,30 @@ &lpass_dmic23_data {
bias-pull-down;
};
+&lpass_rx_swr_clk {
+ drive-strength = <2>;
+ slew-rate = <1>;
+ bias-disable;
+};
+
+&lpass_rx_swr_data {
+ drive-strength = <2>;
+ slew-rate = <1>;
+ bias-bus-hold;
+};
+
+&lpass_tx_swr_clk {
+ drive-strength = <2>;
+ slew-rate = <1>;
+ bias-disable;
+};
+
+&lpass_tx_swr_data {
+ drive-strength = <2>;
+ slew-rate = <1>;
+ bias-bus-hold;
+};
+
&lpass_rx_macro {
/delete-property/ power-domains;
/delete-property/ power-domain-names;
--
2.34.1
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec
2025-05-27 11:12 ` [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec Prasad Kumpatla
@ 2025-05-28 12:20 ` Alexey Klimov
2025-06-01 12:58 ` Prasad Kumpatla
2025-05-31 12:35 ` Konrad Dybcio
1 sibling, 1 reply; 31+ messages in thread
From: Alexey Klimov @ 2025-05-28 12:20 UTC (permalink / raw)
To: Prasad Kumpatla, Mohammad Rafi Shaik
Cc: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio, cros-qcom-dts-watchers, linux-arm-msm, linux-gpio,
devicetree, linux-kernel, linux-sound, kernel
On Tue May 27, 2025 at 12:12 PM BST, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>
> Add nodes for WSA8830 speakers and WCD9370 headset codec
> on qcm6490-idp board.
>
> Enable lpass macros along with audio support pin controls.
>
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 96 +++++++++++++++++++
> .../boot/dts/qcom/qcs6490-audioreach.dtsi | 24 +++++
> 2 files changed, 120 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index 7a155ef6492e..884abbda74fd 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -18,6 +18,7 @@
> #include "pm7325.dtsi"
[..]
> +&swr0 {
> + status = "okay";
> +
> + wcd937x_rx: codec@0,4 {
> + compatible = "sdw20217010a00";
> + reg = <0 4>;
> + qcom,rx-port-mapping = <1 2 3 4 5>;
> + qcom,rx-channel-mapping = /bits/ 8 <1 2 1 1 2 1 1 2>;
> + };
> +};
> +
> +&swr1 {
> + status = "okay";
> +
> + wcd937x_tx: codec@0,3 {
> + compatible = "sdw20217010a00";
> + reg = <0 3>;
> + qcom,tx-port-mapping = <1 1 2 3>;
> + qcom,tx-channel-mapping = /bits/ 8 <1 2 1 1 2 3 3 4 1 2 3 4>;
It will be tremendously useful to add comments that elaborate the {rx,tx}-channel-mapping
(and port mapping for what it's worth) here like it is done in other dt files.
For example in the same way as it is done in sm8650-qrd.dts
or like here:
https://lore.kernel.org/linux-arm-msm/20250526-sm8750-audio-part-2-v3-3-74429c686bb1@linaro.org/
Best regards,
Alexey
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec
2025-05-28 12:20 ` Alexey Klimov
@ 2025-06-01 12:58 ` Prasad Kumpatla
0 siblings, 0 replies; 31+ messages in thread
From: Prasad Kumpatla @ 2025-06-01 12:58 UTC (permalink / raw)
To: Alexey Klimov, Mohammad Rafi Shaik
Cc: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio, cros-qcom-dts-watchers, linux-arm-msm, linux-gpio,
devicetree, linux-kernel, linux-sound, kernel
On 5/28/2025 5:50 PM, Alexey Klimov wrote:
> It will be tremendously useful to add comments that elaborate the {rx,tx}-channel-mapping
> (and port mapping for what it's worth) here like it is done in other dt files.
> For example in the same way as it is done in sm8650-qrd.dts
Ack, Will add more info.
Thanks,
Prasad
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec
2025-05-27 11:12 ` [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec Prasad Kumpatla
2025-05-28 12:20 ` Alexey Klimov
@ 2025-05-31 12:35 ` Konrad Dybcio
2025-06-01 12:58 ` Prasad Kumpatla
1 sibling, 1 reply; 31+ messages in thread
From: Konrad Dybcio @ 2025-05-31 12:35 UTC (permalink / raw)
To: Prasad Kumpatla, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 5/27/25 1:12 PM, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>
> Add nodes for WSA8830 speakers and WCD9370 headset codec
> on qcm6490-idp board.
>
> Enable lpass macros along with audio support pin controls.
>
> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> ---
[...]
> &uart5 {
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> index 542a39ca72bb..2e75e7706fb4 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
> @@ -29,6 +29,30 @@ &lpass_dmic23_data {
> bias-pull-down;
> };
>
> +&lpass_rx_swr_clk {
> + drive-strength = <2>;
> + slew-rate = <1>;
> + bias-disable;
> +};
> +
> +&lpass_rx_swr_data {
> + drive-strength = <2>;
> + slew-rate = <1>;
> + bias-bus-hold;
> +};
> +
> +&lpass_tx_swr_clk {
> + drive-strength = <2>;
> + slew-rate = <1>;
> + bias-disable;
> +};
> +
> +&lpass_tx_swr_data {
> + drive-strength = <2>;
> + slew-rate = <1>;
> + bias-bus-hold;
> +};
All other DTs that overwrite these pins seem to be setting the
exact same settings.. And given this pin is connected to an on-SoC
peripheral, I think it would make sense to consolidate these in
sc7280.dtsi
Konrad
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec
2025-05-31 12:35 ` Konrad Dybcio
@ 2025-06-01 12:58 ` Prasad Kumpatla
0 siblings, 0 replies; 31+ messages in thread
From: Prasad Kumpatla @ 2025-06-01 12:58 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 5/31/2025 6:05 PM, Konrad Dybcio wrote:
> On 5/27/25 1:12 PM, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>
>> Add nodes for WSA8830 speakers and WCD9370 headset codec
>> on qcm6490-idp board.
>>
>> Enable lpass macros along with audio support pin controls.
>>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> ---
>
> [...]
>
>> &uart5 {
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
>> index 542a39ca72bb..2e75e7706fb4 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi
>> @@ -29,6 +29,30 @@ &lpass_dmic23_data {
>> bias-pull-down;
>> };
>>
>> +&lpass_rx_swr_clk {
>> + drive-strength = <2>;
>> + slew-rate = <1>;
>> + bias-disable;
>> +};
>> +
>> +&lpass_rx_swr_data {
>> + drive-strength = <2>;
>> + slew-rate = <1>;
>> + bias-bus-hold;
>> +};
>> +
>> +&lpass_tx_swr_clk {
>> + drive-strength = <2>;
>> + slew-rate = <1>;
>> + bias-disable;
>> +};
>> +
>> +&lpass_tx_swr_data {
>> + drive-strength = <2>;
>> + slew-rate = <1>;
>> + bias-bus-hold;
>> +};
>
> All other DTs that overwrite these pins seem to be setting the
> exact same settings.. And given this pin is connected to an on-SoC
> peripheral, I think it would make sense to consolidate these in
> sc7280.dtsi
Ack
Thanks,
Prasad
>
> Konrad
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH v4 8/8] arm64: dts: qcom: qcm6490-idp: Add sound card
2025-05-27 11:12 [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Prasad Kumpatla
` (6 preceding siblings ...)
2025-05-27 11:12 ` [PATCH v4 7/8] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec Prasad Kumpatla
@ 2025-05-27 11:12 ` Prasad Kumpatla
2025-05-27 14:17 ` [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Alexey Klimov
8 siblings, 0 replies; 31+ messages in thread
From: Prasad Kumpatla @ 2025-05-27 11:12 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Srinivas Kandagatla, Liam Girdwood, Mark Brown,
Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, quic_pkumpatl, kernel,
Mohammad Rafi Shaik
From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Add the sound card node with tested playback over WSA8835 speakers,
digital on-board mics along with wcd9370 headset playabck and record.
Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
---
arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 84 ++++++++++++++++++++++++
1 file changed, 84 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index 884abbda74fd..9147fbc9d2f8 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -757,6 +757,90 @@ &sdhc_2 {
cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>;
};
+&sound {
+ compatible = "qcom,qcm6490-idp-sndcard";
+ model = "qcm6490-idp-snd-card";
+
+ audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT",
+ "SpkrRight IN", "WSA_SPK2 OUT",
+ "IN1_HPHL", "HPHL_OUT",
+ "IN2_HPHR", "HPHR_OUT",
+ "AMIC2", "MIC BIAS2",
+ "TX DMIC0", "MIC BIAS1",
+ "TX DMIC1", "MIC BIAS2",
+ "TX DMIC2", "MIC BIAS3",
+ "TX SWR_ADC1", "ADC2_OUTPUT",
+ "VA DMIC0", "VA MIC BIAS3",
+ "VA DMIC1", "VA MIC BIAS3",
+ "VA DMIC2", "VA MIC BIAS1",
+ "VA DMIC3", "VA MIC BIAS1";
+
+ wsa-dai-link {
+ link-name = "WSA Playback";
+
+ codec {
+ sound-dai = <&left_spkr>, <&right_spkr>,
+ <&swr2 0>, <&lpass_wsa_macro 0>;
+ };
+
+ cpu {
+ sound-dai = <&q6apmbedai WSA_CODEC_DMA_RX_0>;
+ };
+
+ platform {
+ sound-dai = <&q6apm>;
+ };
+ };
+
+ wcd-playback-dai-link {
+ link-name = "WCD Playback";
+
+ codec {
+ sound-dai = <&wcd9370 0>, <&swr0 0>, <&lpass_rx_macro 0>;
+ };
+
+ cpu {
+ sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>;
+ };
+
+ platform {
+ sound-dai = <&q6apm>;
+ };
+ };
+
+ wcd-capture-dai-link {
+ link-name = "WCD Capture";
+
+ codec {
+ sound-dai = <&wcd9370 1>, <&swr1 0>, <&lpass_tx_macro 0>;
+ };
+
+ cpu {
+ sound-dai = <&q6apmbedai TX_CODEC_DMA_TX_3>;
+ };
+
+ platform {
+ sound-dai = <&q6apm>;
+ };
+ };
+
+ va-dai-link {
+ link-name = "VA Capture";
+
+ codec {
+ sound-dai = <&lpass_va_macro 0>;
+ };
+
+ cpu {
+ sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
+ };
+
+ platform {
+ sound-dai = <&q6apm>;
+ };
+ };
+};
+
&swr0 {
status = "okay";
--
2.34.1
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards
2025-05-27 11:12 [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Prasad Kumpatla
` (7 preceding siblings ...)
2025-05-27 11:12 ` [PATCH v4 8/8] arm64: dts: qcom: qcm6490-idp: Add sound card Prasad Kumpatla
@ 2025-05-27 14:17 ` Alexey Klimov
2025-06-01 13:01 ` Prasad Kumpatla
8 siblings, 1 reply; 31+ messages in thread
From: Alexey Klimov @ 2025-05-27 14:17 UTC (permalink / raw)
To: Prasad Kumpatla, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On Tue May 27, 2025 at 12:12 PM BST, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>
> Audio support is now enabled on the qcs6490-RB3Gen2 and qcm6490-idp boards.
> The updates include adding the necessary audio device tree support and the required
> dependencies.
Do you have topology file and mixers commands (or UCM profile) to test this?
I already asked but I don't see any replies. How this can be tested?
Thanks,
Alexey
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards
2025-05-27 14:17 ` [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Alexey Klimov
@ 2025-06-01 13:01 ` Prasad Kumpatla
2025-06-02 5:16 ` Dmitry Baryshkov
0 siblings, 1 reply; 31+ messages in thread
From: Prasad Kumpatla @ 2025-06-01 13:01 UTC (permalink / raw)
To: Alexey Klimov, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio
Cc: cros-qcom-dts-watchers, linux-arm-msm, linux-gpio, devicetree,
linux-kernel, linux-sound, kernel, Mohammad Rafi Shaik
On 5/27/2025 7:47 PM, Alexey Klimov wrote:
> On Tue May 27, 2025 at 12:12 PM BST, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>
>> Audio support is now enabled on the qcs6490-RB3Gen2 and qcm6490-idp boards.
>> The updates include adding the necessary audio device tree support and the required
>> dependencies.
>
> Do you have topology file and mixers commands (or UCM profile) to test this?
>
> I already asked but I don't see any replies. How this can be tested?
please use these below UCM config files
https://github.com/mohsRafi/alsa-ucm-conf/blob/qcs6490_qcm6490_hifi/ucm2/Qualcomm/qcs6490/QCS6490-RB3Gen2/HiFi.conf
https://github.com/mohsRafi/alsa-ucm-conf/blob/qcs6490_qcm6490_hifi/ucm2/Qualcomm/qcm6490/QCM6490-IDP/HiFi.conf
Thanks,
Prasad
>
> Thanks,
> Alexey
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH v4 0/8] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards
2025-06-01 13:01 ` Prasad Kumpatla
@ 2025-06-02 5:16 ` Dmitry Baryshkov
0 siblings, 0 replies; 31+ messages in thread
From: Dmitry Baryshkov @ 2025-06-02 5:16 UTC (permalink / raw)
To: Prasad Kumpatla
Cc: Alexey Klimov, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Srinivas Kandagatla,
Liam Girdwood, Mark Brown, Konrad Dybcio, cros-qcom-dts-watchers,
linux-arm-msm, linux-gpio, devicetree, linux-kernel, linux-sound,
kernel, Mohammad Rafi Shaik
On Sun, 1 Jun 2025 at 16:02, Prasad Kumpatla <quic_pkumpatl@quicinc.com> wrote:
>
>
>
> On 5/27/2025 7:47 PM, Alexey Klimov wrote:
> > On Tue May 27, 2025 at 12:12 PM BST, Prasad Kumpatla wrote:
> >> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> >>
> >> Audio support is now enabled on the qcs6490-RB3Gen2 and qcm6490-idp boards.
> >> The updates include adding the necessary audio device tree support and the required
> >> dependencies.
> >
> > Do you have topology file and mixers commands (or UCM profile) to test this?
> >
> > I already asked but I don't see any replies. How this can be tested?
>
> please use these below UCM config files
> https://github.com/mohsRafi/alsa-ucm-conf/blob/qcs6490_qcm6490_hifi/ucm2/Qualcomm/qcs6490/QCS6490-RB3Gen2/HiFi.conf
>
> https://github.com/mohsRafi/alsa-ucm-conf/blob/qcs6490_qcm6490_hifi/ucm2/Qualcomm/qcm6490/QCM6490-IDP/HiFi.conf
Is there anything there that isn't a part of the 1.2.14 release of
alsa-ucm-conf?
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 31+ messages in thread