From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EEE627703D for ; Tue, 27 May 2025 15:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748361366; cv=none; b=NoH1WgKzo1+bPVhwexCfuLtvzwyOk0slLhANlAUIOp3iXwoSz/QKQIgHVPmmCHB/DdJPlAZAMLMvgpYJMzus9omcDGdZLSSag/AF4leXVg+cqu0rdndgN4N2+vi7G0vW3aWpXinSVj5rNPqyH7+nH7NHolhPQTdVB+P5nzwbju8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748361366; c=relaxed/simple; bh=1EN/qo7phDn1lEOJKo1bEU9nZpbFRZxjY4LQ8qzGqFI=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=oBXuAO8IS7rAES2Dz2vpsOaSRK2BdRaMd6AOlbK9Azqla7nAcbKP5yJej9oWzfS4JCeB3rKUiYQ6SNJBA1GueFRgbPl/J9uAnrWuWdbPyKB9IFvxhFBYQXWlR8ECU+OwenrT0gNIon+d08Uf7yF3huPGME08BveFd95GD9rurnw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=D9+bMXgB; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D9+bMXgB" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43cfe574976so28445685e9.1 for ; Tue, 27 May 2025 08:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748361361; x=1748966161; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WUOHpXno4FKjbaz+Vq7mO6g3BDL4JOg348p7rmPIkO0=; b=D9+bMXgBs7Whru0LXz2r8gO7XmJknG9G4OyDwi7ccJ1O7tl45N6R2SM7BXlixt0hbN p+wdfVF4mcWYrxKOqKhvj5QneCwW0HGgbkSstk3ZSOqrISIK3XRYzvLmmnzRQcbjjRHH roaC8DMpMmT2XxdheJluYHIFNAblObzopbfDiKrdzVWHIiWy5kg4klQ/FvzPd7IprvWV s2anymuNGOFM8TWZP+3Tj9DyWDwW26vmtZaLmJotryTT3NJunu2hHKQ+jEqerXwKSf8o Tkr6cB1LTmEUnzw3ZhBFOi+plBdu6UPT4yuFFT53IWUA0E191w2W7eIfDOyxRRBEzWMR B2Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748361361; x=1748966161; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WUOHpXno4FKjbaz+Vq7mO6g3BDL4JOg348p7rmPIkO0=; b=Qt69azcdS8v2CtrOSiGbkSwW2/GMTYYj4l8SGaPfyDdtoV+zpe/mpbeyZ09kQdlDQ8 LicMXJd6EETOrUC9qaGdUiXDV0neW7yQ3sfOYFoHjSBODmgHrL2x6JSUrFzZPrSgUlSp IOUjnBjR8DyfJQTmjFmkNliY7q5sfYYculS3lqzxGiHo6RvEhmT3S2rT/YagXHw06wRa alJyEUAyDGpBlOSjcb6uCwSUwaXyijmKf3jz4mSRk0iwE2Obcb/khgDTjwHuVqYEpw+f XO9PYznkg+MycpfFQbY1RPOWu75PQIpNrUIfVsqeYzxAJG+13rhfytDNdBZBU+U/8thz YIxw== X-Forwarded-Encrypted: i=1; AJvYcCWl0aqAqTWHgm5hTB+rBXUK49eqjinjJUX/QnK95ynHSf/I3F22nKxsNXlWvbAznmilVGF0FYTQxxMv@vger.kernel.org X-Gm-Message-State: AOJu0Yy9/qV4YE3lH/oNmDS4tBlLOBts/mMc5Wi2nzxi1F9P+v/wav4s swimyfGIgTr8zs4XfYCZQJW1WRj0z6ofPcFj0Z3c7rZVBvsZYWU4xybnfMnKBQAUsLq0palD/Nn dACnT X-Gm-Gg: ASbGncuRCYtfVkoBdE3aHoZNv7LKC3ScCwEPEhlPHGqya8dDlP2JN52N/+hZTQjhCIP fTW7jtRBxvlSxWJXyWLsMZSm9wf7HQpd7VH7SGqMD3DFd5aW9ziqGGs3e0NQGvHJC6oJOYC5UKB a48vvLX/pBe39L2JeE6NOZn3n4URRs9t+LQ4hEPYZHq9GWpQd1MaFWAG5sdmxow5DfAQPwd64Lp nGSAe9/WKxu/L40d9Jh4NdJWR8HKwv8VJzOlUKe9UEO63QbaJWt5DwQwUhMqBtd2bSKhtGX8K8w gHyZCwlmHvWM+HaBKzWNOjMr0suU/nGNI63HRIUGXnf5TLOUj054jgNeSaciYZBZdG2C X-Google-Smtp-Source: AGHT+IGWpBubqNiiMJO9C0pBAekzBnLwiPK9uY689/6fUTlai3/xs++Qb/ljE1+USh/yGxcE4+gWhA== X-Received: by 2002:a05:600c:6296:b0:43c:f616:f08 with SMTP id 5b1f17b1804b1-44c91ad6b46mr120335515e9.8.1748361360729; Tue, 27 May 2025 08:56:00 -0700 (PDT) Received: from localhost ([2a02:c7c:7213:c700:f024:90b8:5947:4156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f1ef0ab8sm270595235e9.13.2025.05.27.08.55.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 May 2025 08:55:59 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 27 May 2025 16:55:59 +0100 Message-Id: Cc: "Liam Girdwood" , "Rob Herring" , "Krzysztof Kozlowski" , "Krzysztof Kozlowski" , "Conor Dooley" , "Bjorn Andersson" , "Dmitry Baryshkov" , "Konrad Dybcio" , "Jaroslav Kysela" , "Takashi Iwai" , , , , Subject: Re: [PATCH v3 10/12] arm64: dts: qcom: qrb4210-rb2: enable wsa881x amplifier From: "Alexey Klimov" To: "Konrad Dybcio" , "Srinivas Kandagatla" , "Mark Brown" , X-Mailer: aerc 0.20.0 References: <20250522-rb2_audio_v3-v3-0-9eeb08cab9dc@linaro.org> <20250522-rb2_audio_v3-v3-10-9eeb08cab9dc@linaro.org> In-Reply-To: On Thu May 22, 2025 at 7:13 PM BST, Konrad Dybcio wrote: > On 5/22/25 7:41 PM, Alexey Klimov wrote: >> One WSA881X amplifier is connected on QRB4210 RB2 board >> hence only mono speaker is supported. This amplifier is set >> to work in analog mode only. Also add required powerdown >> pin/gpio. >>=20 >> Cc: Srinivas Kandagatla >> Signed-off-by: Alexey Klimov >> --- >> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 26 +++++++++++++++++++++++++= + >> 1 file changed, 26 insertions(+) >>=20 >> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/= dts/qcom/qrb4210-rb2.dts >> index 6bce63720cfffd8e0e619937fb1f365cbbbcb283..4b878e585227ee6b3b362108= be96aad99acba21d 100644 >> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts >> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts >> @@ -270,6 +270,24 @@ zap-shader { >> }; >> }; >> =20 >> +&i2c1 { >> + clock-frequency =3D <400000>; >> + status =3D "okay"; >> + >> + wsa881x: amplifier@f { >> + compatible =3D "qcom,wsa8815"; >> + reg =3D <0x0f>; >> + pinctrl-0 =3D <&wsa_en_active>; >> + pinctrl-names =3D "default"; >> + clocks =3D <&q6afecc LPASS_CLK_ID_MCLK_2 LPASS_CLK_ATTRIBUTE_COUPLE_N= O>; >> + powerdown-gpios =3D <&lpass_tlmm 16 GPIO_ACTIVE_LOW>; >> + mclk-gpios =3D <&lpass_tlmm 18 GPIO_ACTIVE_HIGH>; >> + sound-name-prefix =3D "SpkrMono"; >> + #sound-dai-cells =3D <0>; >> + #thermal-sensor-cells =3D <0>; >> + }; >> +}; >> + >> &i2c2_gpio { >> clock-frequency =3D <400000>; >> status =3D "okay"; >> @@ -736,6 +754,14 @@ wcd_reset_n: wcd-reset-n-state { >> drive-strength =3D <16>; >> output-high; >> }; >> + >> + wsa_en_active: wsa-en-active-state { >> + pins =3D "gpio106"; > > Are there two separate enable pins? Or is the powerdown-gpio something > else? No, should be only one. I think 106 on tlmm is wired into 16 on lpass tlmm. We need to assign gpio function to such pins, aren't we? Best regards, Alexey