From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53E6E289370 for ; Fri, 20 Jun 2025 11:07:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750417674; cv=none; b=lCAD9grUm6vDv8VpOE0hBlevFGDtuDwuSk/GTuRChQQIQwufaAvIdYMg00V/V4D+WJJXjvwnvOpV6rcMM7Jq9rF1PEZ+NmYJ1i81BlUcSQTnKYmX/BK0yn4YuioguWE6KiLjdAyPBWzRTIaKvy1ED2kG87Is+X0JEKF/vhaTblQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750417674; c=relaxed/simple; bh=5HesFEa+oG4aphhrLr+nJlzSqRvni+h3KcLsQ1xkANk=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=SXmouawLZxLVRWy6jklhyV1iSO+tVnkS4s98RI5d1TdejLWYENloj7bQLN2IH8DhpotAedQddLbHrsx2kMi+oxg49HASFU/BCvrEqfFBmEGUeL1QmHRCMYfkv7aagBsazzFb7k1zlIP65PWVtyKmdhHNG8K6Dk+nTMF6Wdh7XWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=pCk3JC2i; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="pCk3JC2i" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ad891bb0957so309310866b.3 for ; Fri, 20 Jun 2025 04:07:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1750417670; x=1751022470; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=j56NnU+C4rZ3igsVwK0poqCyRvUi8MRY+wsVdUJRvmo=; b=pCk3JC2itRdrtMHpyl/KtfjpWU4/ubo3IODY1ZqbHYJub+ClHinzIsX3uYkPTr+Wkv HKO2JsK4TAtsFdWcVXv3OHo9ufi+3URf7L+R/Ssym+7xES/KvVRriZ+Zk+D3Ep5Q/5/4 4jnfOjKDrCRQ8q9nDp82slDwXOixhgwOKXdgvgtc1etb+I85yn/uq2EK9vZGtVX2nuBU 95wQxRuOJh0LRvU7e4dc2atXOAJAySSbqWrQXQX/ib23dH9+BH+rsCrNiJTljXt610VW HVmuHHppIuwAPJMX5aB2PE8mW1ztCMXNafL5JOc8rwzwlJBK5dujv7P2nqIgf1PuZgjc zoAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750417670; x=1751022470; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j56NnU+C4rZ3igsVwK0poqCyRvUi8MRY+wsVdUJRvmo=; b=EHniyQy2RFFRQc53yFojICHQxMEcXVVYz9YkuFG3kEKFoXKicsiiglBR7bRvTMUR5h LwB5++d//Zyup/QJAcGwBGajxmNkoGx8bWkwqBQBLZ90UwcgvBHtrU7YmseD+G2HQtBB 2VuEYjMVs2aBVw3JiOpuYc24Go/N28qDCIIZMIrJD/AqPoAf0G2oIo4aygiFpZX0lkQS jfuDccXMViNGGV3XY2J+LZ7GLdM++p+ABoRnDVLApO/PsPuEIXk9/v9jCFaub+qMMyP8 QaZv5cqMzcf+9Imj+KMYYfU/OLYlm8Xiub/P7qv6FyG5+nNXXXm7gUsSr3UTOixdJx8F +ikg== X-Forwarded-Encrypted: i=1; AJvYcCVXDUDxr9jJAEMiDZerKzDH994WLlcimm3Kj0q8eh0Kxx2zHN+7qWF9+Ckhc8iBAg+GAQ+9GZ3TUmIw@vger.kernel.org X-Gm-Message-State: AOJu0YxGdTjNOxHuVh5s5gISDnLZwvfzsLg1QDbTsk+wCju2zea+SV7R U6DrAzPDhgE9RMEcoVgRHV8tlanJO2ySsPpyzyrcVzEkZ3mOxmLeUjUhhpwfand2gs4= X-Gm-Gg: ASbGncsjjvWZyWex+a+o/lK/rqgHkxrruYOCWE5J5VIoXSW7gLUiyEZlxZTTt4/f/gC SOal9Z1CdgOf0Fl0qPqCEvpYkXA8If7aTZYV96hwxFqoj0UydquolYDJ6hqs30qIT0FZA6KZXGt Tc5ChvucfJfLTgOXGcXaxKejWFxCO13ej3QscWavhNlmI5hkMKH0H9/uG1zdKretPTj/WG8VSgD PzpoSs1ETyNIwx20W43v9ZgICDEXknyScLlLt9JsjlBs/ELYJlDT/FzlsE+8Dww1JF3VA2UEWhr KHzoidxOVc34VSn6rCqoMG6tlHYwwr7yX1UKIL4t63lMNA5c2aov6QSavdrqHQn4mgURFGnYggF v8hYiyX6Ie61rkSvvOsp+SnZI1Z2/fr8= X-Google-Smtp-Source: AGHT+IHi2VbmsYUmEDnp9Sif2RGnVt1dOueBmIGckoT6F8WA4k68tCAYn7k5QT+Eg9xqzhehbqW5mA== X-Received: by 2002:a17:906:6a03:b0:ad8:8621:9241 with SMTP id a640c23a62f3a-ae057c7eef2mr239743066b.54.1750417670525; Fri, 20 Jun 2025 04:07:50 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae053ee4c90sm147879866b.62.2025.06.20.04.07.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jun 2025 04:07:50 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 Jun 2025 13:07:49 +0200 Message-Id: Cc: , , , Subject: Re: [PATCH 3/3] fbdev/simplefb: Add support for interconnect paths From: "Luca Weiss" To: "Thomas Zimmermann" , "Hans de Goede" , "Maarten Lankhorst" , "Maxime Ripard" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Javier Martinez Canillas" , "Helge Deller" X-Mailer: aerc 0.20.1-0-g2ecb8770224a-dirty References: <20250620-simple-drm-fb-icc-v1-0-d92142e8f74f@fairphone.com> <20250620-simple-drm-fb-icc-v1-3-d92142e8f74f@fairphone.com> In-Reply-To: Hi Thomas, On Fri Jun 20, 2025 at 1:02 PM CEST, Thomas Zimmermann wrote: > Hi > > Am 20.06.25 um 12:31 schrieb Luca Weiss: >> Some devices might require keeping an interconnect path alive so that >> the framebuffer continues working. Add support for that by setting the >> bandwidth requirements appropriately for all provided interconnect >> paths. >> >> Signed-off-by: Luca Weiss >> --- >> drivers/video/fbdev/simplefb.c | 83 ++++++++++++++++++++++++++++++++++= ++++++++ >> 1 file changed, 83 insertions(+) >> >> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simple= fb.c >> index be95fcddce4c8ca794826b805cd7dad2985bd637..ca73e079fd13550ddc779e84= db80f7f9b743d074 100644 >> --- a/drivers/video/fbdev/simplefb.c >> +++ b/drivers/video/fbdev/simplefb.c >> @@ -27,6 +27,7 @@ >> #include >> #include >> #include >> +#include > > With alphabetical sorting: > > Reviewed-by: Thomas Zimmermann Thanks for the reviews! For both simpledrm.c and simplefb.c, the includes are not strictly alphabetically sorted (1 mis-sort in simpledrm, 3 in simplefb), shall I just try and slot it into the best fitting place, or make them sorted in my patch? Or I can add a separate commit for each driver before to sort them. Let me know! Regards Luca > > Best regards > Thomas > > >> =20 >> static const struct fb_fix_screeninfo simplefb_fix =3D { >> .id =3D "simple", >> @@ -89,6 +90,10 @@ struct simplefb_par { >> u32 regulator_count; >> struct regulator **regulators; >> #endif >> +#if defined CONFIG_OF && defined CONFIG_INTERCONNECT >> + unsigned int icc_count; >> + struct icc_path **icc_paths; >> +#endif >> }; >> =20 >> static void simplefb_clocks_destroy(struct simplefb_par *par); >> @@ -525,6 +530,80 @@ static int simplefb_attach_genpds(struct simplefb_p= ar *par, >> } >> #endif >> =20 >> +#if defined CONFIG_OF && defined CONFIG_PM_GENERIC_DOMAINS >> +/* >> + * Generic interconnect path handling code. >> + */ >> +static void simplefb_detach_icc(void *res) >> +{ >> + struct simplefb_par *par =3D res; >> + int i; >> + >> + for (i =3D par->icc_count - 1; i >=3D 0; i--) { >> + if (!IS_ERR_OR_NULL(par->icc_paths[i])) >> + icc_put(par->icc_paths[i]); >> + } >> +} >> + >> +static int simplefb_attach_icc(struct simplefb_par *par, >> + struct platform_device *pdev) >> +{ >> + struct device *dev =3D &pdev->dev; >> + int ret, count, i; >> + >> + count =3D of_count_phandle_with_args(dev->of_node, "interconnects", >> + "#interconnect-cells"); >> + if (count < 0) >> + return 0; >> + >> + /* An interconnect path consists of two elements */ >> + if (count % 2) { >> + dev_err(dev, "invalid interconnects value\n"); >> + return -EINVAL; >> + } >> + par->icc_count =3D count / 2; >> + >> + par->icc_paths =3D devm_kcalloc(dev, par->icc_count, >> + sizeof(*par->icc_paths), >> + GFP_KERNEL); >> + if (!par->icc_paths) >> + return -ENOMEM; >> + >> + for (i =3D 0; i < par->icc_count; i++) { >> + par->icc_paths[i] =3D of_icc_get_by_index(dev, i); >> + if (IS_ERR_OR_NULL(par->icc_paths[i])) { >> + ret =3D PTR_ERR(par->icc_paths[i]); >> + if (ret =3D=3D -EPROBE_DEFER) >> + goto err; >> + dev_err(dev, "failed to get interconnect path %u: %d\n", i, ret); >> + continue; >> + } >> + >> + ret =3D icc_set_bw(par->icc_paths[i], 0, UINT_MAX); >> + if (ret) { >> + dev_err(dev, "failed to set interconnect bandwidth %u: %d\n", i, ret= ); >> + continue; >> + } >> + } >> + >> + return devm_add_action_or_reset(dev, simplefb_detach_icc, par); >> + >> +err: >> + while (i) { >> + --i; >> + if (!IS_ERR_OR_NULL(par->icc_paths[i])) >> + icc_put(par->icc_paths[i]); >> + } >> + return ret; >> +} >> +#else >> +static int simplefb_attach_icc(struct simplefb_par *par, >> + struct platform_device *pdev) >> +{ >> + return 0; >> +} >> +#endif >> + >> static int simplefb_probe(struct platform_device *pdev) >> { >> int ret; >> @@ -615,6 +694,10 @@ static int simplefb_probe(struct platform_device *p= dev) >> if (ret < 0) >> goto error_regulators; >> =20 >> + ret =3D simplefb_attach_icc(par, pdev); >> + if (ret < 0) >> + goto error_regulators; >> + >> simplefb_clocks_enable(par, pdev); >> simplefb_regulators_enable(par, pdev); >> =20 >>