From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8734025DCF0 for ; Fri, 15 Aug 2025 12:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755259637; cv=none; b=XYOg9BGMwAenLc5zxFb3SeZ4W25EPnxkIT3erfztQf15ac59C4QQzv10n6Gn7XOCoVT+Ni8+cDeKzKatmAKSHuDBkqmZy/aMmHb0PSCIbAn0SUnay5jEUrBXdo1kk8yyp9lEAwTI6OfYwzzcjVJK05XHyNE0InE/+XEuZxSDDp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755259637; c=relaxed/simple; bh=d7mLkx2zmfajtsD8tZE+IyUM91Hth/Nqpv1oIfjVVHE=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=rma+igpHlXY4dQcacWIpLsieMXPUgjNrtdq0obXJcIKxWb4cyypcR/ZQYV3dUXGYrUtZs5zwnHmRybzzGUXI9OAjzqQOADMYqOwnYd35r9kWuJou7ItpTjvVV1gxB2Osqnf9X4wh1nS4Eu52nWvIVk4CHlI3ampjhnE+XRSa/KQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=obpPn8MQ; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="obpPn8MQ" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1755259632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S1snjcKnr5T+gZaU0t/7csMoaxio2O5nUXuj8A3C7QA=; b=obpPn8MQaE6sEdep1Ia26ok2jP1igFkswh5NXhZgsIanDEcTwThXpGlEMMPSaTT+CGYP/t /M+yOmjHMlDJbTfcTKnZKuntmX8kH707C+2MHeoi/kkI2KECDn7E/bJaXxQ9Ivbv2w5Eyr JnDtDhjtP7iu5QIpL5TxkJ3cjuR/ZiY6wqtRwKtza77rNlliSC4PErDNS1IjBLPdmcu+e0 8wNP7N3rWxVHBPRR1J+PuFQe9tuO2NcDq7SFRYCVs0NaC2X1In0rLqbOyfN4XDWq3Ar/CP ZRTBl6G3hY8XCXXzoiHvnIhk7T7DMIU7eFRLvRNs2fYjEiWBZVJUke/+tPvDGQ== Content-Type: multipart/signed; boundary=8624ee546faf8c26b2a96c7cf02ab2c1b94682b15dc888f8a0edb7954318; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Fri, 15 Aug 2025 14:06:49 +0200 Message-Id: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Krzysztof Kozlowski" , "Lee Jones" , "Pavel Machek" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" Cc: "Jacek Anaszewski" , , , , Subject: Re: [PATCH] dt-bindings: leds: Clearly mark label property as deprecated References: <20250815104805.405009-1-didi.debian@cknow.org> In-Reply-To: X-Migadu-Flow: FLOW_OUT --8624ee546faf8c26b2a96c7cf02ab2c1b94682b15dc888f8a0edb7954318 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Fri Aug 15, 2025 at 1:00 PM CEST, Krzysztof Kozlowski wrote: > On 15/08/2025 12:47, Diederik de Haas wrote: >> The text description already mentioned the label property was >> deprecated, but using the 'deprecated' property makes is clearer and >> more explicit. >>=20 >> Signed-off-by: Diederik de Haas >> --- >> Documentation/devicetree/bindings/leds/common.yaml | 1 + >> 1 file changed, 1 insertion(+) >>=20 > > Please first read previous discussions: [I reversed the order of the links so the oldest is first] > https://lore.kernel.org/all/20221122111124.6828-1-cniedermaier@dh-electro= nics.com/ Rob: "They ['function' and 'label'] serve 2 different purposes." > https://lore.kernel.org/all/20240509110545.49889-1-linux@fw-web.de/ Krzysztof: "I don't think there was conclusion to make it deprecated on last attempt" I agree. What I don't understand: Why wasn't the text updated to correct the incorrect statement about deprecation (that's how I interpret it now)? Or some other conclusion being made and that that will be reflected in the text and/or a deprecated property. Otherwise the confusion remains and then it's just a matter of time before a 4th person comes along proposing the same patch. And possibly even more harmful: people use it incorrectly. There's also this line: "function-enumerator has no effect when this property is present." if that is true, and I would assume so as that's what the binding says, then I messed up even bigger then I already think I did in commit 1631cbdb8089 ("arm64: dts: rockchip: Improve LED config for NanoPi R5S") resulting in commit 912b1f2a796e ("arm64: dts: rockchip: Drop netdev led-triggers on NanoPi R5S= ") ... but I'd have expected that to be pointed out in the review. I can understand that function-enumerator is used in an automatically generated label when a label doesn't exist, but I'm inclined to think the same "They serve 2 different purposes" applies here too. Cheers, Diederik --8624ee546faf8c26b2a96c7cf02ab2c1b94682b15dc888f8a0edb7954318 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCaJ8i5gAKCRDXblvOeH7b blHPAP47IybHAz/ehXhdDv8uUzgLK6trTHIF4sa580pxeE3YkQD+IT7PvgXPS4r7 s6gjTNa7I7J78T4OjK79J1SWdXcrgQg= =JWsI -----END PGP SIGNATURE----- --8624ee546faf8c26b2a96c7cf02ab2c1b94682b15dc888f8a0edb7954318--