* [PATCH 2/2] arm64: dts: rockchip: enable the Mali GPU on RK3328 boards
2025-08-30 11:51 [PATCH 1/2] arm64: dts: rockchip: add GPU powerdomain, opps, and cooling to rk3328 Christian Hewitt
@ 2025-08-30 11:51 ` Christian Hewitt
2025-09-02 13:17 ` [PATCH 1/2] arm64: dts: rockchip: add GPU powerdomain, opps, and cooling to rk3328 Rob Herring (Arm)
2025-09-06 10:45 ` Diederik de Haas
2 siblings, 0 replies; 4+ messages in thread
From: Christian Hewitt @ 2025-08-30 11:51 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Cc: Alex Bee
From: Alex Bee <knaerzche@gmail.com>
Add a gpu node to the rock64 board to enable the Mali GPU and
move the existing node from roc-pc to the shared roc dtsi to
enable it also for the roc-cc board.
Signed-off-by: Alex Bee <knaerzche@gmail.com>
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
Note: the a1 board already carries the same change. All other
RK3328 boards appear to be headless designs that have no HDMI
or obvious media capabilities, so no need for a gpu.
arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dts | 4 ----
arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi | 4 ++++
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 4 ++++
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dts
index 329d03172433..c0b7b98ff788 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dts
@@ -44,10 +44,6 @@ &codec {
mute-gpios = <&grf_gpio 0 GPIO_ACTIVE_LOW>;
};
-&gpu {
- mali-supply = <&vdd_logic>;
-};
-
&pinctrl {
ir {
ir_int: ir-int {
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi b/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi
index aa1d5a6d7fd5..3fe0c17fd2b1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi
@@ -167,6 +167,10 @@ &gmac2io {
status = "okay";
};
+&gpu {
+ mali-supply = <&vdd_logic>;
+};
+
&hdmi {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 5367e5fa9232..592fd8ca21df 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
@@ -152,6 +152,10 @@ &gmac2io {
status = "okay";
};
+&gpu {
+ mali-supply = <&vdd_logic>;
+};
+
&hdmi {
avdd-0v9-supply = <&vdd_10>;
avdd-1v8-supply = <&vcc_18>;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] arm64: dts: rockchip: add GPU powerdomain, opps, and cooling to rk3328
2025-08-30 11:51 [PATCH 1/2] arm64: dts: rockchip: add GPU powerdomain, opps, and cooling to rk3328 Christian Hewitt
2025-08-30 11:51 ` [PATCH 2/2] arm64: dts: rockchip: enable the Mali GPU on RK3328 boards Christian Hewitt
@ 2025-09-02 13:17 ` Rob Herring (Arm)
2025-09-06 10:45 ` Diederik de Haas
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-09-02 13:17 UTC (permalink / raw)
To: Christian Hewitt
Cc: Alex Bee, linux-kernel, Rob Herring, linux-rockchip, devicetree,
linux-arm-kernel, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner
On Sat, 30 Aug 2025 11:51:34 +0000, Christian Hewitt wrote:
> From: Alex Bee <knaerzche@gmail.com>
>
> Add GPU powerdomain, opp-table, and cooling map nodes for the Mali
> GPU on the RK3328 SoC. Opp-table frequencies are sourced from the
> Rockchip Linux v4.4 vendor kernel while voltages have been derived
> from practical use and support work: keeping voltage above 1075mV
> and disabling the 500MHz opp-point avoids instability and crashes.
>
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> These changes have been in-use with Armbian and LibreELEC for many
> years without issue. Investigations into crashing (esp. with rkvdec
> running) have led to voltage tweaks and dropping 500MHz. Changes
> cannot be justified in technical detail, but are field proven over
> a large number of users, boards, and cheap power supplies.
>
> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 39 +++++++++++++++++++++++-
> 1 file changed, 38 insertions(+), 1 deletion(-)
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: attempting to guess base-commit...
Base: tags/next-20250829 (best guess, 2/4 blobs matched)
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250830115135.3549305-1-christianshewitt@gmail.com:
arch/arm64/boot/dts/rockchip/rk3318-a95x-z2.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3318-a95x-z2.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-rock64.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-rock64.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2c.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2c.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-roc-pc.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2c-plus.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2c-plus.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-evb.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-evb.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus-lts.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus-lts.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-a1.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-a1.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dtb: gpu-opp-table (operating-points-v2): $nodename:0: 'gpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dtb: gpu-opp-table (operating-points-v2): Unevaluated properties are not allowed ('opp-200000000', 'opp-300000000', 'opp-400000000', 'opp-500000000' were unexpected)
from schema $id: http://devicetree.org/schemas/opp/opp-v2.yaml#
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] arm64: dts: rockchip: add GPU powerdomain, opps, and cooling to rk3328
2025-08-30 11:51 [PATCH 1/2] arm64: dts: rockchip: add GPU powerdomain, opps, and cooling to rk3328 Christian Hewitt
2025-08-30 11:51 ` [PATCH 2/2] arm64: dts: rockchip: enable the Mali GPU on RK3328 boards Christian Hewitt
2025-09-02 13:17 ` [PATCH 1/2] arm64: dts: rockchip: add GPU powerdomain, opps, and cooling to rk3328 Rob Herring (Arm)
@ 2025-09-06 10:45 ` Diederik de Haas
2 siblings, 0 replies; 4+ messages in thread
From: Diederik de Haas @ 2025-09-06 10:45 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Alex Bee
[-- Attachment #1: Type: text/plain, Size: 2751 bytes --]
Hi Christian,
On Sat Aug 30, 2025 at 1:51 PM CEST, Christian Hewitt wrote:
> From: Alex Bee <knaerzche@gmail.com>
>
> Add GPU powerdomain, opp-table, and cooling map nodes for the Mali
> GPU on the RK3328 SoC. Opp-table frequencies are sourced from the
I very recently saw a patch somewhere with these changes and wondered
why it wouldn't be sent upstream, so thanks for doing exactly that!
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
>
> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 39 +++++++++++++++++++++++-
> 1 file changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index 7d992c3c01ce..b99c78ecc4a9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -331,6 +331,11 @@ power: power-controller {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + power-domain@RK3328_PD_GPU {
> + reg = <RK3328_PD_GPU>;
> + clocks = <&cru ACLK_GPU>;
> + #power-domain-cells = <0>;
> + };
> power-domain@RK3328_PD_HEVC {
> reg = <RK3328_PD_HEVC>;
> clocks = <&cru SCLK_VENC_CORE>;
> @@ -570,9 +575,13 @@ map0 {
> <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> contribution = <4096>;
> };
> + map1 {
> + trip = <&target>;
> + cooling-device = <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + contribution = <4096>;
> + };
> };
> };
> -
> };
>
> tsadc: tsadc@ff250000 {
> @@ -651,7 +660,35 @@ gpu: gpu@ff300000 {
> "ppmmu1";
> clocks = <&cru ACLK_GPU>, <&cru ACLK_GPU>;
> clock-names = "bus", "core";
> + operating-points-v2 = <&gpu_opp_table>;
> + power-domains = <&power RK3328_PD_GPU>;
> resets = <&cru SRST_GPU_A>;
> + #cooling-cells = <2>;
> + };
> +
> + gpu_opp_table: gpu-opp-table {
As noticed by Rob's bot, this node name is incorrect.
If you do ``s/gpu-opp-table/opp-table-gpu/`` and move it to above the
'pinctrl' node, then DTB validation succeeds.
Cheers,
Diederik
> + compatible = "operating-points-v2";
> + opp-200000000 {
> + opp-hz = /bits/ 64 <200000000>;
> + opp-microvolt = <1075000>;
> + };
> +
> + opp-300000000 {
> + opp-hz = /bits/ 64 <300000000>;
> + opp-microvolt = <1075000>;
> + };
> +
> + opp-400000000 {
> + opp-hz = /bits/ 64 <400000000>;
> + opp-microvolt = <1075000>;
> + };
> +
> + opp-500000000 {
> + /* causes stability issues */
> + opp-hz = /bits/ 64 <500000000>;
> + opp-microvolt = <1150000>;
> + status = "disabled";
> + };
> };
>
> h265e_mmu: iommu@ff330200 {
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread