From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D22C2EF667 for ; Fri, 10 Oct 2025 12:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760099383; cv=none; b=eylKq2sGsJaBLyBUnjfcR1FZB0rhNk7LETUwQ8hblJdc6TSDx9zg7mcZYE1JFkP893lehXQlkuHsCRjw4W0Lq9qDYzrG+3kgTntR6z+Dvmw6Y8gqo9v+eV9p7ERCmPWhgimsrEFkjwcw3B1wDHqaXWkQKERxdRQIit4Zq+IyNVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760099383; c=relaxed/simple; bh=m1wtM/Q36F3ke3zT/mN2EGUWRd5HFQIpRI6HpOMa2zE=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=rwjGuR5E/BcudpXDDZJwwHP3UzPYTuoyYissec4HMG+fU9I0Xh002IC0FbJLDZ8GVRecff9fxdWOCQBofprqXpM99BuKWcV11Pxtme5AiW8J2tM93srqJa/I1F53qP0fqeRAkpxe0ZbjMXUE++f4134P4ibKEY7LGeqUuxfPxck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DRZMrdRV; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DRZMrdRV" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-46e2e6a708fso13381265e9.0 for ; Fri, 10 Oct 2025 05:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760099379; x=1760704179; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vYMGQwZbrkqXXfmRn4FZdpSz5oqSucZM1pi40huO1ec=; b=DRZMrdRV+Z7AOt2j3NT/pgUP4UzEXdxIMgHs7HJiAigBN8Yr//Fyi5ghKZLVI0KMr3 vhCnf9VSuH+vryIkrv2rC77HULFvgki0QuED2mD4cExxEc4h6sOCOlofOLHEWg46sCRp TGl5nPoI67IHz+TmR/v4ARQo5MlUbtD+aWLjOHCWE9BfM5aht7ia+Cg9j819ea6TVC1o czF5uB7FK2+9iFgyoVe+MsvdILYnaANCXdbrKZXzaAgXtUAO9QWymKObPF1Mk/xLsMRB wI9JFgvUOf5z3i0PDsOlgmoyFA+o00csP/DY6IYojpg99CeZ0QjSoJtdDu3+vZ5UT+GK Rwrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760099379; x=1760704179; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vYMGQwZbrkqXXfmRn4FZdpSz5oqSucZM1pi40huO1ec=; b=SFo2VzA/rxwHPlMI25yHXe/NJN87tt6gg7jBOo+zp/aq8G9dDjpP1df4o+nMpKcP+r F7PZmo24GQ1n1ohq5ynrU2i6wNS22RrluDgdYppxZTC+jv0+7GbINMZcEFBQ/KxEO6e/ qVNyenbmEziXXeUqfSRwk4hQR8MK2TyKczvYNWieTc+gUEr+Kv9zMU9k1JsQLdjSyhdQ tsnOi1nw+IWqgJUJqoMDFQVbTFmSPUPZJuMwIA/0Jwh8YBdSU/+Lf3Wo3er+FuuMCm5v dQFIaqeHbmJIryLue5bAFCp07+Kq9uCkL6+TpldtHCsi70k2gRjs6ZH/ZC3GsQ/jCuge /9aw== X-Forwarded-Encrypted: i=1; AJvYcCUrMIYmtUnkmtkr0Op9ndnpvcW8eCzmTiDq1rMkgugecglum7p5IUWJFqEj5heQM9nWMR3JBb0kL+IM@vger.kernel.org X-Gm-Message-State: AOJu0YzDvnosxihULXpB7d4rU2bV4E1wbigOG7Blto/8zk0OfJBOL3N5 jMLA5jdlVJTbk0zDaerDJbyRrcg4ReF+J3BkK1XAwobv8LybpjmccugQ0AO4Zg/GDlk= X-Gm-Gg: ASbGnctt56ScmO4fC4DW51kOCslJwo7oKt0HBv9Q7CJG6lQLYYY3ONOpEcBpEL1Lj3i YkQg1uNlVTjz6KVTzPSK1QLPZGXkKcgFF6No+Rr7/NcNvJqfCdO/44SNXBaWtGOm1ZYehwX3Fjc KmYozZpKR3mFnDw/sCHgUN5TXgSW6kahxYqDD1Kd1ZBOjvbGDuNtPi9zVnKTmQvjV7A9hky7owj /Eaag2drqX4PVVyjuc+oDq8bUI73KCWL50+KVVWbQ468QeCkKq9QaAfmZ9gEW83z7t75XGQEsml 3wlb0mChPb0wSgHCg33FWcnk3YLOfRRUGaw64+rlu2NAslzVjYeiDnD5tE9JeC7LVSgWtWrkM9S DiuFjfQQN7ZH6iA5p773+/tWM36hL/C7N6TO93YqIuHm0xzhDZnzkEeeJesm0CAtg93nT1rE= X-Google-Smtp-Source: AGHT+IGoFKx9FL3rwMgBVIjzsX+nvkrUpEkSRitHHR0xBr1fRpbwIRCWVFTLZ13CTdC6I1m0m5CVFw== X-Received: by 2002:a05:600c:34c2:b0:46e:21c8:ad37 with SMTP id 5b1f17b1804b1-46fa9b06d3dmr72900375e9.25.1760099379460; Fri, 10 Oct 2025 05:29:39 -0700 (PDT) Received: from localhost (054722ac.skybroadband.com. [5.71.34.172]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fab3e3520sm62462795e9.2.2025.10.10.05.29.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Oct 2025 05:29:38 -0700 (PDT) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 10 Oct 2025 13:29:38 +0100 Message-Id: From: "Alexey Klimov" To: "Konrad Dybcio" , "Bjorn Andersson" , "Linus Walleij" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Konrad Dybcio" , "Srinivas Kandagatla" Cc: "Dmitry Baryshkov" , , , , , Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: qcm2290: add LPASS LPI pin controller X-Mailer: aerc 0.20.1 References: <20251007-rb1_hdmi_audio-v2-0-821b6a705e4c@linaro.org> <20251007-rb1_hdmi_audio-v2-3-821b6a705e4c@linaro.org> In-Reply-To: On Tue Oct 7, 2025 at 1:39 PM BST, Konrad Dybcio wrote: > On 10/7/25 4:03 AM, Alexey Klimov wrote: >> Add the Low Power Audio SubSystem Low Power Island (LPASS LPI) pin >> controller device node required for audio subsystem on Qualcomm >> QRB2210 RB1. QRB2210 is based on qcm2290 which is based on sm6115. >>=20 >> While at this, also add description of lpi_i2s2 pins (active state) >> required for audio playback via HDMI/I2S. >>=20 >> Cc: Srinivas Kandagatla >> Signed-off-by: Alexey Klimov >> --- > > [...] > >> + lpi_i2s2_active: lpi-i2s2-active-state { >> + data-pins { >> + pins =3D "gpio12"; >> + function =3D "i2s2_data"; >> + bias-disable; >> + drive-strength =3D <8>; >> + output-high; > > I.. doubt output-high is what you want? Why? Or is it because of some in-kernel gpiod? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arc= h/arm64/boot/dts/qcom/sm4250.dtsi#n66 >> + }; >> + >> + sck-pins { >> + pins =3D "gpio10"; >> + function =3D "i2s2_clk"; >> + bias-disable; >> + drive-strength =3D <8>; >> + output-high; >> + }; >> + >> + ws-pins { >> + pins =3D "gpio11"; > > Please re-sort pin entries by the gpio index > > https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-o= f-nodes Ok. Thanks, Alexey.