From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E077346787 for ; Wed, 12 Nov 2025 17:16:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762967816; cv=none; b=OcHl6cURz58U5tTGkIKkvT+R1nsXYmsjvOiyLbbs0lCqQKH9WRzabJOdP5+VlsSe7M2IEhFs1H1hsh8UJunns0aoG2AMKJS/FNnhN9qkYPoy75YZhdqKPvh2ghcV5fEMJMMi+gXhsgYAoapHzbGct/PrvWhLTh+Jorxs5jzyWBU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762967816; c=relaxed/simple; bh=iiMESZBmokR5+/LPNrjKbowyRucTsoIMCT4ESK7O004=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=ItqSIdC8xPtQPjOBvgyq4hB3XV++pRsv/9MbVT9xYFfkESmLCUkTK3LCduhxQ1WsuDwJh9aXptdjODcJglhPAbGdoSmist0tWjU0D++9fce02Q6wN5vI8hdUCqvlVXl14Rk3Po/2k/RwKMMvQhbj1A1gWf2mub2MPtN2PbrnfWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GpRL7Cxr; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GpRL7Cxr" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-475ca9237c2so6416435e9.3 for ; Wed, 12 Nov 2025 09:16:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762967813; x=1763572613; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iiMESZBmokR5+/LPNrjKbowyRucTsoIMCT4ESK7O004=; b=GpRL7CxrRFx5sPYkiKaq/kIXW2ATW/s4UELrw2+KcNS1tux0hR5+SULsz1oK5AKVzb y+6o89hQwQXNnh3XjlmX7zFFtdrymI6+dXRIMENF/FdKv1EaWpXgjav7afrOR0+Cn4wj Kv1y0KEF+JmyUYuIp0a59um1mMV68r5DjwqLQvDFHN7jMIHA1A4cVazTBWD3BAUBswOr 0njPJ+8m94dSgcDeCgMzK5s+s6oLaaROCytaVWkolVQb5awzdWdalgBNPnNdHjr1lS0G ad2ygOSlLwTpums6JBsynHkuwH4A99ZqGhUgJ8UwVgsMrnV5uXWDxls+H4fRKLjOz40o +cew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762967813; x=1763572613; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iiMESZBmokR5+/LPNrjKbowyRucTsoIMCT4ESK7O004=; b=W+rjRGdmWLMtq9mf10QNQi0KzIGMKNSumb3r3rl+mTBXrumFe3LhLtoMzgBUt/XSo2 Xim2YTDeScgr6U0QY/BNKaqwQobMuE8itIjlG2uZjbsyIqbhT+sX67SaOyw8szYGDZ3v RdT0If3M3JhVDoaEZUtzESmPzKDjWwoMWH3j+aX0FevbrcWhmHqfrXpPmvGpf4g73TtB wXT7j3RIVwggxOC0Hh/j/z4yKKoXOCFXB28sLVj29f9ybgV6UGUG75s1IAvIOuQW7jfH LQWxCi4rMBfuM9m1LquCsA42HmMWbbK/MJjOzp18PC2s++8vDoAvKM7s2b57aGsGPC6N pzvg== X-Forwarded-Encrypted: i=1; AJvYcCWDirWf2MRJwGtk6AfgEfhlLGBSq4R0pkCOxA4FymNvcX6vPT8bTcXKrT9xja6zl+8d3WpXbUoZp5yx@vger.kernel.org X-Gm-Message-State: AOJu0YwD5qbo80xC7kRIaKoSEIc/l8Ec+dlJ0gs92L2Z2/CKj2Ys8S9d 8JiYwymkBQt1la6m6EW8etjM2+HIwyq7hJqpYYfm4EM9PVCV3fkCqhvvlxvF4HO2zCw= X-Gm-Gg: ASbGncsOk+l/hOxptlohdJS6h7UIKl2LQSn2gwcV0nY9/jei3wKJYVaVnqnS55IMfe9 p9wdM7/2gZoCNHeLR4wGj3frtfXXmWlZ4IJTYJSGWN/9MVrQ7PjFs2IQ/GsT5cu+Qh75zpQ7wOT NFZAw++j0sNcB3iS21aXYB5itZ8n1uDi0fXN9xIDCE5Osl08K2IcMGOWHsDrBxVjFo012+pUHAP SbDVVOKD1evMTTbXvtiFbuosoSKmq7xrNNDJIOex7n9LD8pBlJ/mwt6kTvVI/W0oMRiAOm4BLgl UtB2Z9/aYbl0Y6EZ+7D14uLlVx0BpjwmfBh6xS8aFXA/fd0ueuWFbzpBFEVMwmHVSItTuwyY+si Jf5TqaQXvfK8cPL0kzi0bFl35f+mntlmaWrY5peMCAr4t4ziD9qnhDzGYx2HaeQnnLZ6YRKVVaP Tak3wm X-Google-Smtp-Source: AGHT+IFK1LEgbdoe82XE3jZoJK10kkTDE6sfjAoioDSlpzb+hbqMgzQ5j6+nhIYvnoRpyBG+UEDLMg== X-Received: by 2002:a05:600c:45c4:b0:477:542a:7ed1 with SMTP id 5b1f17b1804b1-477870b9237mr36446515e9.19.1762967812580; Wed, 12 Nov 2025 09:16:52 -0800 (PST) Received: from localhost ([2a02:c7c:7259:a00:4fbd:5c9b:d8a2:ee64]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47787e51f54sm45322705e9.8.2025.11.12.09.16.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Nov 2025 09:16:52 -0800 (PST) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 12 Nov 2025 17:16:51 +0000 Message-Id: Subject: Re: [PATCH v3 06/12] ASoC: codecs: add wsa881x-i2c amplifier codec driver From: "Alexey Klimov" To: "Srinivas Kandagatla" , "Srinivas Kandagatla" , "Mark Brown" , Cc: "Mark Brown" , , "Liam Girdwood" , "Rob Herring" , "Krzysztof Kozlowski" , "Krzysztof Kozlowski" , "Conor Dooley" , "Bjorn Andersson" , "Dmitry Baryshkov" , "Konrad Dybcio" , "Konrad Dybcio" , "Jaroslav Kysela" , "Takashi Iwai" , , , , X-Mailer: aerc 0.20.0 References: <20250522-rb2_audio_v3-v3-0-9eeb08cab9dc@linaro.org> <20250522-rb2_audio_v3-v3-6-9eeb08cab9dc@linaro.org> <1c7d62f5-1816-4ecf-9376-2751ec06830b@gmail.com> In-Reply-To: <1c7d62f5-1816-4ecf-9376-2751ec06830b@gmail.com> Hello Srini, On Thu May 29, 2025 at 11:05 AM BST, Srinivas Kandagatla wrote: > > On 5/22/25 6:40 PM, Alexey Klimov wrote: >> Add support to analog mode of WSA8810/WSA8815 Class-D Smart Speaker >> family of amplifiers. Such amplifiers are primarily interfaced with >> SoundWire but they also support analog mode which is configurable by >> setting one of the pins to high/low. In such case the WSA881X amplifier >> is configurable only using i2c. >>=20 >> To have stereo two WSA881X amplifiers are required but mono >> configurations are also possible. [...] >> --- /dev/null >> +++ b/sound/soc/codecs/wsa881x-i2c.c [..] >> +struct reg_default wsa881x_ana_reg_defaults[] =3D { > > This does not make sense. > > All the regmaps should be same, it should not change with the change in > interface from SWD to I2C. > > Could you calrify this before we start reviewing rest of the driver. It was sent initially in nov 2024 I guess and that one was v3. v2 was sent in December 2024. I am currently reimplementing this. I obviously agree that registers are the same but why we should be 100% sure that regs defaults should be the same if the mode is different? Or do you suggest/expect that, for instance, analog defaults should be kinds applied on top of common (swd) default values? [....] (The rest of original email was sent and quoted but I did not see any comments there, so I removed it but if I missed smth there please let me know) Thanks, Alexey