From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C5652F998D; Thu, 11 Dec 2025 09:42:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765446181; cv=none; b=NYMczVOHlkNJRNZgk/ZVgD5NiItXcz3eTgQQFtxdkLGwBWvFn6U2X21M6lQMzza5Ex1zX3T6hQ3SA9QJh03iZGPCY5XBaOWrw8jrXUcCyafF2k2bmLN5mBNcqOnsJ/++SAX1TukU6SwG64xzUu49bDmKIjp6wzdvclVSS1Zh14M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765446181; c=relaxed/simple; bh=p4yhiEdqHPp6VgKPdi1QUcpge0/L2Md1zAgoZsacHiI=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=Z8Nr5sVMnS3NguuOGmQDr6xTqfbkq+9l/dcqwTg84Sn66Bd+EluIwfYuxZhRkD+tHHqZ5CSJfcaQ0+AlV4vCelFkRmMEYqqmEwH9CbXdtrBnlvMLWtf6mY6Y8iuDToSpwe/RC0b2kv0F3fzHv69z1fg99woiQhIm3fQomcq/0IU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=fpTiITXf; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="fpTiITXf" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 5DB121A20E3; Thu, 11 Dec 2025 09:42:58 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2E8356068C; Thu, 11 Dec 2025 09:42:58 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3C738103C8C1E; Thu, 11 Dec 2025 10:42:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765446177; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=p4yhiEdqHPp6VgKPdi1QUcpge0/L2Md1zAgoZsacHiI=; b=fpTiITXfCsh40SYD7VWJHqi5wBsspqquE0CxrrNPLtD/md5AnfSnWGfkUm9SOKrLEVtbnL Z99BI3AGBPXDR0+OQyocHivaJ4GAbj0vYuUqmmXmAagdmxWoXPRrJ5OcjiyL8ioHk0yWim wpY0vBTo5/BWwy8LYI0rP0emmxYaX2fY/SmBkLwADFA+JGJn8XSxG3hFaieBJCWBpOm/HU p/FJHg36tTI8wn+dfe2x/mNnIdUQ3gk7udOy52e3k1fV2JWcNoHA4aYvSEvPHxtnAkjHaz 7+k8gIyY/HDHS68hfpb3tMQqh3ngJjbJ9UoYaHZFu1nxGVVgS48GAXfNueARhQ== Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 11 Dec 2025 10:42:50 +0100 Message-Id: Subject: Re: [PATCH 08/21] drm/tilcdc: Remove component framework support Cc: "Markus Schneider-Pargmann" , "Louis Chauvet" , "Thomas Petazzoni" , "Miguel Gazquez" , , , , , To: "Kory Maincent (TI.com)" , "Jyri Sarha" , "Tomi Valkeinen" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Russell King" , "Bartosz Golaszewski" , "Tony Lindgren" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20251126-feature_tilcdc-v1-0-49b9ef2e3aa0@bootlin.com> <20251126-feature_tilcdc-v1-8-49b9ef2e3aa0@bootlin.com> In-Reply-To: <20251126-feature_tilcdc-v1-8-49b9ef2e3aa0@bootlin.com> X-Last-TLS-Session-Version: TLSv1.3 On Wed Nov 26, 2025 at 6:35 PM CET, Kory Maincent (TI.com) wrote: > The tilcdc driver previously used the component framework to bind > external encoder subdrivers (specifically the TDA998x HDMI encoder). > With the removal of these subdrivers in previous commits, the component > framework is no longer needed. > > This commit removes all component framework infrastructure including: > - Component master operations and bind/unbind callbacks > - The is_componentized flag and conditional code paths > - tilcdc_get_external_components() and tilcdc_add_component_encoder() > - TDA998x-specific panel configuration > > The driver now uses a simplified initialization path that directly > attaches external devices via the DRM bridge API, eliminating the > complexity of dual code paths for componentized vs non-componentized > configurations. > > This cleanup removes approximately 140 lines of code and makes the > driver initialization flow more straightforward. > > Signed-off-by: Kory Maincent (TI.com) This driver is complex already, supporting two different modes (one of which used in a single case only) makes it just worse. So this cleanup looks very useful. Provided it's tested on hardware: Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com