From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADD7F2FD67B for ; Thu, 11 Dec 2025 09:47:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765446469; cv=none; b=bFGqpxrVw0HMRxfEoelR+574F7aiPDsA6kJM3Bj7RepkM8p8zdGeLDEJSKGppku2KsXUZNB2bdnoqVO7Keg0SFzVXyXMc76f+oemBzOgfEcjwVjk/JL6YZr4nGCa1aGigom7W/yqpeCoHFp+Io/kQFb5P6KRdpFDN5Ms1WpIi40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765446469; c=relaxed/simple; bh=5/cZhTyEaxs+cMBKt/g8jpzzvxLdV/3sXD7smW34P3Y=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=nH9SB6ICW55KQYfYS3CFN06Dlh4ud8BoMunjyKWo281HmFbFBX38VRCHD9asWK7KIDgwYT3fe4KuDDjIHgh/SPAgSU5i3lnAqzIxVtb38SKHG2lXc2wXIRVv72IBZhKNAVyqGfmz6YHk5lFTKREvaO5ga7Q2D8BcqeJFBegut4A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=RGSe8UYm; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="RGSe8UYm" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id F2656C19342; Thu, 11 Dec 2025 09:47:20 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id F16AA6068C; Thu, 11 Dec 2025 09:47:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 06BA9103C8C1E; Thu, 11 Dec 2025 10:47:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765446463; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=dEYtoHd6truLlW9dDvvW4TyZqvth1FwMIgnGkOwvmQk=; b=RGSe8UYmgqic1d7gzrTAi6DwwYIydD58RU8J6fsmdoC5KlSEJclSPhwA9hemgK7p7TAyxb hLGOsvfjj0bVM4vks4oO+w20GsZOAkXbMLifL0QCJxE1oGW36lyEa36v4grMx2+PRF63ir inqrCx4Q+I9cc4QXro9EtuXKF14xvgVDPbE8BbAs4ykm46UbcLZCz0AIqjAdpU+rNGnW+5 0i4s2yiuKa/M8hfjtszF+uB89KxdDZiOmsrjUeeBMHPRyQWlww3fZvYT1Vhw7JTZII4k9P ML/tOQlh2X31xmjvB2bAR79Ojdv3x4BY0ox3b2l+56gDER59bOhtr2R0Lf9a3Q== Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 11 Dec 2025 10:47:39 +0100 Message-Id: Subject: Re: [PATCH 03/21] drm/tilcdc: Remove simulate_vesa_sync flag Cc: "Jyri Sarha" , "Tomi Valkeinen" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Russell King" , "Bartosz Golaszewski" , "Tony Lindgren" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Markus Schneider-Pargmann" , "Louis Chauvet" , "Thomas Petazzoni" , "Miguel Gazquez" , , , , , To: "Kory Maincent" From: "Luca Ceresoli" X-Mailer: aerc 0.20.1 References: <20251126-feature_tilcdc-v1-0-49b9ef2e3aa0@bootlin.com> <20251126-feature_tilcdc-v1-3-49b9ef2e3aa0@bootlin.com> <20251211104024.1e7d5c42@kmaincent-XPS-13-7390> In-Reply-To: <20251211104024.1e7d5c42@kmaincent-XPS-13-7390> X-Last-TLS-Session-Version: TLSv1.3 On Thu Dec 11, 2025 at 10:40 AM CET, Kory Maincent wrote: > On Wed, 10 Dec 2025 19:10:45 +0100 > "Luca Ceresoli" wrote: > >> Hi K=C3=B6ry, >> >> On Wed Nov 26, 2025 at 6:35 PM CET, Kory Maincent (TI.com) wrote: >> > The tilcdc hardware does not generate VESA-compliant sync signals. It >> > aligns the vertical sync (VS) on the second edge of the horizontal syn= c >> > (HS) instead of the first edge. To compensate for this hardware >> > behavior, the driver applies a timing adjustment in mode_fixup(). >> > >> > Previously, this adjustment was conditional based on the simulate_vesa= _sync >> > flag, which was only set when using external encoders. This appears >> > problematic because: >> > >> > 1. The timing adjustment seems needed for the hardware behavior regard= less >> > of whether an external encoder is used >> > 2. The external encoder infrastructure is driver-specific and being >> > removed due to design issues >> > 3. Boards using tilcdc without bridges (e.g., am335x-evm, am335x-evmsk= ) >> > may not be getting the necessary timing adjustments >> > >> > Remove the simulate_vesa_sync flag and apply the VESA sync timing >> > adjustment unconditionally, ensuring consistent behavior across all >> > configurations. While it's unclear if the previous conditional behavio= r >> > was causing actual issues, the unconditional adjustment better reflect= s >> > the hardware's characteristics. >> > >> > Signed-off-by: Kory Maincent (TI.com) >> > --- >> > >> > Only few board currently use tilcdc not associated to a bridge like th= e >> > am335x_evm or the am335x-evmsk. >> >> Have you tested this change on any affected board? >> >> The change looks good to me but without some testing it would be risky. > > I have tested it on few boards but not these mainline devicetree as I don= 't > have them. > > I have tested a tilcdc with tda998x bridge (BeagleBone Black), a tilcdc w= ith > ti,tilcdc,panel panel (BeagleBone with LCD cape), a tilcdc with it66121 b= ridge > (new Beagle Bone Green Eco board with HDMI cape). > That's all the boards I have. OK, thanks for the info. For future iterations, I think it's useful to mention, for all patches that may potentially break existing hardware, such info on which hardware you have tested. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com