public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kaustabh Chakraborty" <kauschluss@disroot.org>
To: "Conor Dooley" <conor@kernel.org>,
	"Kaustabh Chakraborty" <kauschluss@disroot.org>
Cc: "Yassine Oudjana" <y.oudjana@protonmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>, <linux-pm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: document Samsung S2MU005 battery fuel gauge
Date: Tue, 27 Jan 2026 01:45:35 +0530	[thread overview]
Message-ID: <DFYSP9E4NKZY.2Q5YX7RUOXUD5@disroot.org> (raw)
In-Reply-To: <20260126-goal-wasp-fa3f20d2a06a@spud>

On 2026-01-26 20:06 +00:00, Conor Dooley wrote:
> On Mon, Jan 26, 2026 at 09:09:48PM +0530, Kaustabh Chakraborty wrote:
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> +    i2c {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      fuelgauge@3b {
>
> Should be "fuel-gauge" iirc (at least, that's what all the bindings do).

There are a few which use "fuelgauge", but majority use "fuel-gauge".
Will change in the next revision.

> Seems fine to me though otherwise,
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> pw-bot: not-applicable
>
>> +        compatible = "samsung,s2mu005-fuel-gauge";
>> +        reg = <0x3b>;
>> +
>> +        interrupt-parent = <&gpa0>;
>> +        interrupts = <3 IRQ_TYPE_EDGE_BOTH>;
>> +
>> +        monitored-battery = <&battery>;
>> +      };
>> +    };
>> 
>> -- 
>> 2.52.0
>> 


  reply	other threads:[~2026-01-26 20:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 15:39 [PATCH 0/2] Add support for Samsung S2MU005 battery fuel gauge device Kaustabh Chakraborty
2026-01-26 15:39 ` [PATCH 1/2] dt-bindings: power: supply: document Samsung S2MU005 battery fuel gauge Kaustabh Chakraborty
2026-01-26 20:06   ` Conor Dooley
2026-01-26 20:15     ` Kaustabh Chakraborty [this message]
2026-01-26 15:39 ` [PATCH 2/2] power: supply: add support for S2MU005 battery fuel gauge device Kaustabh Chakraborty
2026-01-29  1:59   ` Sebastian Reichel
2026-01-31 11:14     ` Kaustabh Chakraborty
2026-02-01 11:14       ` Sebastian Reichel
2026-02-01 14:29         ` Kaustabh Chakraborty
2026-02-06 13:04         ` Kaustabh Chakraborty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFYSP9E4NKZY.2Q5YX7RUOXUD5@disroot.org \
    --to=kauschluss@disroot.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox