From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 585EE2AD0C for ; Tue, 10 Feb 2026 05:50:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770702650; cv=none; b=Y8uRKOm7KUA7R66jtRCw5+Aa+fy7whWC76m9LFMZNTzRBj5AdkPor5YoG8XgF24xOMnWhK7xzPzKFFMV4bkmNpF216g6gq8iENs46xdGVwZVEQ+eWYC9WGipsCLE65R5yDsWzyGWnd2pOF+yTyQaQXj9KGGKfrW+xaFY26pdaFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770702650; c=relaxed/simple; bh=JFqUNAJPbfntakYgXlVmPUWBmjS6ZT274Op0DauQgpg=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=TXMdQhBNcEvoeGn5+EzXaSoU3U8Yig2e0Gv0mqBvjQimg6YwfCxVjjBaYI/zyXyVO3joZ/T8SLhxxOQay3af5aR7BNRcFTw8QO7IwXhF2hOvZYvDC4rRKkBniLos3InChQTrm8rJAZ2mI9+lMFcnCRNoIPyh2Kw1/E4mIGqR2pg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=xKmyqxOK; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="xKmyqxOK" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770702646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JFqUNAJPbfntakYgXlVmPUWBmjS6ZT274Op0DauQgpg=; b=xKmyqxOKd8/xaTlxkb/W4z+DNBVpe10MC+GteYSStR81VuLNbYcB6DflytOpkoJuxjQ2Xs hFJylvG0GlZX+PsWuqAFBimHqkTKy4nDG2A4ekGUXZwZM8x2CM6bK61Dq9rQOgHuUQvk6v LaWj+8VwT1xRY8X7PeIl3xiSEy19iOs= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Feb 2026 13:50:32 +0800 Message-Id: Cc: , , , , , , , , , , , , , Subject: Re: [PATCH 1/2] dt-bindings: phy: spacemit: add regulator support to K1 USB2 PHY X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Ze Huang" To: "Chukun Pan" , References: <8c3835c4-3602-4cee-9631-0551b0341918@kernel.org> <20260209064016.1176056-1-amadeus@jmu.edu.cn> In-Reply-To: <20260209064016.1176056-1-amadeus@jmu.edu.cn> X-Migadu-Flow: FLOW_OUT On Mon Feb 9, 2026 at 2:40 PM CST, Chukun Pan wrote: > Hi, > >> Plus, if this was a vbus regulator it would not be called "phy"... >> Even more confusing. > > Sorry, I didn't consider that this naming is confusing. Other > platforms, such as Rockchip's inno-usb2phy driver, use the > "phy-supply" property. I continued with this bad naming. > >> Bindings are supposed to be complete regardless what driver does >> (or does not). >> >> You must list all supplies with proper names. >> >> If this regulator was missing, then what else? > > (...) > >> Please start describing in the bindings your complete hardware, not >> your drivers. > > It appears Ze Huang described the vbus-supply property in > spacemit.k1-dwc3.yaml. > > So I should enable the regulator in the dwc3-generic-plat driver. No, we will enable regulator at port level. > > Sorry for the noise. > > Thanks, > Chukun